Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(dev): give ssh key directories to www-data in development

Andras Bacsai2e03926c0109
diff --git a/database/seeders/PopulateSshKeysDirectorySeeder.php b/database/seeders/PopulateSshKeysDirectorySeeder.php
index 87984769ca..0318508c00 100644
--- a/database/seeders/PopulateSshKeysDirectorySeeder.php
+++ b/database/seeders/PopulateSshKeysDirectorySeeder.php
@@ -24,8 +24,8 @@ class PopulateSshKeysDirectorySeeder extends Seeder
});
if (isDev()) {
- Process::run('chown -R 9999:9999 '.storage_path('app/ssh/keys'));
- Process::run('chown -R 9999:9999 '.storage_path('app/ssh/mux'));
+ Process::run('chown -R www-data:www-data '.storage_path('app/ssh/keys'));
+ Process::run('chown -R www-data:www-data '.storage_path('app/ssh/mux'));
} else {
Process::run('chown -R 9999:root '.storage_path('app/ssh/keys'));
Process::run('chown -R 9999:root '.storage_path('app/ssh/mux'));
diff --git a/tests/Feature/PopulateSshKeysDirectorySeederTest.php b/tests/Feature/PopulateSshKeysDirectorySeederTest.php
new file mode 100644
index 0000000000..b12d7cc3f5
--- /dev/null
+++ b/tests/Feature/PopulateSshKeysDirectorySeederTest.php
@@ -0,0 +1,33 @@
+<?php
+
+use Database\Seeders\PopulateSshKeysDirectorySeeder;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\Process;
+use Illuminate\Support\Facades\Storage;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+ Storage::fake('ssh-keys');
+ Storage::fake('ssh-mux');
+ Process::fake();
+});
+
+it('gives the ssh directories to the php-fpm user in development', function () {
+ config()->set('app.env', 'local');
+
+ app(PopulateSshKeysDirectorySeeder::class)->run();
+
+ Process::assertRan('chown -R www-data:www-data '.storage_path('app/ssh/keys'));
+ Process::assertRan('chown -R www-data:www-data '.storage_path('app/ssh/mux'));
+ Process::assertDidntRun(fn ($process) => str_contains($process->command, '9999'));
+});
+
+it('gives the ssh directories to uid 9999 in production', function () {
+ config()->set('app.env', 'production');
+
+ app(PopulateSshKeysDirectorySeeder::class)->run();
+
+ Process::assertRan('chown -R 9999:root '.storage_path('app/ssh/keys'));
+ Process::assertRan('chown -R 9999:root '.storage_path('app/ssh/mux'));
+});