An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(security): authorize import file checks and Vultr status refresh
Andras Bacsai3379f85c0a87
diff --git a/app/Livewire/Project/Database/ImportForm.php b/app/Livewire/Project/Database/ImportForm.phpindex e16c7e331b..638101b3c1 100644--- a/app/Livewire/Project/Database/ImportForm.php+++ b/app/Livewire/Project/Database/ImportForm.php@@ -403,6 +403,8 @@ class ImportForm extends Componentpublic function checkFile(){+ $this->authorize('update', $this->resource);+if (filled($this->customLocation)) {// Validate the custom location to prevent command injectionif (! $this->validateServerPath($this->customLocation)) {@@ -524,6 +526,8 @@ class ImportForm extends Componentpublic function checkS3File(){+ $this->authorize('update', $this->resource);+if (! $this->s3StorageId) {$this->dispatch('error', 'Please select an S3 storage.');diff --git a/app/Livewire/Server/Show.php b/app/Livewire/Server/Show.phpindex 707af97515..e596a9c2f9 100644--- a/app/Livewire/Server/Show.php+++ b/app/Livewire/Server/Show.php@@ -590,6 +590,7 @@ class Show extends Componentpublic function checkVultrInstanceStatus(bool $manual = false){try {+ $this->authorize('view', $this->server);if (! $this->server->vultr_instance_id || ! $this->server->cloudProviderToken) {$this->dispatch('error', 'This server is not associated with a Vultr instance or token.');diff --git a/tests/Feature/DatabaseImportFormFileCheckAuthorizationTest.php b/tests/Feature/DatabaseImportFormFileCheckAuthorizationTest.phpnew file mode 100644index 0000000000..a5de664ee1--- /dev/null+++ b/tests/Feature/DatabaseImportFormFileCheckAuthorizationTest.php@@ -0,0 +1,104 @@+<?php++use App\Livewire\Project\Database\ImportForm;+use App\Models\Environment;+use App\Models\InstanceSettings;+use App\Models\Project;+use App\Models\Server;+use App\Models\StandaloneDocker;+use App\Models\StandalonePostgresql;+use App\Models\Team;+use App\Models\User;+use Illuminate\Foundation\Testing\RefreshDatabase;+use Illuminate\Support\Str;+use Livewire\Features\SupportTesting\Testable;+use Livewire\Livewire;++uses(RefreshDatabase::class);++beforeEach(function () {+ InstanceSettings::forceCreate(['id' => 0]);++ $this->team = Team::factory()->create();+ $this->server = Server::factory()->create(['team_id' => $this->team->id]);+ $destination = StandaloneDocker::firstOrCreate(+ ['server_id' => $this->server->id, 'network' => 'coolify'],+ ['uuid' => (string) Str::uuid(), 'name' => 'docker']+ );+ $project = Project::factory()->create(['team_id' => $this->team->id]);+ $environment = Environment::factory()->create(['project_id' => $project->id]);+ $this->database = StandalonePostgresql::create([+ 'uuid' => (string) Str::uuid(),+ 'name' => 'db',+ 'postgres_user' => 'postgres',+ 'postgres_password' => 'password',+ 'postgres_db' => 'db',+ 'image' => 'postgres:17',+ 'status' => 'running',+ 'environment_id' => $environment->id,+ 'destination_id' => $destination->id,+ 'destination_type' => $destination->getMorphClass(),+ ]);+});++class ImportFormFileCheckAuthorizationTestComponent extends ImportForm+{+ public function mount($database = null, $server = null): void+ {+ $this->resourceId = $database->id;+ $this->resourceType = $database::class;+ $this->serverId = $server->id;+ $this->container = $database->uuid;+ $this->resourceUuid = $database->uuid;+ $this->resourceStatus = $database->status ?? '';+ $this->resourceDbType = $database->type();+ }++ public function render()+ {+ return view('livewire.project.database.import-form');+ }+}++function importFormFileCheckAs(Team $team, string $role): Testable+{+ $user = User::factory()->create();+ $team->members()->attach($user, ['role' => $role]);+ test()->actingAs($user);+ session(['currentTeam' => $team]);++ return Livewire::test(ImportFormFileCheckAuthorizationTestComponent::class, [+ 'database' => test()->database,+ 'server' => test()->server,+ ]);+}++it('forbids members from checking a server file', function () {+ importFormFileCheckAs($this->team, 'member')+ ->set('customLocation', 'not-an-absolute-path')+ ->call('checkFile')+ ->assertForbidden();+});++it('forbids members from checking an S3 file', function () {+ importFormFileCheckAs($this->team, 'member')+ ->call('checkS3File')+ ->assertForbidden();+});++it('lets admins and owners check files', function (string $role) {+ importFormFileCheckAs($this->team, $role)+ ->set('customLocation', 'not-an-absolute-path')+ ->call('checkFile')+ ->assertDispatched('error', 'Invalid file path. Path must be absolute and contain only safe characters (alphanumerics, dots, dashes, underscores, slashes).')+ ->call('checkS3File')+ ->assertDispatched('error', 'Please select an S3 storage.');+})->with(['admin', 'owner']);++it('does nothing when an admin checks an empty server path', function () {+ importFormFileCheckAs($this->team, 'admin')+ ->set('customLocation', '')+ ->call('checkFile')+ ->assertNotDispatched('error')+ ->assertSet('filename', null);+});diff --git a/tests/Feature/VultrServerLifecycleTest.php b/tests/Feature/VultrServerLifecycleTest.phpindex fbda1e48bd..7efae02878 100644--- a/tests/Feature/VultrServerLifecycleTest.php+++ b/tests/Feature/VultrServerLifecycleTest.php@@ -340,3 +340,24 @@ it('links a server to Vultr by matching IP', function () {'vultr_instance_status' => 'active',]);});++it('does not refresh Vultr status for a user outside the server team', function () {+ Http::fake([+ 'https://api.vultr.com/v2/instances/instance-1' => Http::response([+ 'instance' => ['id' => 'instance-1', 'status' => 'active'],+ ], 200),+ ]);++ $component = Livewire::test(Show::class, ['server_uuid' => $this->server->uuid]);++ $outsider = User::factory()->create();+ Team::factory()->create()->members()->attach($outsider->id, ['role' => 'owner']);+ $this->actingAs($outsider);++ $component->call('checkVultrInstanceStatus', true)+ ->assertDispatched('error')+ ->assertNotDispatched('success');++ expect($this->server->fresh()->vultr_instance_status)->toBe('pending');+ Http::assertNothingSent();+});diff --git a/tests/Unit/Project/Database/ImportCheckFileButtonTest.php b/tests/Unit/Project/Database/ImportCheckFileButtonTest.phpindex 087a40a379..4a380381cd 100644--- a/tests/Unit/Project/Database/ImportCheckFileButtonTest.php+++ b/tests/Unit/Project/Database/ImportCheckFileButtonTest.php@@ -2,16 +2,6 @@use App\Livewire\Project\Database\ImportForm;-test('checkFile does nothing when customLocation is empty', function () {- $component = new ImportForm;- $component->customLocation = '';-- // No server commands should be executed when customLocation is empty- $component->checkFile();-- expect($component->filename)->toBeNull();-});-test('checkFile validates file exists on server when customLocation is filled', function () {$component = new ImportForm;$component->customLocation = '/tmp/backup.sql';