An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(security): enforce team-scoped project/env lookups in onboarding
Andras Bacsai3ba4553df565
diff --git a/app/Livewire/Boarding/Index.php b/app/Livewire/Boarding/Index.phpindex d7fa67b7bc..7e11218601 100644--- a/app/Livewire/Boarding/Index.php+++ b/app/Livewire/Boarding/Index.php@@ -432,6 +432,9 @@ class Index extends Componentpublic function selectExistingProject(){$this->createdProject = Project::ownedByCurrentTeam()->find($this->selectedProject);+ if (! $this->createdProject) {+ return $this->dispatch('error', 'Project not found.');+ }$this->currentState = 'create-resource';}diff --git a/app/Livewire/Project/New/DockerCompose.php b/app/Livewire/Project/New/DockerCompose.phpindex 5732e0cd58..2b92902c6b 100644--- a/app/Livewire/Project/New/DockerCompose.php+++ b/app/Livewire/Project/New/DockerCompose.php@@ -41,8 +41,8 @@ class DockerCompose extends Component// Validate for command injection BEFORE saving to databasevalidateDockerComposeForInjection($this->dockerComposeRaw);- $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->first();- $environment = $project->load(['environments'])->environments->where('uuid', $this->parameters['environment_uuid'])->first();+ $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->firstOrFail();+ $environment = $project->environments()->where('uuid', $this->parameters['environment_uuid'])->firstOrFail();$destination_uuid = $this->query['destination'];$destination = StandaloneDocker::where('uuid', $destination_uuid)->first();diff --git a/app/Livewire/Project/New/DockerImage.php b/app/Livewire/Project/New/DockerImage.phpindex 545afdd0b2..268333d075 100644--- a/app/Livewire/Project/New/DockerImage.php+++ b/app/Livewire/Project/New/DockerImage.php@@ -121,8 +121,8 @@ class DockerImage extends Component}$destination_class = $destination->getMorphClass();- $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->first();- $environment = $project->load(['environments'])->environments->where('uuid', $this->parameters['environment_uuid'])->first();+ $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->firstOrFail();+ $environment = $project->environments()->where('uuid', $this->parameters['environment_uuid'])->firstOrFail();// Append @sha256 to image name if using digest and not already present$imageName = $parser->getFullImageNameWithoutTag();diff --git a/app/Livewire/Project/New/GithubPrivateRepository.php b/app/Livewire/Project/New/GithubPrivateRepository.phpindex d1993b4aca..86424642d7 100644--- a/app/Livewire/Project/New/GithubPrivateRepository.php+++ b/app/Livewire/Project/New/GithubPrivateRepository.php@@ -185,8 +185,8 @@ class GithubPrivateRepository extends Component}$destination_class = $destination->getMorphClass();- $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->first();- $environment = $project->load(['environments'])->environments->where('uuid', $this->parameters['environment_uuid'])->first();+ $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->firstOrFail();+ $environment = $project->environments()->where('uuid', $this->parameters['environment_uuid'])->firstOrFail();$application = Application::create(['name' => generate_application_name($this->selected_repository_owner.'/'.$this->selected_repository_repo, $this->selected_branch_name),diff --git a/app/Livewire/Project/New/GithubPrivateRepositoryDeployKey.php b/app/Livewire/Project/New/GithubPrivateRepositoryDeployKey.phpindex 30c8ded4fa..94ef23cc9b 100644--- a/app/Livewire/Project/New/GithubPrivateRepositoryDeployKey.php+++ b/app/Livewire/Project/New/GithubPrivateRepositoryDeployKey.php@@ -144,8 +144,8 @@ class GithubPrivateRepositoryDeployKey extends Component// Note: git_repository has already been validated and transformed in get_git_source()// It may now be in SSH format (git@host:repo.git) which is valid for deploy keys- $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->first();- $environment = $project->load(['environments'])->environments->where('uuid', $this->parameters['environment_uuid'])->first();+ $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->firstOrFail();+ $environment = $project->environments()->where('uuid', $this->parameters['environment_uuid'])->firstOrFail();if ($this->git_source === 'other') {$application_init = ['name' => generate_random_name(),diff --git a/app/Livewire/Project/New/PublicGitRepository.php b/app/Livewire/Project/New/PublicGitRepository.phpindex 731584edf9..9c9ddb8ceb 100644--- a/app/Livewire/Project/New/PublicGitRepository.php+++ b/app/Livewire/Project/New/PublicGitRepository.php@@ -278,8 +278,8 @@ class PublicGitRepository extends Component}$destination_class = $destination->getMorphClass();- $project = Project::ownedByCurrentTeam()->where('uuid', $project_uuid)->first();- $environment = $project->load(['environments'])->environments->where('uuid', $environment_uuid)->first();+ $project = Project::ownedByCurrentTeam()->where('uuid', $project_uuid)->firstOrFail();+ $environment = $project->environments()->where('uuid', $environment_uuid)->firstOrFail();if ($this->build_pack === 'dockercompose' && isDev() && $this->new_compose_services) {$server = $destination->server;diff --git a/app/Livewire/Project/New/SimpleDockerfile.php b/app/Livewire/Project/New/SimpleDockerfile.phpindex a87da78846..1073157e63 100644--- a/app/Livewire/Project/New/SimpleDockerfile.php+++ b/app/Livewire/Project/New/SimpleDockerfile.php@@ -45,8 +45,8 @@ CMD ["nginx", "-g", "daemon off;"]}$destination_class = $destination->getMorphClass();- $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->first();- $environment = $project->load(['environments'])->environments->where('uuid', $this->parameters['environment_uuid'])->first();+ $project = Project::ownedByCurrentTeam()->where('uuid', $this->parameters['project_uuid'])->firstOrFail();+ $environment = $project->environments()->where('uuid', $this->parameters['environment_uuid'])->firstOrFail();$port = get_port_from_dockerfile($this->dockerfile);if (! $port) {diff --git a/tests/Feature/CrossTeamIdorServerProjectTest.php b/tests/Feature/CrossTeamIdorServerProjectTest.phpindex 173dae5cda..671397a1ed 100644--- a/tests/Feature/CrossTeamIdorServerProjectTest.php+++ b/tests/Feature/CrossTeamIdorServerProjectTest.php@@ -78,6 +78,7 @@ describe('Boarding Project IDOR (GHSA-qfcc-2fm3-9q42)', function () {->call('selectExistingProject');expect($component->get('createdProject'))->toBeNull();+ $component->assertDispatched('error');});test('boarding selectExistingProject can load own team project', function () {@@ -115,8 +116,7 @@ describe('GlobalSearch Project IDOR (GHSA-qfcc-2fm3-9q42)', function () {describe('DeleteProject IDOR (GHSA-qfcc-2fm3-9q42)', function () {test('cannot mount DeleteProject with project from another team', function () {// Should throw ModelNotFoundException (404) because team-scoped query won't find it- Livewire::test(DeleteProject::class, ['project_id' => $this->projectB->id])- ->assertStatus(500); // findOrFail throws ModelNotFoundException+ Livewire::test(DeleteProject::class, ['project_id' => $this->projectB->id]);})->throws(\Illuminate\Database\Eloquent\ModelNotFoundException::class);test('can mount DeleteProject with own team project', function () {