An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(mcp): change enable/disable endpoints from GET to POST and fix service/app listing
Andras Bacsai45f65481e637
diff --git a/app/Http/Controllers/Api/OtherController.php b/app/Http/Controllers/Api/OtherController.phpindex 17c5a884ae..f17a4e46bb 100644--- a/app/Http/Controllers/Api/OtherController.php+++ b/app/Http/Controllers/Api/OtherController.php@@ -153,7 +153,7 @@ class OtherController extends Controllerreturn response()->json(['message' => 'API disabled.'], 200);}- #[OA\Get(+ #[OA\Post(summary: 'Enable MCP Server',description: 'Enable the MCP server endpoint at /mcp (only with root permissions).',path: '/mcp/enable',@@ -209,7 +209,7 @@ class OtherController extends Controllerreturn response()->json(['message' => 'MCP server enabled.'], 200);}- #[OA\Get(+ #[OA\Post(summary: 'Disable MCP Server',description: 'Disable the MCP server endpoint at /mcp (only with root permissions).',path: '/mcp/disable',diff --git a/app/Mcp/Tools/ListApplications.php b/app/Mcp/Tools/ListApplications.phpindex 947d49ed14..815edd61ae 100644--- a/app/Mcp/Tools/ListApplications.php+++ b/app/Mcp/Tools/ListApplications.php@@ -31,10 +31,13 @@ class ListApplications extends Tool}$tagName = $request->get('tag');+ if ($tagName !== null && (! is_string($tagName) || trim($tagName) === '')) {+ return Response::error('tag argument must be a non-empty string.');+ }$args = $this->paginationArgs($request);$query = Application::ownedByCurrentTeamAPI($teamId)- ->when($tagName, function ($query, $tagName) {+ ->when($tagName !== null, function ($query) use ($tagName) {$query->whereHas('tags', fn ($q) => $q->where('name', $tagName));});diff --git a/app/Mcp/Tools/ListServices.php b/app/Mcp/Tools/ListServices.phpindex 4b33231ba2..b0bff4fad5 100644--- a/app/Mcp/Tools/ListServices.php+++ b/app/Mcp/Tools/ListServices.php@@ -4,7 +4,7 @@ namespace App\Mcp\Tools;use App\Mcp\Concerns\BuildsResponse;use App\Mcp\Concerns\ResolvesTeam;-use App\Models\Project;+use App\Models\Service;use Illuminate\Contracts\JsonSchema\JsonSchema;use Laravel\Mcp\Request;use Laravel\Mcp\Response;@@ -32,17 +32,15 @@ class ListServices extends Tool$args = $this->paginationArgs($request);- $projects = Project::where('team_id', $teamId)->get();- $services = collect();- foreach ($projects as $project) {- $services = $services->merge($project->services()->get());- }+ $query = Service::whereHas('environment.project', fn ($q) => $q->where('team_id', $teamId));- $total = $services->count();+ $total = (clone $query)->count();- $summaries = $services- ->sortBy('name')- ->slice($args['offset'], $args['per_page'])+ $summaries = $query+ ->orderBy('name')+ ->skip($args['offset'])+ ->take($args['per_page'])+ ->get()->map(fn ($svc) => ['uuid' => $svc->uuid,'name' => $svc->name,diff --git a/openapi.json b/openapi.jsonindex c35c0cdd6c..711c7d8f30 100644--- a/openapi.json+++ b/openapi.json@@ -8651,7 +8651,7 @@}},"\/mcp\/enable": {- "get": {+ "post": {"summary": "Enable MCP Server","description": "Enable the MCP server endpoint at \/mcp (only with root permissions).","operationId": "enable-mcp",@@ -8703,7 +8703,7 @@}},"\/mcp\/disable": {- "get": {+ "post": {"summary": "Disable MCP Server","description": "Disable the MCP server endpoint at \/mcp (only with root permissions).","operationId": "disable-mcp",diff --git a/openapi.yaml b/openapi.yamlindex eab5316745..fef77f5a72 100644--- a/openapi.yaml+++ b/openapi.yaml@@ -5485,7 +5485,7 @@ paths:-bearerAuth: []/mcp/enable:- get:+ post:summary: 'Enable MCP Server'description: 'Enable the MCP server endpoint at /mcp (only with root permissions).'operationId: enable-mcp@@ -5514,7 +5514,7 @@ paths:-bearerAuth: []/mcp/disable:- get:+ post:summary: 'Disable MCP Server'description: 'Disable the MCP server endpoint at /mcp (only with root permissions).'operationId: disable-mcpdiff --git a/routes/api.php b/routes/api.phpindex f38576d4d9..38ded350ae 100644--- a/routes/api.php+++ b/routes/api.php@@ -35,8 +35,8 @@ Route::group([], function () {Route::get('/enable', [OtherController::class, 'enable_api']);Route::get('/disable', [OtherController::class, 'disable_api']);- Route::get('/mcp/enable', [OtherController::class, 'enable_mcp']);- Route::get('/mcp/disable', [OtherController::class, 'disable_mcp']);+ Route::post('/mcp/enable', [OtherController::class, 'enable_mcp']);+ Route::post('/mcp/disable', [OtherController::class, 'disable_mcp']);});Route::group(['middleware' => ['auth:sanctum', ApiAllowed::class, 'api.sensitive'],diff --git a/tests/Feature/Mcp/McpToggleApiTest.php b/tests/Feature/Mcp/McpToggleApiTest.phpindex 2700f9b7b0..68d5d335a6 100644--- a/tests/Feature/Mcp/McpToggleApiTest.php+++ b/tests/Feature/Mcp/McpToggleApiTest.php@@ -43,25 +43,25 @@ function makeNonRootMcpToken(User $user, Team $team, array $abilities = ['write'return $token->plainTextToken;}-test('GET /api/v1/mcp/enable enables MCP server with root token', function () {+test('POST /api/v1/mcp/enable enables MCP server with root token', function () {$token = makeRootMcpToken($this->user);$response = test()->withHeaders(['Authorization' => 'Bearer '.$token,- ])->getJson('/api/v1/mcp/enable');+ ])->postJson('/api/v1/mcp/enable');$response->assertOk();$response->assertJson(['message' => 'MCP server enabled.']);expect(InstanceSettings::find(0)->is_mcp_server_enabled)->toBeTrue();});-test('GET /api/v1/mcp/disable disables MCP server with root token', function () {+test('POST /api/v1/mcp/disable disables MCP server with root token', function () {InstanceSettings::query()->where('id', 0)->update(['is_mcp_server_enabled' => true]);$token = makeRootMcpToken($this->user);$response = test()->withHeaders(['Authorization' => 'Bearer '.$token,- ])->getJson('/api/v1/mcp/disable');+ ])->postJson('/api/v1/mcp/disable');$response->assertOk();$response->assertJson(['message' => 'MCP server disabled.']);@@ -73,7 +73,7 @@ test('non-root token cannot enable MCP server', function () {$response = test()->withHeaders(['Authorization' => 'Bearer '.$token,- ])->getJson('/api/v1/mcp/enable');+ ])->postJson('/api/v1/mcp/enable');$response->assertStatus(403);expect(InstanceSettings::find(0)->is_mcp_server_enabled)->toBeFalse();@@ -85,14 +85,14 @@ test('non-root token cannot disable MCP server', function () {$response = test()->withHeaders(['Authorization' => 'Bearer '.$token,- ])->getJson('/api/v1/mcp/disable');+ ])->postJson('/api/v1/mcp/disable');$response->assertStatus(403);expect(InstanceSettings::find(0)->is_mcp_server_enabled)->toBeTrue();});test('unauthenticated request to /api/v1/mcp/enable returns 401', function () {- $response = test()->getJson('/api/v1/mcp/enable');+ $response = test()->postJson('/api/v1/mcp/enable');$response->assertStatus(401);});@@ -101,7 +101,7 @@ test('read-only token cannot toggle MCP server (lacks write ability)', function$response = test()->withHeaders(['Authorization' => 'Bearer '.$token,- ])->getJson('/api/v1/mcp/enable');+ ])->postJson('/api/v1/mcp/enable');$response->assertStatus(403);});