Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(deployment): properly escape shell arguments in railpack prepare command

Andras Bacsai4afcbbb2096d
diff --git a/app/Jobs/ApplicationDeploymentJob.php b/app/Jobs/ApplicationDeploymentJob.php
index 13511957f5..f4ec4abda3 100644
--- a/app/Jobs/ApplicationDeploymentJob.php
+++ b/app/Jobs/ApplicationDeploymentJob.php
@@ -2454,13 +2454,13 @@ class ApplicationDeploymentJob implements ShouldBeEncrypted, ShouldQueue
$prepare_command .= " {$this->env_railpack_args}";
}
if ($this->application->build_command) {
- $prepare_command .= " --build-cmd \"{$this->application->build_command}\"";
+ $prepare_command .= ' --build-cmd '.escapeShellValue($this->application->build_command);
}
if ($this->application->start_command) {
- $prepare_command .= " --start-cmd \"{$this->application->start_command}\"";
+ $prepare_command .= ' --start-cmd '.escapeShellValue($this->application->start_command);
}
if ($this->application->install_command) {
- $prepare_command .= " --env RAILPACK_INSTALL_CMD=\"{$this->application->install_command}\"";
+ $prepare_command .= ' --env '.escapeShellValue("RAILPACK_INSTALL_CMD={$this->application->install_command}");
}
$prepare_command .= " --plan-out /artifacts/railpack-plan.json {$this->workdir}";