Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(sentinel): validate push containers payload

Andras Bacsai7677fac2f594
diff --git a/app/Http/Controllers/Api/SentinelController.php b/app/Http/Controllers/Api/SentinelController.php
index 4a469f09c1..7343533868 100644
--- a/app/Http/Controllers/Api/SentinelController.php
+++ b/app/Http/Controllers/Api/SentinelController.php
@@ -8,6 +8,7 @@ use App\Models\Server;
use Exception;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Cache;
+use Illuminate\Support\Facades\Validator;
class SentinelController extends Controller
{
@@ -77,6 +78,17 @@ class SentinelController extends Controller
return response()->json(['message' => 'Unauthorized'], 401);
}
+ $validator = Validator::make($request->all(), [
+ 'containers' => ['required', 'array', 'min:1'],
+ ]);
+
+ if ($validator->fails()) {
+ return response()->json(serializeApiResponse([
+ 'message' => 'Validation failed.',
+ 'errors' => $validator->errors(),
+ ]), 422);
+ }
+
$data = $request->all();
// Heartbeat MUST update on every push — drives isSentinelLive() and SSH-check skipping.
diff --git a/tests/Feature/SentinelPushDeduplicationTest.php b/tests/Feature/SentinelPushDeduplicationTest.php
index e5995a6874..c4a887da4d 100644
--- a/tests/Feature/SentinelPushDeduplicationTest.php
+++ b/tests/Feature/SentinelPushDeduplicationTest.php
@@ -11,6 +11,8 @@ use Illuminate\Support\Facades\Queue;
uses(RefreshDatabase::class);
beforeEach(function () {
+ config(['app.maintenance.store' => 'array']);
+
Queue::fake();
Cache::flush();
@@ -69,6 +71,25 @@ it('updates the heartbeat even when the job is skipped', function () use ($runni
expect(Carbon::parse($this->server->fresh()->sentinel_updated_at)->diffInSeconds(now()))->toBeLessThan(5);
});
+it('rejects malformed sentinel payloads before touching server state', function (array $payload) {
+ $this->server->update(['sentinel_updated_at' => now()->subHour()]);
+ $originalHeartbeat = $this->server->fresh()->sentinel_updated_at;
+
+ pushSentinel($this->token, $payload)
+ ->assertUnprocessable()
+ ->assertJsonPath('message', 'Validation failed.')
+ ->assertJsonValidationErrors('containers');
+
+ Queue::assertNotPushed(PushServerUpdateJob::class);
+ expect($this->server->fresh()->sentinel_updated_at)->toBe($originalHeartbeat);
+ expect(Cache::has('sentinel:push-hash:'.$this->server->id))->toBeFalse();
+ expect(Cache::has('sentinel:push-force:'.$this->server->id))->toBeFalse();
+})->with([
+ 'missing containers' => [[]],
+ 'non-array containers' => [['containers' => 'not-an-array']],
+ 'empty containers' => [['containers' => []]],
+]);
+
it('dispatches the job when container state changes', function () use ($running) {
pushSentinel($this->token, sentinelPayload($running()))->assertOk();