Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(realtime): remove orphaned legacy containers with zero replicas

Andras Bacsai8bd78b34845d
diff --git a/docker-compose.prod.yml b/docker-compose.prod.yml
index b927388a6d..3a63b279d7 100644
--- a/docker-compose.prod.yml
+++ b/docker-compose.prod.yml
@@ -1,11 +1,12 @@
services:
# Placeholder for "soketi" overrides in docker-compose.custom.yml from versions before 4.4.
# Realtime runs inside the coolify container now. Without this entry, such an override is an
- # incomplete service and every upgrade fails; the inactive profile means it never starts.
+ # incomplete service and every upgrade fails. Zero replicas means it never starts, and
+ # "docker compose up" removes the old coolify-realtime container (an inactive profile keeps it).
soketi:
image: busybox:1.37
- profiles:
- - legacy-soketi
+ deploy:
+ replicas: 0
coolify:
image: "${REGISTRY_URL:-docker.io}/coollabsio/coolify:${LATEST_IMAGE:-latest}"
volumes:
diff --git a/other/nightly/docker-compose.prod.yml b/other/nightly/docker-compose.prod.yml
index b927388a6d..3a63b279d7 100644
--- a/other/nightly/docker-compose.prod.yml
+++ b/other/nightly/docker-compose.prod.yml
@@ -1,11 +1,12 @@
services:
# Placeholder for "soketi" overrides in docker-compose.custom.yml from versions before 4.4.
# Realtime runs inside the coolify container now. Without this entry, such an override is an
- # incomplete service and every upgrade fails; the inactive profile means it never starts.
+ # incomplete service and every upgrade fails. Zero replicas means it never starts, and
+ # "docker compose up" removes the old coolify-realtime container (an inactive profile keeps it).
soketi:
image: busybox:1.37
- profiles:
- - legacy-soketi
+ deploy:
+ replicas: 0
coolify:
image: "${REGISTRY_URL:-docker.io}/coollabsio/coolify:${LATEST_IMAGE:-latest}"
volumes:
diff --git a/tests/Feature/ReverbAndTerminalPackagingTest.php b/tests/Feature/ReverbAndTerminalPackagingTest.php
index eb9e828a9d..440e069875 100644
--- a/tests/Feature/ReverbAndTerminalPackagingTest.php
+++ b/tests/Feature/ReverbAndTerminalPackagingTest.php
@@ -125,8 +125,8 @@ it('removes the dedicated realtime service from bundled compose files', function
$soketi = Yaml::parse($composeContents)['services']['soketi'] ?? null;
// Production keeps "coolify-realtime" only as a network alias of the coolify container, and "soketi"
- // only as an inactive placeholder for old overrides in docker-compose.custom.yml.
- expect($soketi === null || array_keys($soketi) === ['image', 'profiles'])->toBeTrue();
+ // only as a placeholder with no replicas for old overrides in docker-compose.custom.yml.
+ expect($soketi === null || $soketi === ['image' => 'busybox:1.37', 'deploy' => ['replicas' => 0]])->toBeTrue();
expect($composeContents)
->not->toContain('container_name: coolify-realtime')
->not->toContain('coolify-realtime:')
@@ -309,7 +309,7 @@ it('uses current Reverb and terminal names in development tooling', function ()
->not->toContain('SOKETI');
});
-it('accepts a soketi override from 4.3.23 in docker-compose.custom.yml without starting soketi', function (string $composeFile, string $override) {
+it('accepts a soketi override from 4.3.23 in docker-compose.custom.yml with zero soketi replicas', function (string $composeFile, string $override) {
if (! (new ExecutableFinder)->find('docker')) {
$this->markTestSkipped('Docker is not installed.');
}
@@ -320,14 +320,17 @@ it('accepts a soketi override from 4.3.23 in docker-compose.custom.yml without s
file_put_contents("{$directory}/docker-compose.custom.yml", $override);
try {
- $result = Process::path($directory)->run('docker compose -f docker-compose.yml -f docker-compose.prod.yml -f docker-compose.custom.yml config --services');
+ $result = Process::path($directory)->run('docker compose -f docker-compose.yml -f docker-compose.prod.yml -f docker-compose.custom.yml config --no-env-resolution --format json');
} finally {
File::deleteDirectory($directory);
}
+ // Zero replicas, not an inactive profile: "docker compose up" then also removes the old coolify-realtime
+ // container. An inactive profile keeps it running, even with --remove-orphans.
expect($result->successful())->toBeTrue($result->errorOutput())
- ->and(array_filter(explode("\n", trim($result->output()))))->not->toContain('soketi')
- ->toContain('coolify');
+ ->and(json_decode($result->output(), true)['services'])
+ ->toHaveKey('coolify')
+ ->toHaveKey('soketi.deploy.replicas', 0);
})->with([
'production compose, partial override' => ['docker-compose.prod.yml', "services:\n soketi:\n environment:\n SOKETI_DEBUG: 'true'\n ports:\n - '6001:6001'\n"],
'production compose, full service' => ['docker-compose.prod.yml', "services:\n soketi:\n image: quay.io/soketi/soketi:1.6-16-alpine\n container_name: coolify-realtime\n ports:\n - '6001:6001'\n"],