Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

chore(notifications): remove debug logging from Pushover message

Andras Bacsai8d29e3c62fa1
diff --git a/app/Notifications/Dto/PushoverMessage.php b/app/Notifications/Dto/PushoverMessage.php
index abf6f1b7ac..42f574029d 100644
--- a/app/Notifications/Dto/PushoverMessage.php
+++ b/app/Notifications/Dto/PushoverMessage.php
@@ -2,8 +2,6 @@
namespace App\Notifications\Dto;
-use Illuminate\Support\Facades\Log;
-
class PushoverMessage
{
public function __construct(
@@ -43,8 +41,6 @@ class PushoverMessage
$payload['message'] .= "&nbsp;<a href='".$buttonUrl."'>".$text.'</a>';
}
- Log::info('Pushover message', $payload);
-
return $payload;
}
}
diff --git a/tests/Unit/Notifications/Dto/PushoverMessageTest.php b/tests/Unit/Notifications/Dto/PushoverMessageTest.php
new file mode 100644
index 0000000000..0e7a005f8a
--- /dev/null
+++ b/tests/Unit/Notifications/Dto/PushoverMessageTest.php
@@ -0,0 +1,27 @@
+<?php
+
+use App\Notifications\Dto\PushoverMessage;
+use Illuminate\Log\Events\MessageLogged;
+use Illuminate\Support\Facades\Log;
+use Tests\TestCase;
+
+uses(TestCase::class);
+
+it('builds the payload without writing to the log', function () {
+ $logged = [];
+ Log::listen(function (MessageLogged $event) use (&$logged) {
+ $logged[] = $event->message;
+ });
+
+ $payload = (new PushoverMessage(
+ title: 'Deployment failed',
+ message: 'Your deployment failed.',
+ buttons: [['text' => 'Open', 'url' => 'https://coolify.example.com/deployments/1']],
+ level: 'error',
+ ))->toPayload('app-token', 'user-key');
+
+ expect($payload)
+ ->token->toBe('app-token')
+ ->user->toBe('user-key')
+ ->and($logged)->toBeEmpty();
+});