An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(terminal): add WS heartbeat and fix proxy idle disconnects
Andras Bacsai9408620d5f47
diff --git a/config/constants.php b/config/constants.phpindex 7504b6ba86..f2f6946fba 100644--- a/config/constants.php+++ b/config/constants.php@@ -4,7 +4,7 @@ return ['coolify' => ['version' => '4.0.0','helper_version' => '1.0.13',- 'realtime_version' => '1.0.13',+ 'realtime_version' => '1.0.14','self_hosted' => env('SELF_HOSTED', true),'autoupdate' => env('AUTOUPDATE'),'base_config_path' => env('BASE_CONFIG_PATH', '/data/coolify'),diff --git a/docker-compose.prod.yml b/docker-compose.prod.ymlindex 901aeb8334..56c5b416b8 100644--- a/docker-compose.prod.yml+++ b/docker-compose.prod.yml@@ -60,7 +60,7 @@ services:retries: 10timeout: 2ssoketi:- image: '${REGISTRY_URL:-ghcr.io}/coollabsio/coolify-realtime:1.0.13'+ image: '${REGISTRY_URL:-ghcr.io}/coollabsio/coolify-realtime:1.0.14'ports:- "${SOKETI_PORT:-6001}:6001"- "6002:6002"diff --git a/docker-compose.windows.yml b/docker-compose.windows.ymlindex 998d35974b..e1c09c64c7 100644--- a/docker-compose.windows.yml+++ b/docker-compose.windows.yml@@ -96,7 +96,7 @@ services:retries: 10timeout: 2ssoketi:- image: 'ghcr.io/coollabsio/coolify-realtime:1.0.13'+ image: 'ghcr.io/coollabsio/coolify-realtime:1.0.14'pull_policy: alwayscontainer_name: coolify-realtimerestart: alwaysdiff --git a/docker/coolify-realtime/terminal-server.js b/docker/coolify-realtime/terminal-server.jsindex 3ae77857fc..470f4af1e3 100755--- a/docker/coolify-realtime/terminal-server.js+++ b/docker/coolify-realtime/terminal-server.js@@ -105,7 +105,12 @@ const verifyClient = async (info, callback) => {const wss = new WebSocketServer({ server, path: '/terminal/ws', verifyClient: verifyClient });+const HEARTBEAT_INTERVAL_MS = 30000;+wss.on('connection', async (ws, req) => {+ ws.isAlive = true;+ ws.on('pong', () => { ws.isAlive = true; });+const userId = generateUserId();const userSession = { ws, userId, ptyProcess: null, isActive: false, authorizedIPs: [] };const { xsrfToken, laravelSession, sessionCookieName } = getSessionCookie(req);@@ -167,6 +172,23 @@ wss.on('connection', async (ws, req) => {});});+const heartbeat = setInterval(() => {+ wss.clients.forEach((ws) => {+ if (ws.isAlive === false) {+ logTerminal('warn', 'Terminating WS due to missed protocol pong.');+ return ws.terminate();+ }+ ws.isAlive = false;+ try {+ ws.ping();+ } catch (_) {+ // ignore — close handler will follow+ }+ });+}, HEARTBEAT_INTERVAL_MS);++wss.on('close', () => clearInterval(heartbeat));+const messageHandlers = {message: (session, data) => session.ptyProcess.write(data),resize: (session, { cols, rows }) => {diff --git a/other/nightly/docker-compose.prod.yml b/other/nightly/docker-compose.prod.ymlindex 901aeb8334..56c5b416b8 100644--- a/other/nightly/docker-compose.prod.yml+++ b/other/nightly/docker-compose.prod.yml@@ -60,7 +60,7 @@ services:retries: 10timeout: 2ssoketi:- image: '${REGISTRY_URL:-ghcr.io}/coollabsio/coolify-realtime:1.0.13'+ image: '${REGISTRY_URL:-ghcr.io}/coollabsio/coolify-realtime:1.0.14'ports:- "${SOKETI_PORT:-6001}:6001"- "6002:6002"diff --git a/other/nightly/docker-compose.windows.yml b/other/nightly/docker-compose.windows.ymlindex 998d35974b..e1c09c64c7 100644--- a/other/nightly/docker-compose.windows.yml+++ b/other/nightly/docker-compose.windows.yml@@ -96,7 +96,7 @@ services:retries: 10timeout: 2ssoketi:- image: 'ghcr.io/coollabsio/coolify-realtime:1.0.13'+ image: 'ghcr.io/coollabsio/coolify-realtime:1.0.14'pull_policy: alwayscontainer_name: coolify-realtimerestart: alwaysdiff --git a/resources/js/terminal.js b/resources/js/terminal.jsindex aa5f373533..923d09d86f 100644--- a/resources/js/terminal.js+++ b/resources/js/terminal.js@@ -75,8 +75,6 @@ export function initializeTerminalComponent() {focusWhenReady();});- this.keepAliveInterval = setInterval(this.keepAlive.bind(this), 30000);-this.$watch('terminalActive', (active) => {if (!active && this.keepAliveInterval) {clearInterval(this.keepAliveInterval);@@ -150,8 +148,11 @@ export function initializeTerminalComponent() {},clearAllTimers() {- [this.keepAliveInterval, this.reconnectInterval, this.connectionTimeoutId, this.pingTimeoutId, this.resizeTimeout]- .forEach(timer => timer && clearInterval(timer));+ if (this.keepAliveInterval) {+ clearInterval(this.keepAliveInterval);+ }+ [this.reconnectInterval, this.connectionTimeoutId, this.pingTimeoutId, this.resizeTimeout]+ .forEach(timer => timer && clearTimeout(timer));this.keepAliveInterval = null;this.reconnectInterval = null;this.connectionTimeoutId = null;@@ -282,6 +283,13 @@ export function initializeTerminalComponent() {this.pendingCommand = null;}+ // (Re)start application-level keepalive on every successful connect.+ // Server-side WebSocket protocol pings are the primary heartbeat; this+ // adds a JSON-level ping in case the server-side is older or restarting.+ if (!this.keepAliveInterval) {+ this.keepAliveInterval = setInterval(this.keepAlive.bind(this), 30000);+ }+// Start ping timeout monitoringthis.resetPingTimeout();@@ -494,11 +502,6 @@ export function initializeTerminalComponent() {},keepAlive() {- // Skip keepalive when document is hidden to prevent unnecessary disconnects- if (!this.isDocumentVisible) {- return;- }-if (this.socket && this.socket.readyState === WebSocket.OPEN) {this.sendMessage({ ping: true });} else if (this.connectionState === 'disconnected') {@@ -524,10 +527,23 @@ export function initializeTerminalComponent() {logTerminal('log', '[Terminal] Tab visible, resuming connection management');if (this.wasConnectedBeforeHidden && this.socket && this.socket.readyState === WebSocket.OPEN) {- // Send immediate ping to verify connection is still alive+ // Connection may be half-open after Cloudflare/proxy idle drop while hidden.+ // Probe with a short timeout (5s) instead of the default 35s — force a+ // reconnect quickly if no pong arrives so the user is not stuck typing+ // into a dead socket.this.heartbeatMissed = 0;this.sendMessage({ ping: true });- this.resetPingTimeout();+ if (this.pingTimeoutId) {+ clearTimeout(this.pingTimeoutId);+ }+ this.pingTimeoutId = setTimeout(() => {+ logTerminal('warn', '[Terminal] Visibility-resume ping timed out, forcing reconnect.');+ try {+ this.socket.close(4000, 'Visibility-resume timeout');+ } catch (_) {+ // ignore — close handler will run on its own+ }+ }, 5000);} else if (this.wasConnectedBeforeHidden && this.connectionState !== 'connected') {// Was connected before but now disconnected - attempt reconnectionthis.reconnectAttempts = 0;diff --git a/tests/Feature/RealtimeTerminalPackagingTest.php b/tests/Feature/RealtimeTerminalPackagingTest.phpindex e8fa5ff76b..8f4da3a62d 100644--- a/tests/Feature/RealtimeTerminalPackagingTest.php+++ b/tests/Feature/RealtimeTerminalPackagingTest.php@@ -32,3 +32,28 @@ it('keeps realtime terminal server logging restricted to development environment->toContain('if (!terminalDebugEnabled) {')->not->toContain("console.log('Coolify realtime terminal server listening on port 6002. Let the hacking begin!');");});++it('configures a server-initiated WebSocket heartbeat to survive proxy idle timeouts', function () {+ $terminalServer = file_get_contents(base_path('docker/coolify-realtime/terminal-server.js'));++ expect($terminalServer)+ ->toContain('ws.isAlive = true;')+ ->toContain("ws.on('pong'")+ ->toContain('ws.ping();')+ ->toContain('ws.terminate();')+ ->toContain('HEARTBEAT_INTERVAL_MS');+});++it('removes the keepalive short-circuit that fired when the tab was hidden', function () {+ $terminalClient = file_get_contents(base_path('resources/js/terminal.js'));++ expect($terminalClient)+ ->not->toContain('// Skip keepalive when document is hidden to prevent unnecessary disconnects');+});++it('uses a fast probe timeout when the tab regains visibility', function () {+ $terminalClient = file_get_contents(base_path('resources/js/terminal.js'));++ expect($terminalClient)+ ->toContain("'Visibility-resume timeout'");+});