An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(api): block invalid destination types and service deletions
Andras Bacsai9665aa292c93
diff --git a/app/Http/Controllers/Api/DestinationsController.php b/app/Http/Controllers/Api/DestinationsController.phpindex 5db11624bd..8b54913e78 100644--- a/app/Http/Controllers/Api/DestinationsController.php+++ b/app/Http/Controllers/Api/DestinationsController.php@@ -6,6 +6,7 @@ use App\Http\Controllers\Controller;use App\Models\Server;use App\Models\StandaloneDocker;use App\Models\SwarmDocker;+use Illuminate\Http\JsonResponse;use Illuminate\Http\Request;use Illuminate\Support\Facades\Validator;@@ -28,7 +29,7 @@ class DestinationsController extends Controller/*** Resolve the calling token's team id, or return a 403 response.*/- private function teamIdOrAbort(): int|\Illuminate\Http\JsonResponse+ private function teamIdOrAbort(): int|JsonResponse{$teamId = getTeamIdFromToken();if (is_null($teamId)) {@@ -97,6 +98,12 @@ class DestinationsController extends Controllerif (! is_int($teamId)) {return $teamId;}++ $return = validateIncomingRequest($request);+ if ($return instanceof JsonResponse) {+ return $return;+ }+$server = Server::whereTeamId($teamId)->whereUuid($server_uuid)->firstOrFail();$allowed = ['name', 'network', 'type'];@@ -114,7 +121,12 @@ class DestinationsController extends Controllerreturn response()->json(['message' => 'Validation failed', 'errors' => $validator->errors()], 422);}- $type = $request->input('type', 'standalone');+ $expectedType = $server->isSwarm() ? 'swarm' : 'standalone';+ $type = $request->input('type', $expectedType);+ if ($type !== $expectedType) {+ return response()->json(['message' => "Destination type must be {$expectedType} for this server."], 422);+ }+$name = $request->input('name') ?: ($server->name.'-'.$request->input('network'));$class = $type === 'swarm' ? SwarmDocker::class : StandaloneDocker::class;diff --git a/app/Models/StandaloneDocker.php b/app/Models/StandaloneDocker.phpindex 1c5cfd3420..c1dd4bf67a 100644--- a/app/Models/StandaloneDocker.php+++ b/app/Models/StandaloneDocker.php@@ -144,6 +144,6 @@ class StandaloneDocker extends BaseModelpublic function attachedTo(){- return $this->applications?->count() > 0 || $this->databases()->count() > 0;+ return $this->applications()->exists() || $this->databases()->count() > 0 || $this->services()->exists();}}diff --git a/app/Models/SwarmDocker.php b/app/Models/SwarmDocker.phpindex 0e9620457b..02b8381d99 100644--- a/app/Models/SwarmDocker.php+++ b/app/Models/SwarmDocker.php@@ -124,6 +124,6 @@ class SwarmDocker extends BaseModelpublic function attachedTo(){- return $this->applications?->count() > 0 || $this->databases()->count() > 0;+ return $this->applications()->exists() || $this->databases()->count() > 0 || $this->services()->exists();}}diff --git a/tests/Feature/Api/DestinationsApiTest.php b/tests/Feature/Api/DestinationsApiTest.phpnew file mode 100644index 0000000000..cbbd6d0a68--- /dev/null+++ b/tests/Feature/Api/DestinationsApiTest.php@@ -0,0 +1,200 @@+<?php++use App\Models\InstanceSettings;+use App\Models\Project;+use App\Models\Server;+use App\Models\Service;+use App\Models\StandaloneDocker;+use App\Models\SwarmDocker;+use App\Models\Team;+use App\Models\User;+use Illuminate\Foundation\Testing\RefreshDatabase;+use Illuminate\Support\Str;++uses(RefreshDatabase::class);++beforeEach(function () {+ config([+ 'cache.default' => 'array',+ 'session.driver' => 'array',+ 'queue.default' => 'sync',+ 'app.maintenance.driver' => 'file',+ ]);++ InstanceSettings::unguarded(fn () => InstanceSettings::firstOrCreate(+ ['id' => 0],+ ['is_api_enabled' => true],+ ));++ $this->team = Team::factory()->create();+ $this->user = User::factory()->create();+ $this->team->members()->attach($this->user->id, ['role' => 'owner']);+ session(['currentTeam' => $this->team]);++ $this->bearerToken = destinationsApiToken($this->user, $this->team, ['*']);+ $this->server = Server::factory()->create(['team_id' => $this->team->id]);+ $this->destination = StandaloneDocker::where('server_id', $this->server->id)->first();+});++function destinationsApiHeaders(string $bearerToken): array+{+ return [+ 'Authorization' => 'Bearer '.$bearerToken,+ 'Content-Type' => 'application/json',+ ];+}++function destinationsApiToken(User $user, Team $team, array $abilities): string+{+ $plainTextToken = Str::random(40);+ $token = $user->tokens()->create([+ 'name' => 'destinations-api-test-'.Str::random(6),+ 'token' => hash('sha256', $plainTextToken),+ 'abilities' => $abilities,+ 'team_id' => $team->id,+ ]);++ return $token->getKey().'|'.$plainTextToken;+}++describe('GET /api/v1/destinations', function () {+ test('lists only destinations owned by the token team', function () {+ $otherTeam = Team::factory()->create();+ $otherServer = Server::factory()->create(['team_id' => $otherTeam->id]);+ $otherDestination = StandaloneDocker::where('server_id', $otherServer->id)->first();++ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->getJson('/api/v1/destinations');++ $response->assertOk();+ $uuids = collect($response->json())->pluck('uuid');++ expect($uuids)->toContain($this->destination->uuid)+ ->not->toContain($otherDestination->uuid);+ });+});++describe('GET /api/v1/destinations/{uuid}', function () {+ test('does not expose another team destination', function () {+ $otherTeam = Team::factory()->create();+ $otherServer = Server::factory()->create(['team_id' => $otherTeam->id]);+ $otherDestination = StandaloneDocker::where('server_id', $otherServer->id)->first();++ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->getJson("/api/v1/destinations/{$otherDestination->uuid}");++ $response->assertNotFound();+ });+});++describe('GET /api/v1/servers/{server_uuid}/destinations', function () {+ test('lists destinations for a team server', function () {+ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->getJson("/api/v1/servers/{$this->server->uuid}/destinations");++ $response->assertOk();+ expect($response->json())->toHaveCount(1)+ ->and($response->json('0.uuid'))->toBe($this->destination->uuid);+ });+});++describe('POST /api/v1/servers/{server_uuid}/destinations', function () {+ test('requires a write token', function () {+ $readOnlyToken = destinationsApiToken($this->user, $this->team, ['read']);++ $response = $this->withHeaders(destinationsApiHeaders($readOnlyToken))+ ->postJson("/api/v1/servers/{$this->server->uuid}/destinations", [+ 'network' => 'new-network',+ ]);++ $response->assertForbidden();+ });++ test('rejects non-json requests before creating a destination', function () {+ $response = $this->withHeaders([+ 'Authorization' => 'Bearer '.$this->bearerToken,+ ])->post("/api/v1/servers/{$this->server->uuid}/destinations", [+ 'network' => 'api-swarm-network',+ 'type' => 'swarm',+ ]);++ $response->assertStatus(400);+ expect(SwarmDocker::where('server_id', $this->server->id)->where('network', 'api-swarm-network')->exists())->toBeFalse();+ });++ test('rejects unknown fields', function () {+ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->postJson("/api/v1/servers/{$this->server->uuid}/destinations", [+ 'network' => 'new-network',+ 'unexpected' => 'value',+ ]);++ $response->assertStatus(422);+ $response->assertJsonPath('fields.0', 'unexpected');+ });++ test('rejects unsafe docker network names', function () {+ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->postJson("/api/v1/servers/{$this->server->uuid}/destinations", [+ 'network' => 'bad;network',+ ]);++ $response->assertStatus(422);+ $response->assertJsonValidationErrors(['network']);+ });++ test('rejects a destination type that does not match the server mode', function () {+ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->postJson("/api/v1/servers/{$this->server->uuid}/destinations", [+ 'network' => 'wrong-type-network',+ 'type' => 'swarm',+ ]);++ $response->assertStatus(422);+ expect(SwarmDocker::where('server_id', $this->server->id)->where('network', 'wrong-type-network')->exists())->toBeFalse();+ });++ test('creates a swarm destination on a swarm server', function () {+ $this->server->settings()->update(['is_swarm_manager' => true]);++ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->postJson("/api/v1/servers/{$this->server->uuid}/destinations", [+ 'name' => 'API Swarm',+ 'network' => 'api-swarm-network',+ 'type' => 'swarm',+ ]);++ $response->assertCreated();+ $response->assertJsonStructure(['uuid']);+ expect(SwarmDocker::where('server_id', $this->server->id)->where('network', 'api-swarm-network')->exists())->toBeTrue();+ });++ test('rejects duplicate networks on the same server and type', function () {+ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->postJson("/api/v1/servers/{$this->server->uuid}/destinations", [+ 'network' => $this->destination->network,+ ]);++ $response->assertStatus(409);+ });+});++describe('DELETE /api/v1/destinations/{uuid}', function () {+ test('blocks deleting a destination with an attached service', function () {+ $project = Project::factory()->create(['team_id' => $this->team->id]);+ $environment = $project->environments()->first();++ Service::factory()->create([+ 'environment_id' => $environment->id,+ 'server_id' => $this->server->id,+ 'destination_id' => $this->destination->id,+ 'destination_type' => $this->destination->getMorphClass(),+ ]);++ $response = $this->withHeaders(destinationsApiHeaders($this->bearerToken))+ ->deleteJson("/api/v1/destinations/{$this->destination->uuid}");++ $response->assertStatus(409);+ $this->assertModelExists($this->destination);+ });+});