An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
Improve storage mount path handling
Andras Bacsaia06c1a7bf5e3
diff --git a/app/Http/Controllers/Api/ApplicationsController.php b/app/Http/Controllers/Api/ApplicationsController.phpindex bdb6f8d90a..9570026c1b 100644--- a/app/Http/Controllers/Api/ApplicationsController.php+++ b/app/Http/Controllers/Api/ApplicationsController.php@@ -4279,10 +4279,11 @@ class ApplicationsController extends Controller'host_path' => ['string', 'nullable', 'regex:'.ValidationPatterns::DIRECTORY_PATH_PATTERN],'content' => 'string|nullable','is_directory' => 'boolean',+ 'is_host_file' => 'boolean','fs_path' => 'string',]);- $allAllowedFields = ['type', 'name', 'mount_path', 'host_path', 'content', 'is_directory', 'fs_path'];+ $allAllowedFields = ['type', 'name', 'mount_path', 'host_path', 'content', 'is_directory', 'is_host_file', 'fs_path'];$extraFields = array_diff(array_keys($request->all()), $allAllowedFields);if ($validator->fails() || ! empty($extraFields)) {$errors = $validator->errors();@@ -4306,7 +4307,7 @@ class ApplicationsController extends Controller], 422);}- $typeSpecificInvalidFields = array_intersect(['content', 'is_directory', 'fs_path'], array_keys($request->all()));+ $typeSpecificInvalidFields = array_intersect(['content', 'is_directory', 'is_host_file', 'fs_path'], array_keys($request->all()));if (! empty($typeSpecificInvalidFields)) {return response()->json(['message' => 'Validation failed.',@@ -4337,6 +4338,14 @@ class ApplicationsController extends Controller}$isDirectory = $request->boolean('is_directory', false);+ $isHostFile = $request->boolean('is_host_file', false);++ if ($isDirectory && $isHostFile) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['is_host_file' => 'Host file mounts cannot also be directory mounts.'],+ ], 422);+ }if ($isDirectory) {if (! $request->fs_path) {@@ -4359,12 +4368,50 @@ class ApplicationsController extends Controller'resource_id' => $application->id,'resource_type' => get_class($application),]);- } else {- $mountPath = str($request->mount_path)->trim()->start('/')->value();+ } elseif ($isHostFile) {+ if (! $request->fs_path) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['fs_path' => 'The fs_path field is required for host file mounts.'],+ ], 422);+ }- validateShellSafePath($mountPath, 'file storage path');+ if ($request->filled('content')) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['content' => 'Content is not valid for host file mounts.'],+ ], 422);+ }- $fsPath = application_configuration_dir().'/'.$application->uuid.$mountPath;+ try {+ $fsPath = validateHostFileMountPath($request->fs_path, 'host file source path');+ $mountPath = validateFileMountPath($request->mount_path, 'host file destination path');+ } catch (\Throwable $e) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['mount_path' => $e->getMessage()],+ ], 422);+ }++ $storage = LocalFileVolume::create([+ 'fs_path' => $fsPath,+ 'mount_path' => $mountPath,+ 'content' => null,+ 'is_directory' => false,+ 'is_host_file' => true,+ 'resource_id' => $application->id,+ 'resource_type' => get_class($application),+ ]);+ } else {+ try {+ $mountPath = validateFileMountPath($request->mount_path, 'file storage path');+ $fsPath = confineFileMountPath(application_configuration_dir().'/'.$application->uuid, $mountPath, 'file storage path');+ } catch (\Throwable $e) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['mount_path' => $e->getMessage()],+ ], 422);+ }$storage = LocalFileVolume::create(['fs_path' => $fsPath,diff --git a/app/Http/Controllers/Api/DatabasesController.php b/app/Http/Controllers/Api/DatabasesController.phpindex 9a463e8d3d..912f817286 100644--- a/app/Http/Controllers/Api/DatabasesController.php+++ b/app/Http/Controllers/Api/DatabasesController.php@@ -3696,10 +3696,11 @@ class DatabasesController extends Controller'host_path' => ['string', 'nullable', 'regex:'.ValidationPatterns::DIRECTORY_PATH_PATTERN],'content' => 'string|nullable','is_directory' => 'boolean',+ 'is_host_file' => 'boolean','fs_path' => 'string',]);- $allAllowedFields = ['type', 'name', 'mount_path', 'host_path', 'content', 'is_directory', 'fs_path'];+ $allAllowedFields = ['type', 'name', 'mount_path', 'host_path', 'content', 'is_directory', 'is_host_file', 'fs_path'];$extraFields = array_diff(array_keys($request->all()), $allAllowedFields);if ($validator->fails() || ! empty($extraFields)) {$errors = $validator->errors();@@ -3723,7 +3724,7 @@ class DatabasesController extends Controller], 422);}- $typeSpecificInvalidFields = array_intersect(['content', 'is_directory', 'fs_path'], array_keys($request->all()));+ $typeSpecificInvalidFields = array_intersect(['content', 'is_directory', 'is_host_file', 'fs_path'], array_keys($request->all()));if (! empty($typeSpecificInvalidFields)) {return response()->json(['message' => 'Validation failed.',@@ -3754,6 +3755,14 @@ class DatabasesController extends Controller}$isDirectory = $request->boolean('is_directory', false);+ $isHostFile = $request->boolean('is_host_file', false);++ if ($isDirectory && $isHostFile) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['is_host_file' => 'Host file mounts cannot also be directory mounts.'],+ ], 422);+ }if ($isDirectory) {if (! $request->fs_path) {@@ -3776,12 +3785,50 @@ class DatabasesController extends Controller'resource_id' => $database->id,'resource_type' => get_class($database),]);- } else {- $mountPath = str($request->mount_path)->trim()->start('/')->value();+ } elseif ($isHostFile) {+ if (! $request->fs_path) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['fs_path' => 'The fs_path field is required for host file mounts.'],+ ], 422);+ }- validateShellSafePath($mountPath, 'file storage path');+ if ($request->filled('content')) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['content' => 'Content is not valid for host file mounts.'],+ ], 422);+ }- $fsPath = database_configuration_dir().'/'.$database->uuid.$mountPath;+ try {+ $fsPath = validateHostFileMountPath($request->fs_path, 'host file source path');+ $mountPath = validateFileMountPath($request->mount_path, 'host file destination path');+ } catch (\Throwable $e) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['mount_path' => $e->getMessage()],+ ], 422);+ }++ $storage = LocalFileVolume::create([+ 'fs_path' => $fsPath,+ 'mount_path' => $mountPath,+ 'content' => null,+ 'is_directory' => false,+ 'is_host_file' => true,+ 'resource_id' => $database->id,+ 'resource_type' => get_class($database),+ ]);+ } else {+ try {+ $mountPath = validateFileMountPath($request->mount_path, 'file storage path');+ $fsPath = confineFileMountPath(database_configuration_dir().'/'.$database->uuid, $mountPath, 'file storage path');+ } catch (\Throwable $e) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['mount_path' => $e->getMessage()],+ ], 422);+ }$storage = LocalFileVolume::create(['fs_path' => $fsPath,diff --git a/app/Http/Controllers/Api/ServicesController.php b/app/Http/Controllers/Api/ServicesController.phpindex 32137b8666..6c121bcf87 100644--- a/app/Http/Controllers/Api/ServicesController.php+++ b/app/Http/Controllers/Api/ServicesController.php@@ -2115,10 +2115,11 @@ class ServicesController extends Controller'host_path' => ['string', 'nullable', 'regex:'.ValidationPatterns::DIRECTORY_PATH_PATTERN],'content' => 'string|nullable','is_directory' => 'boolean',+ 'is_host_file' => 'boolean','fs_path' => 'string',]);- $allAllowedFields = ['type', 'resource_uuid', 'name', 'mount_path', 'host_path', 'content', 'is_directory', 'fs_path'];+ $allAllowedFields = ['type', 'resource_uuid', 'name', 'mount_path', 'host_path', 'content', 'is_directory', 'is_host_file', 'fs_path'];$extraFields = array_diff(array_keys($request->all()), $allAllowedFields);if ($validator->fails() || ! empty($extraFields)) {$errors = $validator->errors();@@ -2150,7 +2151,7 @@ class ServicesController extends Controller], 422);}- $typeSpecificInvalidFields = array_intersect(['content', 'is_directory', 'fs_path'], array_keys($request->all()));+ $typeSpecificInvalidFields = array_intersect(['content', 'is_directory', 'is_host_file', 'fs_path'], array_keys($request->all()));if (! empty($typeSpecificInvalidFields)) {return response()->json(['message' => 'Validation failed.',@@ -2181,6 +2182,14 @@ class ServicesController extends Controller}$isDirectory = $request->boolean('is_directory', false);+ $isHostFile = $request->boolean('is_host_file', false);++ if ($isDirectory && $isHostFile) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['is_host_file' => 'Host file mounts cannot also be directory mounts.'],+ ], 422);+ }if ($isDirectory) {if (! $request->fs_path) {@@ -2203,12 +2212,50 @@ class ServicesController extends Controller'resource_id' => $subResource->id,'resource_type' => get_class($subResource),]);- } else {- $mountPath = str($request->mount_path)->trim()->start('/')->value();+ } elseif ($isHostFile) {+ if (! $request->fs_path) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['fs_path' => 'The fs_path field is required for host file mounts.'],+ ], 422);+ }- validateShellSafePath($mountPath, 'file storage path');+ if ($request->filled('content')) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['content' => 'Content is not valid for host file mounts.'],+ ], 422);+ }- $fsPath = service_configuration_dir().'/'.$service->uuid.$mountPath;+ try {+ $fsPath = validateHostFileMountPath($request->fs_path, 'host file source path');+ $mountPath = validateFileMountPath($request->mount_path, 'host file destination path');+ } catch (\Throwable $e) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['mount_path' => $e->getMessage()],+ ], 422);+ }++ $storage = LocalFileVolume::create([+ 'fs_path' => $fsPath,+ 'mount_path' => $mountPath,+ 'content' => null,+ 'is_directory' => false,+ 'is_host_file' => true,+ 'resource_id' => $subResource->id,+ 'resource_type' => get_class($subResource),+ ]);+ } else {+ try {+ $mountPath = validateFileMountPath($request->mount_path, 'file storage path');+ $fsPath = confineFileMountPath(service_configuration_dir().'/'.$service->uuid, $mountPath, 'file storage path');+ } catch (\Throwable $e) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => ['mount_path' => $e->getMessage()],+ ], 422);+ }$storage = LocalFileVolume::create(['fs_path' => $fsPath,diff --git a/app/Jobs/ApplicationDeploymentJob.php b/app/Jobs/ApplicationDeploymentJob.phpindex b7283550c8..545735cf66 100644--- a/app/Jobs/ApplicationDeploymentJob.php+++ b/app/Jobs/ApplicationDeploymentJob.php@@ -1031,7 +1031,7 @@ class ApplicationDeploymentJob implements ShouldBeEncrypted, ShouldQueue);}foreach ($this->application->fileStorages as $fileStorage) {- if (! $fileStorage->is_based_on_git && ! $fileStorage->is_directory) {+ if (! $fileStorage->is_host_file && ! $fileStorage->is_based_on_git && ! $fileStorage->is_directory) {$fileStorage->saveStorageOnServer();}}diff --git a/app/Livewire/Project/Service/FileStorage.php b/app/Livewire/Project/Service/FileStorage.phpindex 877142d8bd..e869ca91bd 100644--- a/app/Livewire/Project/Service/FileStorage.php+++ b/app/Livewire/Project/Service/FileStorage.php@@ -94,6 +94,10 @@ class FileStorage extends Componenttry {$this->authorize('update', $this->resource);+ if ($this->fileStorage->is_host_file) {+ throw new \Exception('Host file mounts are bind-only and cannot be converted.');+ }+$this->fileStorage->deleteStorageOnServer();$this->fileStorage->is_directory = true;$this->fileStorage->content = null;@@ -112,6 +116,10 @@ class FileStorage extends Componenttry {$this->authorize('update', $this->resource);+ if ($this->fileStorage->is_host_file) {+ throw new \Exception('Host file mounts are bind-only and cannot be loaded from the server.');+ }+$this->fileStorage->loadStorageOnServer();$this->syncData();$this->dispatch('success', 'File storage loaded from server.');@@ -127,6 +135,10 @@ class FileStorage extends Componenttry {$this->authorize('update', $this->resource);+ if ($this->fileStorage->is_host_file) {+ throw new \Exception('Host file mounts are bind-only and cannot be converted.');+ }+$this->fileStorage->deleteStorageOnServer();$this->fileStorage->is_directory = false;$this->fileStorage->content = null;@@ -154,8 +166,10 @@ class FileStorage extends Component$message = 'File deleted.';if ($this->fileStorage->is_directory) {$message = 'Directory deleted.';+ } elseif ($this->fileStorage->is_host_file) {+ $message = 'Host file mount removed.';}- if ($this->permanently_delete) {+ if ($this->permanently_delete && ! $this->fileStorage->is_host_file) {$message = 'Directory deleted from the server.';$this->fileStorage->deleteStorageOnServer();}@@ -174,6 +188,12 @@ class FileStorage extends Component{$this->authorize('update', $this->resource);+ if ($this->fileStorage->is_host_file) {+ $this->dispatch('error', 'Host file mounts are bind-only and cannot be edited from the UI.');++ return;+ }+if ($this->fileStorage->is_too_large) {$this->dispatch('error', 'File on server is too large to edit from the UI.');@@ -205,6 +225,12 @@ class FileStorage extends Componentpublic function instantSave(): void{$this->authorize('update', $this->resource);+ if ($this->fileStorage->is_host_file) {+ $this->dispatch('error', 'Host file mounts are bind-only and cannot be edited from the UI.');++ return;+ }+if ($this->fileStorage->is_too_large) {$this->dispatch('error', 'File on server is too large to edit from the UI.');@@ -223,6 +249,9 @@ class FileStorage extends Component'fileDeletionCheckboxes' => [['id' => 'permanently_delete', 'label' => 'The selected file will be permanently deleted form the server.'],],+ 'hostFileDeletionCheckboxes' => [+ ['id' => 'permanently_delete', 'label' => 'Only the mount configuration will be removed. The host file will not be deleted.'],+ ],]);}}diff --git a/app/Livewire/Project/Service/Storage.php b/app/Livewire/Project/Service/Storage.phpindex 30655691a9..9b097f2e18 100644--- a/app/Livewire/Project/Service/Storage.php+++ b/app/Livewire/Project/Service/Storage.php@@ -29,6 +29,10 @@ class Storage extends Componentpublic ?string $file_storage_content = null;+ public string $host_file_storage_source = '';++ public string $host_file_storage_destination = '';+public string $file_storage_directory_source = '';public string $file_storage_directory_destination = '';@@ -146,19 +150,9 @@ class Storage extends Component'file_storage_content' => 'nullable|string',]);- $this->file_storage_path = trim($this->file_storage_path);- $this->file_storage_path = str($this->file_storage_path)->start('/')->value();-- // Validate path to prevent command injection- validateShellSafePath($this->file_storage_path, 'file storage path');+ $this->file_storage_path = validateFileMountPath($this->file_storage_path, 'file storage path');- if ($this->resource->getMorphClass() === Application::class) {- $fs_path = application_configuration_dir().'/'.$this->resource->uuid.$this->file_storage_path;- } elseif (str($this->resource->getMorphClass())->contains('Standalone')) {- $fs_path = database_configuration_dir().'/'.$this->resource->uuid.$this->file_storage_path;- } else {- throw new \Exception('No valid resource type for file mount storage type!');- }+ $fs_path = confineFileMountPath($this->fileStorageHostPath(), $this->file_storage_path, 'file storage path');LocalFileVolume::create(['fs_path' => $fs_path,@@ -178,6 +172,38 @@ class Storage extends Component}}+ public function submitHostFileStorage()+ {+ try {+ $this->authorize('update', $this->resource);++ $this->validate([+ 'host_file_storage_source' => 'required|string',+ 'host_file_storage_destination' => 'required|string',+ ]);++ $this->host_file_storage_source = validateHostFileMountPath($this->host_file_storage_source, 'host file source path');+ $this->host_file_storage_destination = validateFileMountPath($this->host_file_storage_destination, 'host file destination path');++ LocalFileVolume::create([+ 'fs_path' => $this->host_file_storage_source,+ 'mount_path' => $this->host_file_storage_destination,+ 'content' => null,+ 'is_directory' => false,+ 'is_host_file' => true,+ 'resource_id' => $this->resource->id,+ 'resource_type' => get_class($this->resource),+ ]);++ $this->dispatch('success', 'Host file mount added successfully');+ $this->dispatch('closeStorageModal', 'host-file');+ $this->clearForm();+ $this->refreshStorages();+ } catch (\Throwable $e) {+ return handleError($e, $this);+ }+ }+public function submitFileStorageDirectory(){try {@@ -222,6 +248,8 @@ class Storage extends Component$this->file_storage_path = '';$this->file_storage_content = null;$this->file_storage_directory_destination = '';+ $this->host_file_storage_source = '';+ $this->host_file_storage_destination = '';if (str($this->resource->getMorphClass())->contains('Standalone')) {$this->file_storage_directory_source = database_configuration_dir()."/{$this->resource->uuid}";@@ -230,6 +258,34 @@ class Storage extends Component}}+ public function fileStorageHostPath(): string+ {+ if (method_exists($this->resource, 'workdir')) {+ return $this->resource->workdir();+ }++ if ($this->resource->getMorphClass() === Application::class) {+ return application_configuration_dir().'/'.$this->resource->uuid;+ }++ if (str($this->resource->getMorphClass())->contains('Standalone')) {+ return database_configuration_dir().'/'.$this->resource->uuid;+ }++ throw new \Exception('No valid resource type for file mount storage type!');+ }++ public function fileStoragePreviewPath(): string+ {+ $path = str($this->file_storage_path)->trim();++ if ($path->isEmpty()) {+ return $this->fileStorageHostPath().'/';+ }++ return $this->fileStorageHostPath().$path->start('/')->value();+ }+public function render(){return view('livewire.project.service.storage');diff --git a/app/Models/LocalFileVolume.php b/app/Models/LocalFileVolume.phpindex 6277502321..b521ede3d6 100644--- a/app/Models/LocalFileVolume.php+++ b/app/Models/LocalFileVolume.php@@ -21,6 +21,7 @@ class LocalFileVolume extends BaseModel// 'mount_path' => 'encrypted','content' => 'encrypted','is_directory' => 'boolean',+ 'is_host_file' => 'boolean','is_preview_suffix_enabled' => 'boolean',];@@ -33,6 +34,7 @@ class LocalFileVolume extends BaseModel'resource_type','resource_id','is_directory',+ 'is_host_file','chown','chmod','is_based_on_git',@@ -44,6 +46,10 @@ class LocalFileVolume extends BaseModelprotected static function booted(){static::created(function (LocalFileVolume $fileVolume) {+ if ($fileVolume->is_host_file) {+ return;+ }+$fileVolume->load(['service']);dispatch(new ServerStorageSaveJob($fileVolume));});@@ -70,6 +76,10 @@ class LocalFileVolume extends BaseModelpublic function loadStorageOnServer(){+ if ($this->is_host_file) {+ return;+ }+$this->load(['service']);$isService = data_get($this->resource, 'service');if ($isService) {@@ -124,6 +134,10 @@ class LocalFileVolume extends BaseModelpublic function deleteStorageOnServer(){+ if ($this->is_host_file) {+ return;+ }+$this->load(['service']);$isService = data_get($this->resource, 'service');if ($isService) {@@ -161,6 +175,10 @@ class LocalFileVolume extends BaseModelpublic function saveStorageOnServer(){+ if ($this->is_host_file) {+ return;+ }+$this->load(['service']);$isService = data_get($this->resource, 'service');if ($isService) {@@ -171,26 +189,26 @@ class LocalFileVolume extends BaseModel$server = $this->resource->destination->server;}$commands = collect([]);-- // Validate fs_path early before any shell interpolation- validateShellSafePath($this->fs_path, 'storage path');- $escapedFsPath = escapeshellarg($this->fs_path);$escapedWorkdir = escapeshellarg($workdir);if ($this->is_directory) {+ // Validate fs_path early before any shell interpolation+ validateShellSafePath($this->fs_path, 'storage path');+ $escapedFsPath = escapeshellarg($this->fs_path);$commands->push("mkdir -p {$escapedFsPath} > /dev/null 2>&1 || true");$commands->push("mkdir -p {$escapedWorkdir} > /dev/null 2>&1 || true");$commands->push("cd {$escapedWorkdir}");}- if (str($this->fs_path)->startsWith('.') || str($this->fs_path)->startsWith('/') || str($this->fs_path)->startsWith('~')) {- $parent_dir = str($this->fs_path)->beforeLast('/');+ $path = data_get_str($this, 'fs_path');+ $content = data_get($this, 'content');+ $pathForParentDirectory = str($this->fs_path);+ if ($pathForParentDirectory->startsWith('.') || $pathForParentDirectory->startsWith('/') || $pathForParentDirectory->startsWith('~')) {+ $parent_dir = $pathForParentDirectory->beforeLast('/');if ($parent_dir != '') {$escapedParentDir = escapeshellarg($parent_dir);$commands->push("mkdir -p {$escapedParentDir} > /dev/null 2>&1 || true");}}- $path = data_get_str($this, 'fs_path');- $content = data_get($this, 'content');if ($path->startsWith('.')) {$path = $path->after('.');$path = $workdir.$path;diff --git a/bootstrap/helpers/shared.php b/bootstrap/helpers/shared.phpindex 7b113e7b81..ab47c067a2 100644--- a/bootstrap/helpers/shared.php+++ b/bootstrap/helpers/shared.php@@ -166,7 +166,7 @@ function validateShellSafePath(string $input, string $context = 'path'): string/*** Validate that a filename is safe for use as a plain file name (no path components).*- * Prevents path traversal attacks by rejecting directory separators, traversal+ * Prevents unsafe parent directory paths by rejecting directory separators, parent directory* sequences, and null bytes, in addition to all shell metacharacters blocked by* validateShellSafePath(). Intended for user-supplied filenames such as PostgreSQL* init script names that are later written to a specific directory on the host.@@ -175,7 +175,7 @@ function validateShellSafePath(string $input, string $context = 'path'): string* @param string $context Descriptive name for error messages (e.g., 'init script filename')* @return string The validated input (unchanged if valid)*- * @throws Exception If dangerous characters or path traversal sequences are detected+ * @throws Exception If dangerous characters or parent directory sequences are detected*/function validateFilenameSafe(string $input, string $context = 'filename'): string{@@ -198,10 +198,10 @@ function validateFilenameSafe(string $input, string $context = 'filename'): stri);}- // Reject path traversal sequences (catches encoded or unusual forms)+ // Reject parent directory sequences (catches encoded or unusual forms)if (str_contains($input, '..')) {throw new Exception(- "Invalid {$context}: path traversal sequence ('..') is not allowed."+ "Invalid {$context}: parent directory sequence ('..') is not allowed.");}@@ -230,6 +230,197 @@ function validateFilenameSafe(string $input, string $context = 'filename'): strireturn $input;}+/**+ * Validate and normalize a user supplied file mount path.+ *+ * File mount paths are container paths supplied by tenants. They may look like+ * absolute paths (for example /etc/nginx/nginx.conf), but are later joined to a+ * Coolify-managed configuration directory on the host. Therefore shell safety is+ * not enough: every path segment must also be unable to traverse out of that+ * managed directory.+ *+ * @throws Exception+ */+function validateFileMountPath(string $input, string $context = 'file mount path'): string+{+ validateShellSafePath($input, $context);++ if (str_contains($input, "\0")) {+ throw new Exception(+ "Invalid {$context}: contains null byte. ".+ 'Null bytes are not allowed in file mount paths for security reasons.'+ );+ }++ if (str_contains($input, '\\')) {+ throw new Exception(+ "Invalid {$context}: backslash directory separators are not allowed."+ );+ }++ $path = str($input)->trim()->start('/')->replaceMatches('#/+#', '/')->value();++ foreach (explode('/', trim($path, '/')) as $segment) {+ if ($segment === '' || ($segment !== '.' && $segment !== '..')) {+ continue;+ }++ throw new Exception(+ "Invalid {$context}: relative path segments ('.' or '..') are not allowed."+ );+ }++ return $path;+}++/**+ * Validate a host file path used as a bind-only source.+ *+ * Unlike managed file mounts, this path is not re-based under the Coolify+ * configuration directory and must never be written by Coolify. It still needs+ * to be shell-safe because other storage code may pass paths through remote+ * shell commands.+ *+ * @throws Exception+ */+function validateHostFileMountPath(string $input, string $context = 'host file path'): string+{+ validateShellSafePath($input, $context);++ if (str_contains($input, "\0")) {+ throw new Exception("Invalid {$context}: contains null byte.");+ }++ if (str_contains($input, '\\')) {+ throw new Exception("Invalid {$context}: backslash directory separators are not allowed.");+ }++ $path = str($input)->trim()->replaceMatches('#/+#', '/')->value();++ if ($path === '' || ! str_starts_with($path, '/')) {+ throw new Exception("Invalid {$context}: must be an absolute path.");+ }++ if ($path === '/' || str_ends_with($path, '/')) {+ throw new Exception("Invalid {$context}: must point to a file, not a directory.");+ }++ foreach (explode('/', trim($path, '/')) as $segment) {+ if ($segment === '' || ($segment !== '.' && $segment !== '..')) {+ continue;+ }++ throw new Exception("Invalid {$context}: relative path segments ('.' or '..') are not allowed.");+ }++ return normalizeUnixPath($path);+}++/**+ * Resolve a tenant file mount path under a Coolify-managed base directory.+ *+ * This performs lexical normalization only; the target file does not need to+ * exist yet. The normalized result must remain inside the given base directory.+ *+ * @throws Exception+ */+function confineFileMountPath(string $baseDirectory, string $path, string $context = 'file mount path'): string+{+ $baseDirectory = normalizeUnixPath($baseDirectory);+ $mountPath = validateFileMountPath($path, $context);+ $resolvedPath = normalizeUnixPath($baseDirectory.'/'.$mountPath);++ if ($resolvedPath !== $baseDirectory && ! str_starts_with($resolvedPath, $baseDirectory.'/')) {+ throw new Exception(+ "Invalid {$context}: resolved path must stay inside the resource configuration directory."+ );+ }++ return $resolvedPath;+}++/**+ * Normalize an existing host path and assert it remains inside a base directory.+ *+ * Dot-relative paths are resolved against the base directory for legacy+ * LocalFileVolume rows. Absolute paths must already point inside the base.+ *+ * @throws Exception+ */+function confinePathToBase(string $baseDirectory, string $path, string $context = 'path'): string+{+ $baseDirectory = normalizeUnixPath($baseDirectory);+ $path = trim($path);++ if (str_starts_with($path, '.')) {+ $path = $baseDirectory.'/'.str($path)->after('.')->value();+ } elseif (! str_starts_with($path, '/')) {+ $path = $baseDirectory.'/'.$path;+ }++ $resolvedPath = normalizeUnixPath($path);++ if ($resolvedPath !== $baseDirectory && ! str_starts_with($resolvedPath, $baseDirectory.'/')) {+ throw new Exception(+ "Invalid {$context}: resolved path must stay inside the resource configuration directory."+ );+ }++ return $resolvedPath;+}++/**+ * Normalize a Unix path lexically without consulting the remote filesystem.+ *+ * @throws Exception+ */+function normalizeUnixPath(string $path): string+{+ validateShellSafePath($path, 'path');++ if (str_contains($path, "\0")) {+ throw new Exception('Invalid path: contains null byte.');+ }++ if (str_contains($path, '\\')) {+ throw new Exception('Invalid path: backslash directory separators are not allowed.');+ }++ $isAbsolute = str_starts_with($path, '/');+ $segments = [];++ foreach (explode('/', $path) as $segment) {+ if ($segment === '' || $segment === '.') {+ continue;+ }++ if ($segment === '..') {+ if ($segments === [] || end($segments) === '..') {+ if ($isAbsolute) {+ throw new Exception('Invalid path: resolved path escapes the base directory.');+ }+ $segments[] = $segment;++ continue;+ }++ array_pop($segments);++ continue;+ }++ $segments[] = $segment;+ }++ $normalized = implode('/', $segments);++ if ($isAbsolute) {+ return $normalized === '' ? '/' : '/'.$normalized;+ }++ return $normalized === '' ? '.' : $normalized;+}+/*** Validate that a databases_to_backup input string is safe from command injection.*@@ -3819,7 +4010,7 @@ function formatBytes(?int $bytes, int $precision = 2): string/*** Validates that a file path is safely within the /tmp/ directory.- * Protects against path traversal attacks by resolving the real path+ * Protects against unsafe parent directory paths by resolving the real path* and verifying it stays within /tmp/.** Note: On macOS, /tmp is often a symlink to /private/tmp, which is handled.diff --git a/database/migrations/2026_07_02_112425_add_is_host_file_to_local_file_volumes_table.php b/database/migrations/2026_07_02_112425_add_is_host_file_to_local_file_volumes_table.phpnew file mode 100644index 0000000000..6de618632d--- /dev/null+++ b/database/migrations/2026_07_02_112425_add_is_host_file_to_local_file_volumes_table.php@@ -0,0 +1,36 @@+<?php++use Illuminate\Database\Migrations\Migration;+use Illuminate\Database\Schema\Blueprint;+use Illuminate\Support\Facades\Schema;++return new class extends Migration+{+ /**+ * Run the migrations.+ */+ public function up(): void+ {+ if (Schema::hasColumn('local_file_volumes', 'is_host_file')) {+ return;+ }++ Schema::table('local_file_volumes', function (Blueprint $table) {+ $table->boolean('is_host_file')->default(false)->after('is_directory');+ });+ }++ /**+ * Reverse the migrations.+ */+ public function down(): void+ {+ if (! Schema::hasColumn('local_file_volumes', 'is_host_file')) {+ return;+ }++ Schema::table('local_file_volumes', function (Blueprint $table) {+ $table->dropColumn('is_host_file');+ });+ }+};diff --git a/database/schema/testing-schema.sql b/database/schema/testing-schema.sqlindex edbc35db45..61c9b8e417 100644--- a/database/schema/testing-schema.sql+++ b/database/schema/testing-schema.sql@@ -433,6 +433,7 @@ CREATE TABLE IF NOT EXISTS "local_file_volumes" ("created_at" TEXT,"updated_at" TEXT,"is_directory" INTEGER DEFAULT false NOT NULL,+ "is_host_file" INTEGER DEFAULT false NOT NULL,"chown" TEXT,"chmod" TEXT,"is_based_on_git" INTEGER DEFAULT false NOT NULLdiff --git a/resources/views/livewire/project/service/file-storage.blade.php b/resources/views/livewire/project/service/file-storage.blade.phpindex 2a14d93505..e47d290b88 100644--- a/resources/views/livewire/project/service/file-storage.blade.php+++ b/resources/views/livewire/project/service/file-storage.blade.php@@ -4,6 +4,10 @@<div class="w-full p-2 text-sm rounded bg-warning/10 text-warning">File on server exceeds 5 MB and cannot be edited from the UI. Edit it directly on the server.</div>+ @elseif ($fileStorage->is_host_file)+ <div class="w-full p-2 text-sm rounded bg-warning/10 text-warning">+ This host file mount is bind-only. Coolify will not create, edit, load, chmod, or delete the source file.+ </div>@elseif ($isReadOnly)<div class="w-full p-2 text-sm rounded bg-warning/10 text-warning">@if ($fileStorage->is_directory)@@ -32,7 +36,14 @@@if (!$isReadOnly)@can('update', $resource)<div class="flex gap-2">- @if ($fileStorage->is_directory)+ @if ($fileStorage->is_host_file)+ <x-modal-confirmation :ignoreWire="false" title="Confirm Host File Mount Removal?"+ buttonTitle="Delete" isErrorButton submitAction="delete" :checkboxes="$hostFileDeletionCheckboxes"+ :actions="['Only the mount configuration will be removed. The host file will not be deleted.']"+ confirmationText="{{ $fs_path }}"+ confirmationLabel="Please confirm the execution of the actions by entering the Filepath below"+ shortConfirmationLabel="Filepath" />+ @elseif ($fileStorage->is_directory)<x-modal-confirmation :ignoreWire="false" title="Confirm Directory Conversion to File?"buttonTitle="Convert to file" submitAction="convertToFile" :actions="['All files in this directory will be permanently deleted and an empty file will be created in its place.',@@ -68,7 +79,7 @@@endif</div>@endcan- @if (!$fileStorage->is_directory)+ @if (!$fileStorage->is_directory && !$fileStorage->is_host_file)@can('update', $resource)@if (data_get($resource, 'settings.is_preserve_repository_enabled'))<div class="w-full sm:w-96">@@ -99,7 +110,7 @@@endif@else{{-- Read-only view --}}- @if (!$fileStorage->is_directory)+ @if (!$fileStorage->is_directory && !$fileStorage->is_host_file)@can('update', $resource)<div class="flex gap-2"><x-forms.button type="button" wire:click="loadStorageOnServer">Load fromdiff --git a/resources/views/livewire/project/service/storage.blade.php b/resources/views/livewire/project/service/storage.blade.phpindex 9e32cd22da..2f59718422 100644--- a/resources/views/livewire/project/service/storage.blade.php+++ b/resources/views/livewire/project/service/storage.blade.php@@ -22,11 +22,13 @@dropdownOpen: false,volumeModalOpen: false,fileModalOpen: false,+ hostFileModalOpen: false,directoryModalOpen: false}"@close-storage-modal.window="if ($event.detail === 'volume') volumeModalOpen = false;if ($event.detail === 'file') fileModalOpen = false;+ if ($event.detail === 'host-file') hostFileModalOpen = false;if ($event.detail === 'directory') directoryModalOpen = false;"><div class="relative" @click.outside="dropdownOpen = false">@@ -62,6 +64,15 @@</svg>File Mount</a>+ <a class="dropdown-item"+ @click="hostFileModalOpen = true; dropdownOpen = false">+ <svg class="size-4" fill="none" stroke="currentColor"+ viewBox="0 0 24 24">+ <path stroke-linecap="round" stroke-linejoin="round" stroke-width="2"+ d="M7 21h10a2 2 0 002-2V9.414a1 1 0 00-.293-.707l-5.414-5.414A1 1 0 0012.586 3H7a2 2 0 00-2 2v14a2 2 0 002 2z" />+ </svg>+ Host File Mount+ </a><a class="dropdown-item"@click="directoryModalOpen = true; dropdownOpen = false"><svg class="size-4" fill="none" stroke="currentColor"@@ -188,14 +199,28 @@}})"><form class="flex flex-col w-full gap-2 rounded-sm"+ x-data="{+ hostPath: @js($this->fileStorageHostPath()),+ filePath: @entangle('file_storage_path'),+ previewPath() {+ const path = (this.filePath || '').trim();++ return this.hostPath + (path === '' ? '/' : (path.startsWith('/') ? path : `/${path}`));+ },+ }"wire:submit='submitFileStorage'><div class="flex flex-col">- <div>Actual file mounted from the host system to the container.</div>+ <div>This file will be created on the host, then mounted into the container.</div></div><div class="flex flex-col gap-2">+ <div class="p-2 text-xs rounded-sm bg-neutral-100 dark:bg-coolgray-200">+ <div class="mb-1 font-medium">Host file path</div>+ <code class="break-all" x-text="previewPath()">{{ $this->fileStoragePreviewPath() }}</code>+ </div><x-forms.input canGate="update" :canResource="$resource"placeholder="/etc/nginx/nginx.conf" id="file_storage_path"label="Destination Path" required+ x-on:input="filePath = $event.target.value"helper="File location inside the container" /><x-forms.textarea canGate="update" :canResource="$resource" label="Content"id="file_storage_content"></x-forms.textarea>@@ -209,6 +234,67 @@</div></template>+ {{-- Host File Modal --}}+ <template x-teleport="body">+ <div x-show="hostFileModalOpen" @keydown.window.escape="hostFileModalOpen=false"+ class="fixed top-0 left-0 lg:px-0 px-4 z-99 flex items-center justify-center w-screen h-screen">+ <div x-show="hostFileModalOpen" x-transition:enter="ease-out duration-100"+ x-transition:enter-start="opacity-0" x-transition:enter-end="opacity-100"+ x-transition:leave="ease-in duration-100" x-transition:leave-start="opacity-100"+ x-transition:leave-end="opacity-0" @click="hostFileModalOpen=false"+ class="absolute inset-0 w-full h-full bg-black/20 backdrop-blur-xs"></div>+ <div x-show="hostFileModalOpen" x-trap.inert.noscroll="hostFileModalOpen"+ x-transition:enter="ease-out duration-100"+ x-transition:enter-start="opacity-0 -translate-y-2 sm:scale-95"+ x-transition:enter-end="opacity-100 translate-y-0 sm:scale-100"+ x-transition:leave="ease-in duration-100"+ x-transition:leave-start="opacity-100 translate-y-0 sm:scale-100"+ x-transition:leave-end="opacity-0 -translate-y-2 sm:scale-95"+ class="relative w-full py-6 border rounded-sm drop-shadow-sm min-w-full lg:min-w-[36rem] max-w-fit bg-white border-neutral-200 dark:bg-base px-6 dark:border-coolgray-300">+ <div class="flex items-center justify-between pb-3">+ <h3 class="text-2xl font-bold">Add Host File Mount</h3>+ <button @click="hostFileModalOpen=false"+ class="absolute top-0 right-0 flex items-center justify-center w-8 h-8 mt-5 mr-5 rounded-full dark:text-white hover:bg-neutral-100 dark:hover:bg-coolgray-300 outline-0 focus-visible:ring-2 focus-visible:ring-coollabs dark:focus-visible:ring-warning">+ <svg class="w-5 h-5" xmlns="http://www.w3.org/2000/svg" fill="none"+ viewBox="0 0 24 24" stroke-width="1.5" stroke="currentColor">+ <path stroke-linecap="round" stroke-linejoin="round"+ d="M6 18L18 6M6 6l12 12" />+ </svg>+ </button>+ </div>+ <div class="relative flex items-center justify-center w-auto"+ x-init="$watch('hostFileModalOpen', value => {+ if (value) {+ $nextTick(() => {+ const input = $el.querySelector('input');+ input?.focus();+ })+ }+ })">+ <form class="flex flex-col w-full gap-2 rounded-sm"+ wire:submit='submitHostFileStorage'>+ <div class="flex flex-col">+ <div>Bind an existing host file into the container. Coolify will not create, edit, load, chmod, or delete the source file.</div>+ </div>+ <div class="flex flex-col gap-2">+ <x-forms.input canGate="update" :canResource="$resource"+ placeholder="/etc/nginx/nginx.conf"+ id="host_file_storage_source" label="Host File Path" required+ helper="Existing file on the host system." />+ <x-forms.input canGate="update" :canResource="$resource"+ placeholder="/etc/nginx/nginx.conf"+ id="host_file_storage_destination" label="Destination Path"+ required helper="File location inside the container." />+ <x-forms.button canGate="update" :canResource="$resource" type="submit">+ Add+ </x-forms.button>+ </div>+ </form>+ </div>+ </div>+ </div>+ </template>+{{-- Directory Modal --}}<template x-teleport="body"><div x-show="directoryModalOpen" @keydown.window.escape="directoryModalOpen=false"diff --git a/templates/service-templates-latest.json b/templates/service-templates-latest.jsonindex 811aee97e7..0a2dfda9d7 100644--- a/templates/service-templates-latest.json+++ b/templates/service-templates-latest.json@@ -2361,7 +2361,7 @@"category": "automation","logo": "svgs/inngest.png","minversion": "0.0.0",- "template_last_updated_at": "2026-06-10T13:46:21+05:30",+ "template_last_updated_at": "2026-07-02T13:25:47+02:00","port": "8288"},"invoice-ninja": {diff --git a/templates/service-templates.json b/templates/service-templates.jsonindex 9721a52dea..4d97d8d5e2 100644--- a/templates/service-templates.json+++ b/templates/service-templates.json@@ -2361,7 +2361,7 @@"category": "automation","logo": "svgs/inngest.png","minversion": "0.0.0",- "template_last_updated_at": "2026-06-10T13:46:21+05:30",+ "template_last_updated_at": "2026-07-02T13:25:47+02:00","port": "8288"},"invoice-ninja": {diff --git a/tests/Feature/FileStorageMountPathTest.php b/tests/Feature/FileStorageMountPathTest.phpnew file mode 100644index 0000000000..2a41b90759--- /dev/null+++ b/tests/Feature/FileStorageMountPathTest.php@@ -0,0 +1,123 @@+<?php++use App\Jobs\ServerStorageSaveJob;+use App\Livewire\Project\Service\Storage;+use App\Models\Application;+use App\Models\Environment;+use App\Models\InstanceSettings;+use App\Models\LocalFileVolume;+use App\Models\Project;+use App\Models\Server;+use App\Models\StandaloneDocker;+use App\Models\Team;+use App\Models\User;+use Illuminate\Foundation\Testing\RefreshDatabase;+use Illuminate\Support\Facades\Bus;+use Illuminate\Support\Facades\DB;+use Illuminate\Support\Str;+use Livewire\Livewire;++uses(RefreshDatabase::class);++beforeEach(function () {+ config(['app.maintenance.store' => 'array', 'cache.default' => 'array']);+ Bus::fake();+ InstanceSettings::unguarded(fn () => InstanceSettings::updateOrCreate(['id' => 0], ['id' => 0]));++ $this->team = Team::factory()->create();+ $this->admin = User::factory()->create();+ $this->admin->teams()->attach($this->team, ['role' => 'admin']);++ $keyId = DB::table('private_keys')->insertGetId([+ 'uuid' => (string) Str::uuid(),+ 'name' => 'Test Key',+ 'private_key' => 'test-key',+ 'team_id' => $this->team->id,+ 'created_at' => now(),+ 'updated_at' => now(),+ ]);++ $this->server = Server::factory()->create([+ 'team_id' => $this->team->id,+ 'private_key_id' => $keyId,+ ]);++ StandaloneDocker::withoutEvents(function () {+ $this->destination = StandaloneDocker::firstOrCreate(+ ['server_id' => $this->server->id, 'network' => 'coolify'],+ ['uuid' => (string) Str::uuid(), 'name' => 'test-docker']+ );+ });++ $this->project = Project::create([+ 'uuid' => (string) Str::uuid(),+ 'name' => 'Test Project',+ 'team_id' => $this->team->id,+ ]);++ $this->environment = $this->project->environments()->first()+ ?? Environment::factory()->create(['project_id' => $this->project->id]);++ $this->application = Application::factory()->create([+ 'uuid' => (string) Str::uuid(),+ 'name' => 'Test App',+ 'environment_id' => $this->environment->id,+ 'destination_id' => $this->destination->id,+ 'destination_type' => $this->destination->getMorphClass(),+ ]);++ $this->actingAs($this->admin);+ session(['currentTeam' => $this->team]);+});++test('livewire file storage rejects parent segments and does not create a local file volume', function () {+ Livewire::test(Storage::class, ['resource' => $this->application])+ ->set('file_storage_path', '/../../../../../../etc/example.conf')+ ->set('file_storage_content', 'owned')+ ->call('submitFileStorage')+ ->assertDispatched('error');++ expect(LocalFileVolume::query()->count())->toBe(0);+});++test('file mount modal shows the calculated host file path above the destination input', function () {+ Livewire::test(Storage::class, ['resource' => $this->application])+ ->assertSeeText('This file will be created on the host, then mounted into the container.')+ ->assertSeeText('Host file path')+ ->assertSeeText($this->application->workdir().'/')+ ->set('file_storage_path', '/etc/nginx/nginx.conf')+ ->assertSeeText($this->application->workdir().'/etc/nginx/nginx.conf')+ ->assertDontSeeText('Actual file mounted from the host system to the container.');+});++test('livewire file storage stores safe file mounts under the application configuration root', function () {+ Livewire::test(Storage::class, ['resource' => $this->application])+ ->set('file_storage_path', '/etc/nginx/nginx.conf')+ ->set('file_storage_content', 'server {}')+ ->call('submitFileStorage')+ ->assertDispatched('success');++ $volume = LocalFileVolume::query()->sole();++ expect($volume->mount_path)->toBe('/etc/nginx/nginx.conf')+ ->and($volume->fs_path)->toBe(application_configuration_dir().'/'.$this->application->uuid.'/etc/nginx/nginx.conf')+ ->and($volume->is_directory)->toBeFalse();+});++test('livewire host file storage stores an existing host file path without managed content', function () {+ Livewire::test(Storage::class, ['resource' => $this->application])+ ->set('host_file_storage_source', '/etc/nginx/nginx.conf')+ ->set('host_file_storage_destination', '/etc/nginx/nginx.conf')+ ->call('submitHostFileStorage')+ ->assertDispatched('success');++ $volume = LocalFileVolume::query()->sole();++ expect($volume->fs_path)->toBe('/etc/nginx/nginx.conf')+ ->and($volume->mount_path)->toBe('/etc/nginx/nginx.conf')+ ->and($volume->content)->toBeNull()+ ->and($volume->is_host_file)->toBeTrue()+ ->and($volume->is_directory)->toBeFalse();++ Bus::assertNotDispatched(ServerStorageSaveJob::class);+});diff --git a/tests/Feature/StorageApiTest.php b/tests/Feature/StorageApiTest.phpindex 75357e41ec..92d92f860f 100644--- a/tests/Feature/StorageApiTest.php+++ b/tests/Feature/StorageApiTest.php@@ -1,5 +1,6 @@<?php+use App\Jobs\ServerStorageSaveJob;use App\Models\Application;use App\Models\Environment;use App\Models\InstanceSettings;@@ -7,6 +8,8 @@ use App\Models\LocalFileVolume;use App\Models\LocalPersistentVolume;use App\Models\Project;use App\Models\Server;+use App\Models\Service;+use App\Models\ServiceApplication;use App\Models\StandaloneDocker;use App\Models\StandalonePostgresql;use App\Models\Team;@@ -18,8 +21,9 @@ use Illuminate\Support\Str;uses(RefreshDatabase::class);beforeEach(function () {+ config(['app.maintenance.store' => 'array', 'cache.default' => 'array']);Bus::fake();- InstanceSettings::updateOrCreate(['id' => 0]);+ InstanceSettings::unguarded(fn () => InstanceSettings::updateOrCreate(['id' => 0], ['id' => 0]));$this->team = Team::factory()->create();$this->user = User::factory()->create();@@ -61,6 +65,24 @@ function createTestDatabase($context): StandalonePostgresql]);}+function createTestServiceApplication($context): array+{+ $service = Service::factory()->create([+ 'environment_id' => $context->environment->id,+ 'destination_id' => $context->destination->id,+ 'destination_type' => $context->destination->getMorphClass(),+ ]);++ $serviceApplication = ServiceApplication::create([+ 'uuid' => (string) Str::uuid(),+ 'name' => 'test-service-app',+ 'service_id' => $service->id,+ 'image' => 'nginx:alpine',+ ]);++ return [$service, $serviceApplication];+}+// ──────────────────────────────────────────────────────────────// Application Storage Endpoints// ──────────────────────────────────────────────────────────────@@ -140,6 +162,56 @@ describe('POST /api/v1/applications/{uuid}/storages', function () {expect($vol)->not->toBeNull();expect($vol->mount_path)->toBe('/app/config.json');expect($vol->is_directory)->toBeFalse();+ expect($vol->fs_path)->toBe(application_configuration_dir().'/'.$app->uuid.'/app/config.json');+ });++ test('creates bind only host file storage for application', function () {+ $app = createTestApplication($this);++ $response = $this->withHeaders([+ 'Authorization' => 'Bearer '.$this->bearerToken,+ 'Content-Type' => 'application/json',+ ])->postJson("/api/v1/applications/{$app->uuid}/storages", [+ 'type' => 'file',+ 'is_host_file' => true,+ 'fs_path' => '/etc/nginx/nginx.conf',+ 'mount_path' => '/etc/nginx/nginx.conf',+ ]);++ $response->assertStatus(201);++ $vol = LocalFileVolume::where('resource_id', $app->id)+ ->where('resource_type', get_class($app))+ ->first();++ expect($vol)->not->toBeNull();+ expect($vol->fs_path)->toBe('/etc/nginx/nginx.conf');+ expect($vol->mount_path)->toBe('/etc/nginx/nginx.conf');+ expect($vol->content)->toBeNull();+ expect($vol->is_host_file)->toBeTrue();+ expect($vol->is_directory)->toBeFalse();++ Bus::assertNotDispatched(ServerStorageSaveJob::class);+ });++ test('rejects file storage paths with parent segments', function () {+ $app = createTestApplication($this);++ $response = $this->withHeaders([+ 'Authorization' => 'Bearer '.$this->bearerToken,+ 'Content-Type' => 'application/json',+ ])->postJson("/api/v1/applications/{$app->uuid}/storages", [+ 'type' => 'file',+ 'mount_path' => '/../../../../../../etc/example.conf',+ 'content' => 'owned',+ ]);++ $response->assertStatus(422);+ $response->assertJsonPath('message', 'Validation failed.');++ expect(LocalFileVolume::where('resource_id', $app->id)+ ->where('resource_type', get_class($app))+ ->exists())->toBeFalse();});test('rejects persistent storage without name', function () {@@ -331,6 +403,92 @@ describe('POST /api/v1/databases/{uuid}/storages', function () {expect($vol)->not->toBeNull();expect($vol->mount_path)->toBe('/extra');});++ test('creates a file storage for a database under the database configuration root', function () {+ $db = createTestDatabase($this);++ $response = $this->withHeaders([+ 'Authorization' => 'Bearer '.$this->bearerToken,+ 'Content-Type' => 'application/json',+ ])->postJson("/api/v1/databases/{$db->uuid}/storages", [+ 'type' => 'file',+ 'mount_path' => '/postgres/postgresql.conf',+ 'content' => 'listen_addresses = "*"',+ ]);++ $response->assertStatus(201);++ $vol = LocalFileVolume::where('resource_id', $db->id)+ ->where('resource_type', get_class($db))+ ->first();++ expect($vol)->not->toBeNull();+ expect($vol->fs_path)->toBe(database_configuration_dir().'/'.$db->uuid.'/postgres/postgresql.conf');+ });++ test('rejects file storage paths with parent segments for a database', function () {+ $db = createTestDatabase($this);++ $response = $this->withHeaders([+ 'Authorization' => 'Bearer '.$this->bearerToken,+ 'Content-Type' => 'application/json',+ ])->postJson("/api/v1/databases/{$db->uuid}/storages", [+ 'type' => 'file',+ 'mount_path' => '/postgres/../../../etc/shadow',+ 'content' => 'owned',+ ]);++ $response->assertStatus(422);++ expect(LocalFileVolume::where('resource_id', $db->id)+ ->where('resource_type', get_class($db))+ ->exists())->toBeFalse();+ });+});++describe('POST /api/v1/services/{uuid}/storages', function () {+ test('creates a file storage for a service resource under the service configuration root', function () {+ [$service, $serviceApplication] = createTestServiceApplication($this);++ $response = $this->withHeaders([+ 'Authorization' => 'Bearer '.$this->bearerToken,+ 'Content-Type' => 'application/json',+ ])->postJson("/api/v1/services/{$service->uuid}/storages", [+ 'type' => 'file',+ 'resource_uuid' => $serviceApplication->uuid,+ 'mount_path' => '/etc/nginx/nginx.conf',+ 'content' => 'server {}',+ ]);++ $response->assertStatus(201);++ $vol = LocalFileVolume::where('resource_id', $serviceApplication->id)+ ->where('resource_type', get_class($serviceApplication))+ ->first();++ expect($vol)->not->toBeNull();+ expect($vol->fs_path)->toBe(service_configuration_dir().'/'.$service->uuid.'/etc/nginx/nginx.conf');+ });++ test('rejects file storage paths with parent segments for a service resource', function () {+ [$service, $serviceApplication] = createTestServiceApplication($this);++ $response = $this->withHeaders([+ 'Authorization' => 'Bearer '.$this->bearerToken,+ 'Content-Type' => 'application/json',+ ])->postJson("/api/v1/services/{$service->uuid}/storages", [+ 'type' => 'file',+ 'resource_uuid' => $serviceApplication->uuid,+ 'mount_path' => '/../../../../../../root/.ssh/authorized_keys',+ 'content' => 'owned',+ ]);++ $response->assertStatus(422);++ expect(LocalFileVolume::where('resource_id', $serviceApplication->id)+ ->where('resource_type', get_class($serviceApplication))+ ->exists())->toBeFalse();+ });});describe('PATCH /api/v1/databases/{uuid}/storages', function () {diff --git a/tests/Unit/FileStorageSecurityTest.php b/tests/Unit/FileStorageSecurityTest.phpindex 1e08ebbe70..b5e1c74042 100644--- a/tests/Unit/FileStorageSecurityTest.php+++ b/tests/Unit/FileStorageSecurityTest.php@@ -141,3 +141,77 @@ test('file storage accepts relative dot-prefixed paths', function () {expect(fn () => validateShellSafePath('./data', 'storage path'))->not->toThrow(Exception::class);});++test('file mount path validator rejects parent segments and unsafe separators', function (string $path) {+ expect(fn () => validateFileMountPath($path, 'file storage path'))+ ->toThrow(Exception::class);+})->with([+ 'parent segment to etc' => ['/../../etc/passwd'],+ 'embedded parent segment' => ['/foo/../bar'],+ 'parent segment' => ['/..'],+ 'double slash before parent segment' => ['/foo//../bar'],+ 'current directory segment' => ['/foo/./bar'],+ 'backslash parent segment' => ['\\..\\etc\\passwd'],+ 'null byte' => ["/app/config\0/../../etc/passwd"],+]);++test('file mount path validator accepts safe absolute container file paths', function (string $path, string $expected) {+ expect(validateFileMountPath($path, 'file storage path'))->toBe($expected);+})->with([+ 'nginx config' => ['/etc/nginx/nginx.conf', '/etc/nginx/nginx.conf'],+ 'app env filename' => ['/app/.env', '/app/.env'],+ 'relative input becomes absolute' => ['config/app.yaml', '/config/app.yaml'],+ 'duplicate slashes collapse' => ['/opt//app///config.json', '/opt/app/config.json'],+]);++test('host file mount path validator accepts absolute host file paths', function () {+ expect(validateHostFileMountPath('/etc/nginx/nginx.conf', 'host file path'))+ ->toBe('/etc/nginx/nginx.conf');+});++test('host file mount path validator rejects ambiguous or directory paths', function (string $path) {+ expect(fn () => validateHostFileMountPath($path, 'host file path'))+ ->toThrow(Exception::class);+})->with([+ 'relative path' => ['etc/nginx/nginx.conf'],+ 'root directory' => ['/'],+ 'trailing slash' => ['/etc/nginx/'],+ 'parent segment' => ['/etc/../shadow'],+ 'current segment' => ['/etc/./nginx.conf'],+ 'backslash' => ['\\etc\\nginx.conf'],+]);++test('confined path resolver keeps file mounts inside their resource configuration root', function () {+ expect(confineFileMountPath('/data/coolify/applications/app-uuid', '/etc/nginx/nginx.conf', 'file storage path'))+ ->toBe('/data/coolify/applications/app-uuid/etc/nginx/nginx.conf');++ expect(confineFileMountPath('/data/coolify/databases/db-uuid/', 'postgres/postgresql.conf', 'file storage path'))+ ->toBe('/data/coolify/databases/db-uuid/postgres/postgresql.conf');++ expect(confineFileMountPath('/data/coolify/services/service-uuid', '/config.yaml', 'file storage path'))+ ->toBe('/data/coolify/services/service-uuid/config.yaml');+});++test('confined path resolver rejects paths that escape the resource configuration root', function (string $base, string $path) {+ expect(fn () => confineFileMountPath($base, $path, 'file storage path'))+ ->toThrow(Exception::class);+})->with([+ 'application parent segment' => ['/data/coolify/applications/app-uuid', '/../../etc/passwd'],+ 'database parent segment' => ['/data/coolify/databases/db-uuid', '/postgres/../../../etc/shadow'],+ 'service dot segment' => ['/data/coolify/services/service-uuid', '/./config.yaml'],+]);++test('local file volume write sink keeps saved managed file paths for compatibility', function () {+ $source = file_get_contents(__DIR__.'/../../app/Models/LocalFileVolume.php');++ expect($source)->not->toContain('confinePathToBase($workdir, $path->value(), \'storage path\')')+ ->and($source)->toContain('tee {$escapedPath}');+});++test('host file mounts are bind-only and skipped by server storage writes', function () {+ $source = file_get_contents(__DIR__.'/../../app/Models/LocalFileVolume.php');++ expect($source)->toContain('if ($this->is_host_file) {')+ ->and($source)->toContain('return;')+ ->and($source)->toContain('tee {$escapedPath}');+});