An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(hetzner): require at least one public IP protocol
Andras Bacsaia8000ac2ad2f
diff --git a/app/Http/Controllers/Api/HetznerController.php b/app/Http/Controllers/Api/HetznerController.phpindex 151f9854b0..4cadc0eb64 100644--- a/app/Http/Controllers/Api/HetznerController.php+++ b/app/Http/Controllers/Api/HetznerController.php@@ -824,6 +824,16 @@ class HetznerController extends Controller$request->offsetSet('instant_validate', false);}+ if (! $request->boolean('enable_ipv4') && ! $request->boolean('enable_ipv6')) {+ return response()->json([+ 'message' => 'Validation failed.',+ 'errors' => [+ 'enable_ipv4' => ['Enable at least one public IP protocol.'],+ 'enable_ipv6' => ['Enable at least one public IP protocol.'],+ ],+ ], 422);+ }+// Validate cloud provider token$tokenUuid = $this->getCloudProviderTokenUuid($request);$token = CloudProviderToken::whereTeamId($teamId)diff --git a/app/Livewire/Server/New/ByHetzner.php b/app/Livewire/Server/New/ByHetzner.phpindex f991bc3e80..96740537d1 100644--- a/app/Livewire/Server/New/ByHetzner.php+++ b/app/Livewire/Server/New/ByHetzner.php@@ -620,6 +620,13 @@ class ByHetzner extends Component{$this->validate();+ if (! $this->enable_ipv4 && ! $this->enable_ipv6) {+ $this->addError('enable_ipv4', 'Enable at least one public IP protocol.');+ $this->addError('enable_ipv6', 'Enable at least one public IP protocol.');++ return null;+ }+try {$this->authorize('create', Server::class);diff --git a/tests/Feature/Api/HetznerApiTest.php b/tests/Feature/Api/HetznerApiTest.phpindex 46311e5b57..8c1856f026 100644--- a/tests/Feature/Api/HetznerApiTest.php+++ b/tests/Feature/Api/HetznerApiTest.php@@ -669,6 +669,28 @@ describe('POST /api/v1/servers/hetzner', function () {$response->assertJsonFragment(['ip' => '2001:db8::1']);});+ test('rejects server creation when both public IP protocols are disabled', function () {+ Http::fake();++ $response = $this->withHeaders([+ 'Authorization' => 'Bearer '.$this->bearerToken,+ 'Content-Type' => 'application/json',+ ])->postJson('/api/v1/servers/hetzner', [+ 'cloud_provider_token_id' => $this->hetznerToken->uuid,+ 'location' => 'nbg1',+ 'server_type' => 'cx11',+ 'image' => 15512617,+ 'name' => 'test-server',+ 'private_key_uuid' => $this->privateKey->uuid,+ 'enable_ipv4' => false,+ 'enable_ipv6' => false,+ ]);++ $response->assertStatus(422);+ $response->assertJsonValidationErrors(['enable_ipv4', 'enable_ipv6']);+ Http::assertNothingSent();+ });+test('passes selected firewalls and networks to Hetzner server creation', function () {Http::fake(['https://api.hetzner.cloud/v1/ssh_keys' => Http::response([diff --git a/tests/Feature/Server/HetznerServerCreationTest.php b/tests/Feature/Server/HetznerServerCreationTest.phpindex 34e25d58ad..9576416010 100644--- a/tests/Feature/Server/HetznerServerCreationTest.php+++ b/tests/Feature/Server/HetznerServerCreationTest.php@@ -240,7 +240,7 @@ describe('Hetzner data loading', function () {'token' => 'test-hetzner-api-token',]);- PrivateKey::factory()->create([+ $this->privateKey = PrivateKey::factory()->create(['team_id' => $this->team->id,]);});@@ -298,4 +298,23 @@ describe('Hetzner data loading', function () {expect($component->get('hetznerFirewalls'))->toHaveCount(1)->and($component->get('hetznerNetworks'))->toHaveCount(1);});++ test('rejects submitting without a public IP protocol before calling Hetzner', function () {+ Http::fake();++ Livewire::test(ByHetzner::class)+ ->set('current_step', 2)+ ->set('selected_token_id', $this->hetznerToken->id)+ ->set('server_name', 'test-server')+ ->set('selected_location', 'nbg1')+ ->set('selected_server_type', 'cx11')+ ->set('selected_image', 15512617)+ ->set('private_key_id', $this->privateKey->id)+ ->set('enable_ipv4', false)+ ->set('enable_ipv6', false)+ ->call('submit')+ ->assertHasErrors(['enable_ipv4', 'enable_ipv6']);++ Http::assertNothingSent();+ });});