An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(deployment): skip missing Compose Dockerfiles with portable realpath
Andras Bacsaia86188f3911f
diff --git a/app/Jobs/ApplicationDeploymentJob.php b/app/Jobs/ApplicationDeploymentJob.phpindex b9143ae1b0..e22dce607c 100644--- a/app/Jobs/ApplicationDeploymentJob.php+++ b/app/Jobs/ApplicationDeploymentJob.php@@ -4911,8 +4911,9 @@ COPY ./nginx.conf /etc/nginx/conf.d/default.conf");$dockerfilePath = $this->resolveComposeDockerfilePath($service['build']);$fullDockerfilePath = escapeshellarg("{$this->workdir}/{$dockerfilePath}");+ // BusyBox realpath in the helper image accepts no options; a missing file prints nothing.$this->execute_remote_command([- executeInDocker($this->deployment_uuid, "resolved_path=$(realpath -e -- {$fullDockerfilePath}) && test -f \"\$resolved_path\" && printf '%s' \"\$resolved_path\""),+ executeInDocker($this->deployment_uuid, "resolved_path=$(realpath {$fullDockerfilePath} 2>/dev/null) && test -f \"\$resolved_path\" && printf '%s' \"\$resolved_path\" || true"),'hidden' => true,'save' => 'dockerfile_check_'.$serviceName,]);diff --git a/tests/Feature/ApplicationDeploymentControlVarFilteringTest.php b/tests/Feature/ApplicationDeploymentControlVarFilteringTest.phpindex da2707b7f6..a76cfbf7f6 100644--- a/tests/Feature/ApplicationDeploymentControlVarFilteringTest.php+++ b/tests/Feature/ApplicationDeploymentControlVarFilteringTest.php@@ -1067,6 +1067,44 @@ it('injects Dockerfile args for plain build-time variables without a secret mana'preview' => [99, true],]);+it('checks compose Dockerfiles with a portable command that skips missing files', function (bool $dockerfileExists) {+ [$application, $server] = makeDeploymentControlVarFixture(['build_pack' => 'dockercompose']);+ $workdir = sys_get_temp_dir().'/coolify-compose-dockerfile-'.str()->random(8);+ expect(mkdir($workdir))->toBeTrue();++ if ($dockerfileExists) {+ file_put_contents($workdir.'/Dockerfile', "FROM alpine\n");+ }++ try {+ [$job, $reflection] = makeControlVarFilteringJob($application, $server, [+ 'workdir' => $workdir,+ 'env_args' => collect(['APP_ENV' => 'production']),+ ]);++ invokeDeploymentJobMethod($job, $reflection, 'modify_dockerfiles_for_compose', [+ 'services' => ['api' => ['build' => ['context' => '.', 'dockerfile' => 'Dockerfile']]],+ ]);++ $checkCommand = collect($job->recordedCommands)->flatten(1)->firstWhere('save', 'dockerfile_check_api')[0];++ // The helper image ships BusyBox realpath, which accepts no options.+ expect($checkCommand)->not->toContain('realpath -');++ $process = Process::fromShellCommandline(str($checkCommand)->after('docker exec deployment-uuid ')->toString());+ $process->run();++ expect($process->getExitCode())->toBe(0);+ expect($process->getOutput())->toBe($dockerfileExists ? realpath($workdir.'/Dockerfile') : '');+ } finally {+ @unlink($workdir.'/Dockerfile');+ @rmdir($workdir);+ }+})->with([+ 'existing Dockerfile' => [true],+ 'missing Dockerfile' => [false],+]);+it('builds railpack variables from generic buildtime vars railpack vars and coolify vars only', function () {[$application, $server] = makeDeploymentControlVarFixture(['build_pack' => 'railpack',