An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(security): harden model assignment and sensitive data handling
Andras Bacsaib3256d4df14e
diff --git a/app/Actions/Fortify/CreateNewUser.php b/app/Actions/Fortify/CreateNewUser.phpindex 9f97dd0d4c..7ea6a871e2 100644--- a/app/Actions/Fortify/CreateNewUser.php+++ b/app/Actions/Fortify/CreateNewUser.php@@ -37,12 +37,13 @@ class CreateNewUser implements CreatesNewUsersif (User::count() == 0) {// If this is the first user, make them the root user// Team is already created in the database/seeders/ProductionSeeder.php- $user = User::create([+ $user = (new User)->forceFill(['id' => 0,'name' => $input['name'],'email' => $input['email'],'password' => Hash::make($input['password']),]);+ $user->save();$team = $user->teams()->first();// Disable registration after first user is createddiff --git a/app/Http/Controllers/Api/TeamController.php b/app/Http/Controllers/Api/TeamController.phpindex fd0282d96b..03b36e4e0c 100644--- a/app/Http/Controllers/Api/TeamController.php+++ b/app/Http/Controllers/Api/TeamController.php@@ -14,14 +14,6 @@ class TeamController extends Controller'custom_server_limit','pivot',]);- if (request()->attributes->get('can_read_sensitive', false) === false) {- $team->makeHidden([- 'smtp_username',- 'smtp_password',- 'resend_api_key',- 'telegram_token',- ]);- }return serializeApiResponse($team);}diff --git a/app/Models/Application.php b/app/Models/Application.phpindex a4789ae4ad..3312f4c769 100644--- a/app/Models/Application.php+++ b/app/Models/Application.php@@ -1767,7 +1767,7 @@ class Application extends BaseModel$fileList = collect([".$workdir$composeFile"]);$gitRemoteStatus = $this->getGitRemoteStatus(deployment_uuid: $uuid);if (! $gitRemoteStatus['is_accessible']) {- throw new RuntimeException("Failed to read Git source:\n\n{$gitRemoteStatus['error']}");+ throw new RuntimeException('Failed to read Git source. Please verify repository access and try again.');}$getGitVersion = instant_remote_process(['git --version'], $this->destination->server, false);$gitVersion = str($getGitVersion)->explode(' ')->last();@@ -1825,7 +1825,7 @@ class Application extends BaseModel}throw new RuntimeException('Repository does not exist. Please check your repository URL and try again.');}- throw new RuntimeException($e->getMessage());+ throw new RuntimeException('Failed to read the Docker Compose file from the repository.');} finally {// Cleanup only - restoration happens in catch block$commands = collect([diff --git a/app/Models/ServerSetting.php b/app/Models/ServerSetting.phpindex 504cfa60a4..efc7bc8deb 100644--- a/app/Models/ServerSetting.php+++ b/app/Models/ServerSetting.php@@ -56,6 +56,7 @@ class ServerSetting extends Modelprotected $guarded = [];protected $casts = [+ 'force_disabled' => 'boolean','force_docker_cleanup' => 'boolean','docker_cleanup_threshold' => 'integer','sentinel_token' => 'encrypted',diff --git a/app/Models/StandaloneClickhouse.php b/app/Models/StandaloneClickhouse.phpindex 74382d87c9..c192e53601 100644--- a/app/Models/StandaloneClickhouse.php+++ b/app/Models/StandaloneClickhouse.php@@ -42,7 +42,7 @@ class StandaloneClickhouse extends BaseModelprotected $appends = ['internal_db_url', 'external_db_url', 'database_type', 'server_status'];protected $casts = [- 'clickhouse_password' => 'encrypted',+ 'clickhouse_admin_password' => 'encrypted','public_port_timeout' => 'integer','restart_count' => 'integer','last_restart_at' => 'datetime',diff --git a/app/Models/StandaloneRedis.php b/app/Models/StandaloneRedis.phpindex 812a0e5cb2..2320619cff 100644--- a/app/Models/StandaloneRedis.php+++ b/app/Models/StandaloneRedis.php@@ -16,7 +16,6 @@ class StandaloneRedis extends BaseModelprotected $fillable = ['name','description',- 'redis_password','redis_conf','status','image',diff --git a/app/Models/Team.php b/app/Models/Team.phpindex 4b9751706f..8eb8fa050e 100644--- a/app/Models/Team.php+++ b/app/Models/Team.php@@ -43,10 +43,9 @@ class Team extends Model implements SendsDiscord, SendsEmail, SendsPushover, Senprotected $fillable = ['name','description',+ 'personal_team','show_boarding','custom_server_limit',- 'use_instance_email_settings',- 'resend_api_key',];protected $casts = [diff --git a/app/Models/User.php b/app/Models/User.phpindex 6b6f932390..a62cb8358f 100644--- a/app/Models/User.php+++ b/app/Models/User.php@@ -49,9 +49,6 @@ class User extends Authenticatable implements SendsEmail'password','force_password_reset','marketing_emails',- 'pending_email',- 'email_change_code',- 'email_change_code_expires_at',];protected $hidden = [@@ -98,7 +95,7 @@ class User extends Authenticatable implements SendsEmail$team['id'] = 0;$team['name'] = 'Root Team';}- $new_team = Team::create($team);+ $new_team = Team::forceCreate($team);$user->teams()->attach($new_team, ['role' => 'owner']);});@@ -201,7 +198,7 @@ class User extends Authenticatable implements SendsEmail$team['id'] = 0;$team['name'] = 'Root Team';}- $new_team = Team::create($team);+ $new_team = Team::forceCreate($team);$this->teams()->attach($new_team, ['role' => 'owner']);return $new_team;@@ -412,11 +409,11 @@ class User extends Authenticatable implements SendsEmail$expiryMinutes = config('constants.email_change.verification_code_expiry_minutes', 10);$expiresAt = Carbon::now()->addMinutes($expiryMinutes);- $this->update([+ $this->forceFill(['pending_email' => $newEmail,'email_change_code' => $code,'email_change_code_expires_at' => $expiresAt,- ]);+ ])->save();// Send verification email to new address$this->notify(new EmailChangeVerification($this, $code, $newEmail, $expiresAt));diff --git a/database/migrations/2026_03_29_000000_encrypt_existing_clickhouse_admin_passwords.php b/database/migrations/2026_03_29_000000_encrypt_existing_clickhouse_admin_passwords.phpnew file mode 100644index 0000000000..a4a6988f29--- /dev/null+++ b/database/migrations/2026_03_29_000000_encrypt_existing_clickhouse_admin_passwords.php@@ -0,0 +1,39 @@+<?php++use Illuminate\Database\Migrations\Migration;+use Illuminate\Support\Facades\Crypt;+use Illuminate\Support\Facades\DB;++class EncryptExistingClickhouseAdminPasswords extends Migration+{+ public function up(): void+ {+ try {+ DB::table('standalone_clickhouses')->chunkById(100, function ($clickhouses) {+ foreach ($clickhouses as $clickhouse) {+ $password = $clickhouse->clickhouse_admin_password;++ if (empty($password)) {+ continue;+ }++ // Skip if already encrypted (idempotent)+ try {+ Crypt::decryptString($password);++ continue;+ } catch (Exception) {+ // Not encrypted yet — encrypt it+ }++ DB::table('standalone_clickhouses')+ ->where('id', $clickhouse->id)+ ->update(['clickhouse_admin_password' => Crypt::encryptString($password)]);+ }+ });+ } catch (Exception $e) {+ echo 'Encrypting ClickHouse admin passwords failed.';+ echo $e->getMessage();+ }+ }+}diff --git a/database/seeders/RootUserSeeder.php b/database/seeders/RootUserSeeder.phpindex e3968a1c9c..c4e93af636 100644--- a/database/seeders/RootUserSeeder.php+++ b/database/seeders/RootUserSeeder.php@@ -45,12 +45,13 @@ class RootUserSeeder extends Seeder}try {- User::create([+ $user = (new User)->forceFill(['id' => 0,'name' => env('ROOT_USERNAME', 'Root User'),'email' => env('ROOT_USER_EMAIL'),'password' => Hash::make(env('ROOT_USER_PASSWORD')),]);+ $user->save();echo "\n SUCCESS Root user created successfully.\n\n";} catch (\Exception $e) {echo "\n ERROR Failed to create root user: {$e->getMessage()}\n\n";diff --git a/tests/Feature/GetLogsCommandInjectionTest.php b/tests/Feature/GetLogsCommandInjectionTest.phpindex 34824b48bd..3e5a33b661 100644--- a/tests/Feature/GetLogsCommandInjectionTest.php+++ b/tests/Feature/GetLogsCommandInjectionTest.php@@ -1,8 +1,40 @@<?phpuse App\Livewire\Project\Shared\GetLogs;+use App\Models\Application;+use App\Models\Environment;+use App\Models\Project;+use App\Models\Server;+use App\Models\StandaloneDocker;+use App\Models\Team;+use App\Models\User;use App\Support\ValidationPatterns;+use Illuminate\Foundation\Testing\RefreshDatabase;use Livewire\Attributes\Locked;+use Livewire\Livewire;++uses(RefreshDatabase::class);++beforeEach(function () {+ $this->user = User::factory()->create();+ $this->team = Team::factory()->create();+ $this->user->teams()->attach($this->team, ['role' => 'owner']);++ $this->server = Server::factory()->create(['team_id' => $this->team->id]);+ // Server::created auto-creates a StandaloneDocker, reuse it+ $this->destination = StandaloneDocker::where('server_id', $this->server->id)->first();+ $this->project = Project::factory()->create(['team_id' => $this->team->id]);+ $this->environment = Environment::factory()->create(['project_id' => $this->project->id]);++ $this->application = Application::factory()->create([+ 'environment_id' => $this->environment->id,+ 'destination_id' => $this->destination->id,+ 'destination_type' => $this->destination->getMorphClass(),+ ]);++ $this->actingAs($this->user);+ session(['currentTeam' => $this->team]);+});describe('GetLogs locked properties', function () {test('container property has Locked attribute', function () {@@ -34,47 +66,67 @@ describe('GetLogs locked properties', function () {});});-describe('GetLogs container name validation in getLogs', function () {- test('getLogs method validates container name with ValidationPatterns', function () {- $method = new ReflectionMethod(GetLogs::class, 'getLogs');- $startLine = $method->getStartLine();- $endLine = $method->getEndLine();- $lines = array_slice(file($method->getFileName()), $startLine - 1, $endLine - $startLine + 1);- $methodBody = implode('', $lines);-- expect($methodBody)->toContain('ValidationPatterns::isValidContainerName');+describe('GetLogs Livewire action validation', function () {+ test('getLogs rejects invalid container name', function () {+ // Make server functional by setting settings directly+ $this->server->settings->forceFill([+ 'is_reachable' => true,+ 'is_usable' => true,+ 'force_disabled' => false,+ ])->save();+ // Reload server with fresh settings to ensure casted values+ $server = Server::with('settings')->find($this->server->id);++ Livewire::test(GetLogs::class, [+ 'server' => $server,+ 'resource' => $this->application,+ 'container' => 'container;malicious-command',+ ])+ ->call('getLogs')+ ->assertSet('outputs', 'Invalid container name.');});- test('downloadAllLogs method validates container name with ValidationPatterns', function () {- $method = new ReflectionMethod(GetLogs::class, 'downloadAllLogs');- $startLine = $method->getStartLine();- $endLine = $method->getEndLine();- $lines = array_slice(file($method->getFileName()), $startLine - 1, $endLine - $startLine + 1);- $methodBody = implode('', $lines);-- expect($methodBody)->toContain('ValidationPatterns::isValidContainerName');+ test('getLogs rejects unauthorized server access', function () {+ $otherTeam = Team::factory()->create();+ $otherServer = Server::factory()->create(['team_id' => $otherTeam->id]);++ Livewire::test(GetLogs::class, [+ 'server' => $otherServer,+ 'resource' => $this->application,+ 'container' => 'test-container',+ ])+ ->call('getLogs')+ ->assertSet('outputs', 'Unauthorized.');});-});-describe('GetLogs authorization checks', function () {- test('getLogs method checks server ownership via ownedByCurrentTeam', function () {- $method = new ReflectionMethod(GetLogs::class, 'getLogs');- $startLine = $method->getStartLine();- $endLine = $method->getEndLine();- $lines = array_slice(file($method->getFileName()), $startLine - 1, $endLine - $startLine + 1);- $methodBody = implode('', $lines);-- expect($methodBody)->toContain('Server::ownedByCurrentTeam()');+ test('downloadAllLogs returns empty for invalid container name', function () {+ $this->server->settings->forceFill([+ 'is_reachable' => true,+ 'is_usable' => true,+ 'force_disabled' => false,+ ])->save();+ $server = Server::with('settings')->find($this->server->id);++ Livewire::test(GetLogs::class, [+ 'server' => $server,+ 'resource' => $this->application,+ 'container' => 'container$(whoami)',+ ])+ ->call('downloadAllLogs')+ ->assertReturned('');});- test('downloadAllLogs method checks server ownership via ownedByCurrentTeam', function () {- $method = new ReflectionMethod(GetLogs::class, 'downloadAllLogs');- $startLine = $method->getStartLine();- $endLine = $method->getEndLine();- $lines = array_slice(file($method->getFileName()), $startLine - 1, $endLine - $startLine + 1);- $methodBody = implode('', $lines);-- expect($methodBody)->toContain('Server::ownedByCurrentTeam()');+ test('downloadAllLogs returns empty for unauthorized server', function () {+ $otherTeam = Team::factory()->create();+ $otherServer = Server::factory()->create(['team_id' => $otherTeam->id]);++ Livewire::test(GetLogs::class, [+ 'server' => $otherServer,+ 'resource' => $this->application,+ 'container' => 'test-container',+ ])+ ->call('downloadAllLogs')+ ->assertReturned('');});});diff --git a/tests/Feature/MassAssignmentProtectionTest.php b/tests/Feature/MassAssignmentProtectionTest.phpindex f6518648f1..18de67ce74 100644--- a/tests/Feature/MassAssignmentProtectionTest.php+++ b/tests/Feature/MassAssignmentProtectionTest.php@@ -96,6 +96,9 @@ describe('mass assignment protection', function () {expect($user->isFillable('remember_token'))->toBeFalse('remember_token should not be fillable');expect($user->isFillable('two_factor_secret'))->toBeFalse('two_factor_secret should not be fillable');expect($user->isFillable('two_factor_recovery_codes'))->toBeFalse('two_factor_recovery_codes should not be fillable');+ expect($user->isFillable('pending_email'))->toBeFalse('pending_email should not be fillable');+ expect($user->isFillable('email_change_code'))->toBeFalse('email_change_code should not be fillable');+ expect($user->isFillable('email_change_code_expires_at'))->toBeFalse('email_change_code_expires_at should not be fillable');});test('User model allows mass assignment of profile fields', function () {@@ -110,7 +113,18 @@ describe('mass assignment protection', function () {$team = new Team;expect($team->isFillable('id'))->toBeFalse();- expect($team->isFillable('personal_team'))->toBeFalse('personal_team should not be fillable');+ expect($team->isFillable('use_instance_email_settings'))->toBeFalse('use_instance_email_settings should not be fillable (migrated to EmailNotificationSettings)');+ expect($team->isFillable('resend_api_key'))->toBeFalse('resend_api_key should not be fillable (migrated to EmailNotificationSettings)');+ });++ test('Team model allows mass assignment of expected fields', function () {+ $team = new Team;++ expect($team->isFillable('name'))->toBeTrue();+ expect($team->isFillable('description'))->toBeTrue();+ expect($team->isFillable('personal_team'))->toBeTrue();+ expect($team->isFillable('show_boarding'))->toBeTrue();+ expect($team->isFillable('custom_server_limit'))->toBeTrue();});test('standalone database models block mass assignment of relationship IDs', function () {@@ -145,7 +159,7 @@ describe('mass assignment protection', function () {expect($model->isFillable('limits_memory'))->toBeTrue();$model = new StandaloneRedis;- expect($model->isFillable('redis_password'))->toBeTrue();+ expect($model->isFillable('redis_conf'))->toBeTrue();$model = new StandaloneMysql;expect($model->isFillable('mysql_root_password'))->toBeTrue();