An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(servers): index active server lookups by private key
Andras Bacsaic34f5f8e3bbc
diff --git a/app/Livewire/Security/PrivateKey/Show.php b/app/Livewire/Security/PrivateKey/Show.phpindex 1b8f26ff28..1c9277d116 100644--- a/app/Livewire/Security/PrivateKey/Show.php+++ b/app/Livewire/Security/PrivateKey/Show.php@@ -142,7 +142,6 @@ class Show extends Component$this->private_key->updatePrivateKey(['private_key' => formatPrivateKey($this->private_key->private_key),]);- refresh_server_connection($this->private_key);$this->dispatch('success', 'Private key updated.');if ($this->modalMode) {$this->dispatch('privateKeyUpdated');diff --git a/database/migrations/2026_10_28_232000_add_index_for_active_servers_by_private_key.php b/database/migrations/2026_10_28_232000_add_index_for_active_servers_by_private_key.phpnew file mode 100644index 0000000000..dd1187d9cc--- /dev/null+++ b/database/migrations/2026_10_28_232000_add_index_for_active_servers_by_private_key.php@@ -0,0 +1,45 @@+<?php++use Illuminate\Database\Migrations\Migration;+use Illuminate\Database\Schema\Blueprint;+use Illuminate\Support\Facades\DB;+use Illuminate\Support\Facades\Schema;++return new class extends Migration+{+ public $withinTransaction = false;++ /**+ * Supports PrivateKey::servers() lookups (isInUse(), refresh_server_connection()), which always exclude+ * soft-deleted servers. No query reads servers by private key with trashed rows, so only active servers are indexed.+ */+ public function up(): void+ {+ if (DB::getDriverName() === 'pgsql') {+ DB::statement('CREATE INDEX CONCURRENTLY IF NOT EXISTS idx_servers_private_key_id_active ON servers (private_key_id) WHERE deleted_at IS NULL');++ return;+ }++ if (! Schema::hasIndex('servers', 'idx_servers_private_key_id_active')) {+ Schema::table('servers', function (Blueprint $table) {+ $table->index('private_key_id', 'idx_servers_private_key_id_active');+ });+ }+ }++ public function down(): void+ {+ if (DB::getDriverName() === 'pgsql') {+ DB::statement('DROP INDEX CONCURRENTLY IF EXISTS idx_servers_private_key_id_active');++ return;+ }++ if (Schema::hasIndex('servers', 'idx_servers_private_key_id_active')) {+ Schema::table('servers', function (Blueprint $table) {+ $table->dropIndex('idx_servers_private_key_id_active');+ });+ }+ }+};diff --git a/tests/Feature/Security/PrivateKeyServerLookupTest.php b/tests/Feature/Security/PrivateKeyServerLookupTest.phpnew file mode 100644index 0000000000..3f8558b474--- /dev/null+++ b/tests/Feature/Security/PrivateKeyServerLookupTest.php@@ -0,0 +1,184 @@+<?php++use App\Livewire\Security\PrivateKey\Show;+use App\Models\InstanceSettings;+use App\Models\PrivateKey;+use App\Models\Server;+use App\Models\Team;+use App\Models\User;+use Illuminate\Foundation\Testing\RefreshDatabase;+use Illuminate\Support\Facades\Config;+use Illuminate\Support\Facades\Process;+use Illuminate\Support\Facades\Storage;+use Illuminate\Support\Once;+use Livewire\Livewire;++uses(RefreshDatabase::class);++beforeEach(function () {+ if (! InstanceSettings::query()->whereKey(0)->exists()) {+ $settings = new InstanceSettings;+ $settings->id = 0;+ $settings->save();+ }+ Once::flush();++ $this->team = Team::factory()->create();+ $this->user = User::factory()->create();+ $this->team->members()->attach($this->user->id, ['role' => 'owner']);++ session(['currentTeam' => $this->team]);+ $this->actingAs($this->user);++ Config::set('cache.default', 'array');+ Config::set('constants.ssh.mux_enabled', true);+ Storage::fake('ssh-keys');+ Process::fake();++ $this->privateKey = teamKey($this->team);+});++function teamToken(User $user, Team $team): string+{+ $token = $user->createToken('test', ['write']);+ $token->accessToken->forceFill(['team_id' => $team->id])->save();+ auth()->forgetGuards();++ return $token->plainTextToken;+}++function serverForKey(PrivateKey $privateKey, bool $deleted = false): Server+{+ $server = Server::factory()->create([+ 'team_id' => $privateKey->team_id,+ 'private_key_id' => $privateKey->id,+ ]);+ if ($deleted) {+ $server->delete();+ }++ return $server;+}++function teamKey(Team $team): PrivateKey+{+ return PrivateKey::factory()->create([+ 'team_id' => $team->id,+ 'private_key' => PrivateKey::generateNewKeyPair('ed25519')['private_key'],+ ]);+}++function assertMuxStops(Server $server, int $times): void+{+ Process::assertRanTimes(fn ($process) => str_contains($process->command, 'ssh -O stop')+ && str_contains($process->command, 'mux_'.$server->uuid), $times);+}++test('a key used by one or many active servers is in use', function () {+ serverForKey($this->privateKey);+ expect($this->privateKey->isInUse())->toBeTrue();++ serverForKey($this->privateKey);+ expect($this->privateKey->servers()->count())->toBe(2)+ ->and($this->privateKey->isInUse())->toBeTrue();+});++test('a key used only by soft-deleted servers is not in use and can be deleted', function () {+ serverForKey($this->privateKey, deleted: true);++ expect($this->privateKey->servers()->exists())->toBeFalse()+ ->and($this->privateKey->safeDelete())->toBeTrue()+ ->and(PrivateKey::query()->whereKey($this->privateKey->id)->exists())->toBeFalse();+});++test('an unreferenced key is not in use', function () {+ serverForKey(teamKey($this->team));++ expect($this->privateKey->isInUse())->toBeFalse();+});++test('a key with id 0 is matched like any other key', function () {+ $instanceKey = PrivateKey::factory()->make([+ 'team_id' => $this->team->id,+ 'private_key' => PrivateKey::generateNewKeyPair('ed25519')['private_key'],+ ]);+ $instanceKey->id = 0;+ $instanceKey->save();++ expect($instanceKey->isInUse())->toBeFalse();++ serverForKey($instanceKey);++ expect($instanceKey->isInUse())->toBeTrue()+ ->and($instanceKey->safeDelete())->toBeFalse();+});++test('a key without an id matches no servers', function () {+ serverForKey($this->privateKey);++ expect((new PrivateKey)->isInUse())->toBeFalse();++ refresh_server_connection(null);+ refresh_server_connection(new PrivateKey);++ Process::assertNothingRan();+});++test('refreshing connections stops the mux of every active server of the key only', function () {+ $first = serverForKey($this->privateKey);+ $second = serverForKey($this->privateKey);+ $deleted = serverForKey($this->privateKey, deleted: true);+ $other = serverForKey(teamKey($this->team));++ refresh_server_connection($this->privateKey);++ assertMuxStops($first, 1);+ assertMuxStops($second, 1);+ assertMuxStops($deleted, 0);+ assertMuxStops($other, 0);+});++test('changing the key content refreshes each server connection once', function () {+ $server = serverForKey($this->privateKey);+ $newKey = PrivateKey::generateNewKeyPair('ed25519')['private_key'];++ Livewire::test(Show::class, ['private_key_uuid' => $this->privateKey->uuid])+ ->set('privateKeyValue', $newKey)+ ->call('changePrivateKey')+ ->assertDispatched('success');++ expect($this->privateKey->fresh()->private_key)->toBe(formatPrivateKey($newKey));+ assertMuxStops($server, 1);+});++test('a team member cannot change a key used by servers', function () {+ $server = serverForKey($this->privateKey);+ $member = User::factory()->create();+ $this->team->members()->attach($member->id, ['role' => 'member']);+ $this->actingAs($member);++ Livewire::test(Show::class, ['private_key_uuid' => $this->privateKey->uuid])+ ->set('privateKeyValue', PrivateKey::generateNewKeyPair('ed25519')['private_key'])+ ->call('changePrivateKey');++ expect($this->privateKey->fresh()->private_key)->toBe($this->privateKey->private_key);+ assertMuxStops($server, 0);+});++test('the api refuses to delete a key used by an active server of the team', function () {+ serverForKey($this->privateKey);+ $this->withToken(teamToken($this->user, $this->team))+ ->deleteJson("/api/v1/security/keys/{$this->privateKey->uuid}")+ ->assertStatus(422);++ expect(PrivateKey::query()->whereKey($this->privateKey->id)->exists())->toBeTrue();+});++test('the api does not reveal keys of another team', function () {+ $otherKey = teamKey(Team::factory()->create());+ $this->withToken(teamToken($this->user, $this->team))+ ->deleteJson("/api/v1/security/keys/{$otherKey->uuid}")+ ->assertNotFound();++ expect(PrivateKey::query()->whereKey($otherKey->id)->exists())->toBeTrue();+});