An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(env): generate encoded secrets from raw random bytes
Andras Bacsaic6ac52dc3880
diff --git a/bootstrap/helpers/shared.php b/bootstrap/helpers/shared.phpindex 06c6f4d5cf..860b550dd3 100644--- a/bootstrap/helpers/shared.php+++ b/bootstrap/helpers/shared.php@@ -1400,23 +1400,23 @@ function generateEnvValue(string $command, Service|Application|null $service = nbreak;// This is base64,case 'REALBASE64_64':- $generatedValue = base64_encode(Str::random(64));+ $generatedValue = base64_encode(random_bytes(64));break;case 'REALBASE64_128':- $generatedValue = base64_encode(Str::random(128));+ $generatedValue = base64_encode(random_bytes(128));break;case 'REALBASE64':case 'REALBASE64_32':- $generatedValue = base64_encode(Str::random(32));+ $generatedValue = base64_encode(random_bytes(32));break;case 'HEX_32':- $generatedValue = bin2hex(Str::random(16));+ $generatedValue = bin2hex(random_bytes(16));break;case 'HEX_64':- $generatedValue = bin2hex(Str::random(32));+ $generatedValue = bin2hex(random_bytes(32));break;case 'HEX_128':- $generatedValue = bin2hex(Str::random(64));+ $generatedValue = bin2hex(random_bytes(64));break;case 'USER':$generatedValue = Str::random(16);diff --git a/tests/Unit/GenerateEnvValueTest.php b/tests/Unit/GenerateEnvValueTest.phpnew file mode 100644index 0000000000..7e7755f4dd--- /dev/null+++ b/tests/Unit/GenerateEnvValueTest.php@@ -0,0 +1,29 @@+<?php++test('hex magic variables generate valid hex strings with expected lengths', function (string $command, int $expectedLength) {+ $value = generateEnvValue($command);++ expect($value)+ ->toBeString()+ ->toMatch('/^[0-9a-f]+$/');++ expect(strlen($value))->toBe($expectedLength);+})->with([+ 'HEX_32' => ['HEX_32', 32],+ 'HEX_64' => ['HEX_64', 64],+ 'HEX_128' => ['HEX_128', 128],+]);++test('real base64 magic variables generate valid base64 strings from expected byte lengths', function (string $command, int $expectedBytes) {+ $value = generateEnvValue($command);+ $decodedValue = base64_decode($value, true);++ expect($value)->toBeString();+ expect($decodedValue)->not->toBeFalse();+ expect(strlen($decodedValue))->toBe($expectedBytes);+})->with([+ 'REALBASE64' => ['REALBASE64', 32],+ 'REALBASE64_32' => ['REALBASE64_32', 32],+ 'REALBASE64_64' => ['REALBASE64_64', 64],+ 'REALBASE64_128' => ['REALBASE64_128', 128],+]);