Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(ui): keep sponsorship reminder listeners functional

Andras Bacsaid67d42039a82
diff --git a/resources/views/livewire/layout-popups.blade.php b/resources/views/livewire/layout-popups.blade.php
index 199774c3c9..693c332d95 100644
--- a/resources/views/livewire/layout-popups.blade.php
+++ b/resources/views/livewire/layout-popups.blade.php
@@ -86,7 +86,7 @@
return isDifferentMonth;
{{-- } --}}
}
-}" @show-sponsorship-reminder.window="popups.sponsorship = true; reminders.sponsorship.compact = false">
+}" x-on:show-sponsorship-reminder.window="popups.sponsorship = true; reminders.sponsorship.compact = false">
@auth
<span x-show="popups.realtime === true">
@if (!isCloud())
@@ -145,7 +145,7 @@
<x-popup>
<x-slot:customActions>
<div class="relative mx-auto flex w-full flex-col overflow-hidden rounded-2xl border border-neutral-200 bg-white shadow-modal transition-all duration-300 dark:border-white/[0.1] dark:bg-surface"
- @show-sponsorship-reminder.window="bannerVisible = true"
+ x-on:show-sponsorship-reminder.window="bannerVisible = true"
:class="reminders.sponsorship.compact ? 'max-w-sm gap-3 p-4' : 'max-w-2xl gap-5 p-5 sm:p-6'">
<button type="button" aria-label="Dismiss sponsorship reminder"
class="absolute top-3 right-3 flex size-7 items-center justify-center rounded-full text-neutral-400 transition-colors hover:bg-neutral-100 hover:text-black dark:text-fg-faint dark:hover:bg-white/[0.07] dark:hover:text-fg"
diff --git a/tests/Feature/LayoutPopupsUiTest.php b/tests/Feature/LayoutPopupsUiTest.php
index 3744732817..d405268d02 100644
--- a/tests/Feature/LayoutPopupsUiTest.php
+++ b/tests/Feature/LayoutPopupsUiTest.php
@@ -42,8 +42,17 @@ test('sponsorship reminder is disabled in development', function () {
expect($view)
->toContain('this.popups.sponsorship = !this.isDevelopment && this.shouldShowMonthlyPopup')
- ->toContain('@show-sponsorship-reminder.window="popups.sponsorship = true')
- ->toContain('@show-sponsorship-reminder.window="bannerVisible = true"');
+ ->toContain('x-on:show-sponsorship-reminder.window="popups.sponsorship = true')
+ ->toContain('x-on:show-sponsorship-reminder.window="bannerVisible = true"');
+});
+
+test('sponsorship reminder listener is not parsed as a blade directive', function () {
+ $view = file_get_contents(resource_path('views/livewire/layout-popups.blade.php'));
+ $compiledView = Blade::compileString($view);
+
+ expect($compiledView)
+ ->toContain('x-on:show-sponsorship-reminder.window=')
+ ->not->toContain('$__env->yieldSection()');
});
test('advanced settings provides a development-only sponsorship reminder preview', function () {