An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
fix(database): gate import form controls by update access
Andras Bacsaieb7da5c08234
diff --git a/resources/views/livewire/project/database/import-form.blade.php b/resources/views/livewire/project/database/import-form.blade.phpindex ae74e0cbd7..1e384ac8d1 100644--- a/resources/views/livewire/project/database/import-form.blade.php+++ b/resources/views/livewire/project/database/import-form.blade.php@@ -58,9 +58,9 @@@if ($resourceDbType === 'standalone-postgresql')@if ($dumpAll)<x-forms.textarea rows="6" readonly label="Custom Import Command"- wire:model='restoreCommandText'></x-forms.textarea>+ wire:model='restoreCommandText' canGate="update" :canResource="$this->resource"></x-forms.textarea>@else- <x-forms.input label="Custom Import Command" wire:model='postgresqlRestoreCommand'></x-forms.input>+ <x-forms.input label="Custom Import Command" wire:model='postgresqlRestoreCommand' canGate="update" :canResource="$this->resource"></x-forms.input><div class="flex flex-col gap-1 pt-1"><span class="text-xs">You can add "--clean" to drop objects before creating them, avoidingconflicts.</span>@@ -68,27 +68,27 @@</div>@endif<div class="w-64 pt-2">- <x-forms.checkbox label="Backup includes all databases" wire:model.live='dumpAll'></x-forms.checkbox>+ <x-forms.checkbox label="Backup includes all databases" wire:model.live='dumpAll' canGate="update" :canResource="$this->resource"></x-forms.checkbox></div>@elseif ($resourceDbType === 'standalone-mysql')@if ($dumpAll)<x-forms.textarea rows="14" readonly label="Custom Import Command"- wire:model='restoreCommandText'></x-forms.textarea>+ wire:model='restoreCommandText' canGate="update" :canResource="$this->resource"></x-forms.textarea>@else- <x-forms.input label="Custom Import Command" wire:model='mysqlRestoreCommand'></x-forms.input>+ <x-forms.input label="Custom Import Command" wire:model='mysqlRestoreCommand' canGate="update" :canResource="$this->resource"></x-forms.input>@endif<div class="w-64 pt-2">- <x-forms.checkbox label="Backup includes all databases" wire:model.live='dumpAll'></x-forms.checkbox>+ <x-forms.checkbox label="Backup includes all databases" wire:model.live='dumpAll' canGate="update" :canResource="$this->resource"></x-forms.checkbox></div>@elseif ($resourceDbType === 'standalone-mariadb')@if ($dumpAll)<x-forms.textarea rows="14" readonly label="Custom Import Command"- wire:model='restoreCommandText'></x-forms.textarea>+ wire:model='restoreCommandText' canGate="update" :canResource="$this->resource"></x-forms.textarea>@else- <x-forms.input label="Custom Import Command" wire:model='mariadbRestoreCommand'></x-forms.input>+ <x-forms.input label="Custom Import Command" wire:model='mariadbRestoreCommand' canGate="update" :canResource="$this->resource"></x-forms.input>@endif<div class="w-64 pt-2">- <x-forms.checkbox label="Backup includes all databases" wire:model.live='dumpAll'></x-forms.checkbox>+ <x-forms.checkbox label="Backup includes all databases" wire:model.live='dumpAll' canGate="update" :canResource="$this->resource"></x-forms.checkbox></div>@endif@@ -128,8 +128,8 @@<h3>Backup File</h3><form class="flex gap-2 items-end pt-2"><x-forms.input label="Location of the backup file on the server" placeholder="e.g. /home/user/backup.sql.gz"- wire:model='customLocation' x-model="$wire.customLocation"></x-forms.input>- <x-forms.button class="w-full" wire:click='checkFile' x-bind:disabled="!$wire.customLocation">Check File</x-forms.button>+ wire:model='customLocation' x-model="$wire.customLocation" canGate="update" :canResource="$this->resource"></x-forms.input>+ <x-forms.button class="w-full" wire:click='checkFile' x-bind:disabled="!$wire.customLocation" canGate="update" :canResource="$this->resource">Check File</x-forms.button></form><div class="pt-2 text-center text-xl font-bold">Or@@ -168,7 +168,7 @@<div x-show="restoreType === 's3'" class="pt-6"><h3>Restore from S3</h3><div class="flex flex-col gap-2 pt-2">- <x-forms.select label="S3 Storage" wire:model.live="s3StorageId">+ <x-forms.select label="S3 Storage" wire:model.live="s3StorageId" canGate="update" :canResource="$this->resource"><option value="">Select S3 Storage</option>@foreach ($availableS3Storages as $storage)<option value="{{ $storage['id'] }}">{{ $storage['name'] }}@@ -182,10 +182,10 @@<x-forms.input label="S3 File Path (within bucket)"helper="Path to the backup file in your S3 bucket, e.g., /backups/database-2025-01-15.gz"placeholder="/backups/database-backup.gz" wire:model.blur='s3Path'- wire:keydown.enter='checkS3File'></x-forms.input>+ wire:keydown.enter='checkS3File' canGate="update" :canResource="$this->resource"></x-forms.input><div class="flex gap-2">- <x-forms.button class="w-full" wire:click='checkS3File' x-bind:disabled="!s3StorageId || !s3Path">+ <x-forms.button class="w-full" wire:click='checkS3File' x-bind:disabled="!s3StorageId || !s3Path" canGate="update" :canResource="$this->resource">Check File</x-forms.button></div>diff --git a/tests/Feature/DatabaseImportFormAuthorizationTest.php b/tests/Feature/DatabaseImportFormAuthorizationTest.phpnew file mode 100644index 0000000000..935700e3a4--- /dev/null+++ b/tests/Feature/DatabaseImportFormAuthorizationTest.php@@ -0,0 +1,20 @@+<?php++it('declares explicit authorization on database import form controls', function () {+ $view = file_get_contents(resource_path('views/livewire/project/database/import-form.blade.php'));++ preg_match_all(+ '/<x-forms\.(button|input|select|checkbox|textarea)\b[^>]*>/s',+ $view,+ $matches,+ PREG_OFFSET_CAPTURE+ );++ $missingAuthorization = collect($matches[0])+ ->filter(fn (array $match): bool => ! str_contains($match[0], 'canGate=') || ! str_contains($match[0], 'canResource='))+ ->map(fn (array $match): string => 'Line '.(substr_count(substr($view, 0, $match[1]), PHP_EOL) + 1).': '.trim(preg_replace('/\s+/', ' ', $match[0])))+ ->values()+ ->all();++ expect($missingAuthorization)->toBeEmpty();+});