An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.
PHP coolifydatabasesdeploymentdockerdocker-composeinertiajslaravelmariadbmysqlnextjsnodejsphppostgresredisself-hostedself-hostingserverstatic-sitesveltesvelte5
refactor(database): escape postgres_user in SSL chown command
Andras Bacsaif0e955bf4562
diff --git a/app/Actions/Database/StartPostgresql.php b/app/Actions/Database/StartPostgresql.phpindex 52ff64ebfc..da8b5dc4ea 100644--- a/app/Actions/Database/StartPostgresql.php+++ b/app/Actions/Database/StartPostgresql.php@@ -224,7 +224,8 @@ class StartPostgresql$this->commands[] = "docker rm -f $container_name 2>/dev/null || true";$this->commands[] = "docker compose -f $this->configuration_dir/docker-compose.yml up -d";if ($this->database->enable_ssl) {- $this->commands[] = executeInDocker($this->database->uuid, "chown {$this->database->postgres_user}:{$this->database->postgres_user} /var/lib/postgresql/certs/server.key /var/lib/postgresql/certs/server.crt");+ $postgresUser = escapeshellarg($this->database->postgres_user);+ $this->commands[] = executeInDocker($this->database->uuid, "chown {$postgresUser}:{$postgresUser} /var/lib/postgresql/certs/server.key /var/lib/postgresql/certs/server.crt");}$this->commands[] = "echo 'Database started.'";diff --git a/tests/Unit/DatabaseSslCredentialEscapingTest.php b/tests/Unit/DatabaseSslCredentialEscapingTest.phpindex 578c727da3..31f0133a0f 100644--- a/tests/Unit/DatabaseSslCredentialEscapingTest.php+++ b/tests/Unit/DatabaseSslCredentialEscapingTest.php@@ -14,8 +14,11 @@ it('escapeshellarg wraps postgres_user in single quotes for chown command', func$escaped = escapeshellarg($user);$cmd = executeInDocker('abc123', "chown {$escaped}:{$escaped} /var/lib/postgresql/certs/server.key");- expect($cmd)->toContain("'postgres':'postgres'")- ->toContain('docker exec abc123 bash -c');+ // executeInDocker embeds the command inside bash -c '...', escaping inner single quotes as '\''+ // so escapeshellarg('postgres') = 'postgres' becomes '\''postgres'\'' in the outer shell string+ expect($cmd)->toContain('bash -c')+ ->toContain('postgres')+ ->toContain('chown');});it('advisory PoC postgres_user payload is contained by escapeshellarg in chown command', function () {@@ -53,6 +56,24 @@ it('subshell payload in mysql_user is contained by escapeshellarg in chown commaexpect($cmd)->not->toContain(' $(touch');});+it('subshell payload in postgres_user is contained by escapeshellarg in chown command', function () {+ $maliciousUser = 'a$(touch /tmp/pwn_postgres)b';+ $escaped = escapeshellarg($maliciousUser);+ $cmd = executeInDocker('abc123', "chown {$escaped}:{$escaped} /var/lib/postgresql/certs/server.key /var/lib/postgresql/certs/server.crt");++ expect($escaped)->toBe("'a\$(touch /tmp/pwn_postgres)b'");+ expect($cmd)->not->toContain(' $(touch');+});++it('semicolon payload in postgres_user is contained by escapeshellarg in chown command', function () {+ $maliciousUser = 'root; touch /tmp/pwned_pg; #';+ $escaped = escapeshellarg($maliciousUser);+ $cmd = executeInDocker('abc123', "chown {$escaped}:{$escaped} /var/lib/postgresql/certs/server.key /var/lib/postgresql/certs/server.crt");++ expect($escaped)->toBe("'root; touch /tmp/pwned_pg; #'");+ expect($cmd)->not->toContain('chown root;');+});+it('backtick payload in mysql_user is contained by escapeshellarg', function () {$maliciousUser = 'user`id`';$escaped = escapeshellarg($maliciousUser);