Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

Fix Vultr power controls for stopped instances

Cornelis Terblanchef7150a1d6c9d
diff --git a/app/Services/VultrService.php b/app/Services/VultrService.php
index b6d2494b63..6e1559f98a 100644
--- a/app/Services/VultrService.php
+++ b/app/Services/VultrService.php
@@ -31,7 +31,7 @@ class VultrService
throw new \Exception('Vultr API error: '.$response->json('error', 'Unknown error'), $response->status());
}
- return $response->json();
+ return $response->json() ?? [];
}
private function requestPaginated(string $endpoint, string $resourceKey, array $data = []): array
diff --git a/resources/views/livewire/server/show.blade.php b/resources/views/livewire/server/show.blade.php
index 7db1c8df3e..e9a27eb393 100644
--- a/resources/views/livewire/server/show.blade.php
+++ b/resources/views/livewire/server/show.blade.php
@@ -140,7 +140,7 @@
</svg>
</button>
</div>
- @if ($server->cloudProviderToken && !$server->isFunctional() && $vultrInstanceStatus === 'stopped')
+ @if ($server->cloudProviderToken && $vultrInstanceStatus === 'stopped')
<x-forms.button wire:click.prevent='startVultrInstance' isHighlighted canGate="update"
:canResource="$server">
Power On
diff --git a/tests/Feature/VultrServerLifecycleTest.php b/tests/Feature/VultrServerLifecycleTest.php
index e1b72a7f75..c89ca47b45 100644
--- a/tests/Feature/VultrServerLifecycleTest.php
+++ b/tests/Feature/VultrServerLifecycleTest.php
@@ -236,6 +236,23 @@ it('blocks action validation when Vultr instance is stopped', function () {
]);
});
+it('shows Vultr power on button when stopped even if server was previously functional', function () {
+ $this->server->update([
+ 'ip' => '1.2.3.5',
+ 'vultr_instance_status' => 'stopped',
+ ]);
+ $this->server->settings->update([
+ 'is_reachable' => true,
+ 'is_usable' => true,
+ 'force_disabled' => false,
+ ]);
+
+ expect($this->server->fresh()->isFunctional())->toBeTrue();
+
+ Livewire::test(Show::class, ['server_uuid' => $this->server->uuid])
+ ->assertSee('Power On');
+});
+
it('starts a Vultr instance', function () {
Http::fake([
'https://api.vultr.com/v2/instances/instance-1/start' => Http::response([], 204),
diff --git a/tests/Unit/VultrServiceTest.php b/tests/Unit/VultrServiceTest.php
index 8fa27eb541..67f13f5a3c 100644
--- a/tests/Unit/VultrServiceTest.php
+++ b/tests/Unit/VultrServiceTest.php
@@ -136,3 +136,17 @@ it('finds an instance by IPv4 or IPv6', function () {
->and($service->findInstanceByIp('2001:db8::1')['id'])->toBe('instance-1')
->and($service->findInstanceByIp('1.2.3.4'))->toBeNull();
});
+
+it('handles empty successful responses from Vultr API', function () {
+ Http::fake([
+ 'https://api.vultr.com/v2/instances/instance-1/start' => Http::response(null, 204),
+ 'https://api.vultr.com/v2/instances/instance-1' => Http::response(null, 204),
+ ]);
+
+ $service = new VultrService('fake-token');
+
+ expect($service->startInstance('instance-1'))->toBe([]);
+ $service->deleteInstance('instance-1');
+
+ Http::assertSentCount(2);
+});