Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix: improve team resource route handling

Andras Bacsaifb2d477e4876
diff --git a/app/Http/Middleware/CanUpdateResource.php b/app/Http/Middleware/CanUpdateResource.php
index 372af44989..3b28ee07cf 100644
--- a/app/Http/Middleware/CanUpdateResource.php
+++ b/app/Http/Middleware/CanUpdateResource.php
@@ -5,6 +5,7 @@ namespace App\Http\Middleware;
use App\Models\Application;
use App\Models\Environment;
use App\Models\Project;
+use App\Models\Server;
use App\Models\Service;
use App\Models\ServiceApplication;
use App\Models\ServiceDatabase;
@@ -23,53 +24,61 @@ use Symfony\Component\HttpFoundation\Response;
class CanUpdateResource
{
+ /**
+ * @var array<string, list<class-string>>
+ */
+ private const ROUTE_RESOURCE_MODELS = [
+ 'application_uuid' => [Application::class],
+ 'database_uuid' => [
+ StandalonePostgresql::class,
+ StandaloneMysql::class,
+ StandaloneMariadb::class,
+ StandaloneRedis::class,
+ StandaloneKeydb::class,
+ StandaloneDragonfly::class,
+ StandaloneClickhouse::class,
+ StandaloneMongodb::class,
+ ],
+ 'stack_service_uuid' => [ServiceApplication::class, ServiceDatabase::class],
+ 'service_uuid' => [Service::class],
+ 'server_uuid' => [Server::class],
+ 'environment_uuid' => [Environment::class],
+ 'project_uuid' => [Project::class],
+ ];
+
public function handle(Request $request, Closure $next): Response
{
+ $resource = $this->resourceFromRoute($request);
+
+ if (! $resource) {
+ abort(404, 'Resource not found.');
+ }
+
+ if (! Gate::allows('update', $resource)) {
+ abort(403, 'You do not have permission to update this resource.');
+ }
+
return $next($request);
+ }
- // Get resource from route parameters
- // $resource = null;
- // if ($request->route('application_uuid')) {
- // $resource = Application::where('uuid', $request->route('application_uuid'))->first();
- // } elseif ($request->route('service_uuid')) {
- // $resource = Service::where('uuid', $request->route('service_uuid'))->first();
- // } elseif ($request->route('stack_service_uuid')) {
- // // Handle ServiceApplication or ServiceDatabase
- // $stack_service_uuid = $request->route('stack_service_uuid');
- // $resource = ServiceApplication::where('uuid', $stack_service_uuid)->first() ??
- // ServiceDatabase::where('uuid', $stack_service_uuid)->first();
- // } elseif ($request->route('database_uuid')) {
- // // Try different database types
- // $database_uuid = $request->route('database_uuid');
- // $resource = StandalonePostgresql::where('uuid', $database_uuid)->first() ??
- // StandaloneMysql::where('uuid', $database_uuid)->first() ??
- // StandaloneMariadb::where('uuid', $database_uuid)->first() ??
- // StandaloneRedis::where('uuid', $database_uuid)->first() ??
- // StandaloneKeydb::where('uuid', $database_uuid)->first() ??
- // StandaloneDragonfly::where('uuid', $database_uuid)->first() ??
- // StandaloneClickhouse::where('uuid', $database_uuid)->first() ??
- // StandaloneMongodb::where('uuid', $database_uuid)->first();
- // } elseif ($request->route('server_uuid')) {
- // // For server routes, check if user can manage servers
- // if (! auth()->user()->isAdmin()) {
- // abort(403, 'You do not have permission to access this resource.');
- // }
+ private function resourceFromRoute(Request $request): ?object
+ {
+ foreach (self::ROUTE_RESOURCE_MODELS as $routeParameter => $models) {
+ $uuid = $request->route($routeParameter);
- // return $next($request);
- // } elseif ($request->route('environment_uuid')) {
- // $resource = Environment::where('uuid', $request->route('environment_uuid'))->first();
- // } elseif ($request->route('project_uuid')) {
- // $resource = Project::ownedByCurrentTeam()->where('uuid', $request->route('project_uuid'))->first();
- // }
+ if (! $uuid) {
+ continue;
+ }
- // if (! $resource) {
- // abort(404, 'Resource not found.');
- // }
+ foreach ($models as $model) {
+ $resource = $model::where('uuid', $uuid)->first();
- // if (! Gate::allows('update', $resource)) {
- // abort(403, 'You do not have permission to update this resource.');
- // }
+ if ($resource) {
+ return $resource;
+ }
+ }
+ }
- // return $next($request);
+ return null;
}
}
diff --git a/app/Policies/TeamPolicy.php b/app/Policies/TeamPolicy.php
index 849e23751f..cc7745b648 100644
--- a/app/Policies/TeamPolicy.php
+++ b/app/Policies/TeamPolicy.php
@@ -37,12 +37,11 @@ class TeamPolicy
*/
public function update(User $user, Team $team): bool
{
- // Only admins and owners can update team settings
if (! $user->teams->contains('id', $team->id)) {
return false;
}
- return $user->isAdmin() || $user->isOwner();
+ return $user->isAdminOfTeam($team->id);
}
/**
@@ -50,12 +49,11 @@ class TeamPolicy
*/
public function delete(User $user, Team $team): bool
{
- // Only admins and owners can delete teams
if (! $user->teams->contains('id', $team->id)) {
return false;
}
- return $user->isAdmin() || $user->isOwner();
+ return $user->isAdminOfTeam($team->id);
}
/**
@@ -63,12 +61,11 @@ class TeamPolicy
*/
public function manageMembers(User $user, Team $team): bool
{
- // Only admins and owners can manage team members
if (! $user->teams->contains('id', $team->id)) {
return false;
}
- return $user->isAdmin() || $user->isOwner();
+ return $user->isAdminOfTeam($team->id);
}
/**
@@ -76,12 +73,11 @@ class TeamPolicy
*/
public function viewAdmin(User $user, Team $team): bool
{
- // Only admins and owners can view admin panel
if (! $user->teams->contains('id', $team->id)) {
return false;
}
- return $user->isAdmin() || $user->isOwner();
+ return $user->isAdminOfTeam($team->id);
}
/**
@@ -89,11 +85,10 @@ class TeamPolicy
*/
public function manageInvitations(User $user, Team $team): bool
{
- // Only admins and owners can manage invitations
if (! $user->teams->contains('id', $team->id)) {
return false;
}
- return $user->isAdmin() || $user->isOwner();
+ return $user->isAdminOfTeam($team->id);
}
}
diff --git a/tests/Feature/Authorization/ApplicationConfigAuthorizationTest.php b/tests/Feature/Authorization/ApplicationConfigAuthorizationTest.php
new file mode 100644
index 0000000000..31c30c1245
--- /dev/null
+++ b/tests/Feature/Authorization/ApplicationConfigAuthorizationTest.php
@@ -0,0 +1,245 @@
+<?php
+
+use App\Livewire\Project\Application\Advanced as ApplicationAdvanced;
+use App\Livewire\Project\Application\Heading as ApplicationHeading;
+use App\Livewire\Project\Application\Rollback as ApplicationRollback;
+use App\Models\Application;
+use App\Models\InstanceSettings;
+use App\Models\Project;
+use App\Models\Server;
+use App\Models\StandaloneDocker;
+use App\Models\Team;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Support\Facades\DB;
+use Illuminate\Support\Str;
+use Livewire\Livewire;
+
+uses(RefreshDatabase::class);
+
+beforeEach(function () {
+ $this->withoutVite();
+
+ InstanceSettings::unguarded(fn () => InstanceSettings::updateOrCreate(['id' => 0], ['id' => 0]));
+
+ $this->team = Team::factory()->create();
+
+ $this->admin = User::factory()->create();
+ $this->admin->teams()->attach($this->team, ['role' => 'admin']);
+
+ $this->member = User::factory()->create();
+ $this->member->teams()->attach($this->team, ['role' => 'member']);
+
+ $keyId = DB::table('private_keys')->insertGetId([
+ 'uuid' => (string) Str::uuid(),
+ 'name' => 'Test Key',
+ 'private_key' => 'test-key',
+ 'team_id' => $this->team->id,
+ 'created_at' => now(),
+ 'updated_at' => now(),
+ ]);
+
+ $this->server = Server::factory()->create([
+ 'team_id' => $this->team->id,
+ 'private_key_id' => $keyId,
+ ]);
+
+ $this->server->settings()->update([
+ 'is_reachable' => true,
+ 'is_usable' => true,
+ ]);
+
+ StandaloneDocker::withoutEvents(function () {
+ $this->destination = StandaloneDocker::firstOrCreate(
+ ['server_id' => $this->server->id, 'network' => 'coolify'],
+ ['uuid' => (string) Str::uuid(), 'name' => 'test-docker']
+ );
+ });
+
+ $this->project = Project::create([
+ 'uuid' => (string) Str::uuid(),
+ 'name' => 'Test Project',
+ 'team_id' => $this->team->id,
+ ]);
+
+ $this->environment = $this->project->environments()->first();
+
+ $this->application = Application::factory()->create([
+ 'uuid' => (string) Str::uuid(),
+ 'name' => 'Test App',
+ 'environment_id' => $this->environment->id,
+ 'destination_id' => $this->destination->id,
+ 'destination_type' => $this->destination->getMorphClass(),
+ 'status' => 'running',
+ ]);
+});
+
+// --- Application Policy: view ---
+
+test('admin can view application', function () {
+ expect($this->admin->can('view', $this->application))->toBeTrue();
+});
+
+test('member can view application', function () {
+ expect($this->member->can('view', $this->application))->toBeTrue();
+});
+
+// --- Application Policy: update ---
+
+test('admin can update application', function () {
+ expect($this->admin->can('update', $this->application))->toBeTrue();
+});
+
+test('member cannot update application', function () {
+ expect($this->member->can('update', $this->application))->toBeFalse();
+});
+
+// --- Application Policy: deploy ---
+
+test('admin can deploy application', function () {
+ expect($this->admin->can('deploy', $this->application))->toBeTrue();
+});
+
+test('member cannot deploy application', function () {
+ expect($this->member->can('deploy', $this->application))->toBeFalse();
+});
+
+// --- Application Policy: delete ---
+
+test('admin can delete application', function () {
+ expect($this->admin->can('delete', $this->application))->toBeTrue();
+});
+
+test('member cannot delete application', function () {
+ expect($this->member->can('delete', $this->application))->toBeFalse();
+});
+
+// --- Application Policy: manageEnvironment ---
+
+test('admin can manage application environment', function () {
+ expect($this->admin->can('manageEnvironment', $this->application))->toBeTrue();
+});
+
+test('member cannot manage application environment', function () {
+ expect($this->member->can('manageEnvironment', $this->application))->toBeFalse();
+});
+
+// --- Application Heading Livewire actions ---
+
+test('member cannot call deploy on application heading', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationHeading::class, ['application' => $this->application])
+ ->call('deploy')
+ ->assertDispatched('error');
+});
+
+test('member cannot call restart on application heading', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationHeading::class, ['application' => $this->application])
+ ->call('restart')
+ ->assertDispatched('error');
+});
+
+test('member cannot call stop on application heading', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationHeading::class, ['application' => $this->application])
+ ->call('stop')
+ ->assertDispatched('error');
+});
+
+test('member cannot call force deploy on application heading', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationHeading::class, ['application' => $this->application])
+ ->call('force_deploy_without_cache')
+ ->assertDispatched('error');
+});
+
+// --- Application General policy (Livewire mount requires full app data) ---
+
+test('member cannot update application general settings', function () {
+ expect($this->member->can('update', $this->application))->toBeFalse();
+});
+
+// --- Application Advanced Livewire actions ---
+
+test('member cannot save application advanced settings', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationAdvanced::class, ['application' => $this->application])
+ ->call('instantSave')
+ ->assertDispatched('error');
+});
+
+test('member cannot submit application advanced settings', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationAdvanced::class, ['application' => $this->application])
+ ->call('submit')
+ ->assertDispatched('error');
+});
+
+// --- Application Rollback Livewire actions ---
+
+test('member cannot save rollback settings', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationRollback::class, ['application' => $this->application])
+ ->call('saveSettings')
+ ->assertDispatched('error');
+});
+
+test('member cannot rollback image', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationRollback::class, ['application' => $this->application])
+ ->call('rollbackImage', 'test-image:latest')
+ ->assertForbidden();
+});
+
+// --- Application Heading visibility ---
+
+test('member does not see terminal link for application', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationHeading::class, ['application' => $this->application])
+ ->assertDontSee('Terminal');
+});
+
+test('admin sees terminal link for application', function () {
+ $this->actingAs($this->admin);
+ session(['currentTeam' => $this->team]);
+
+ Livewire::test(ApplicationHeading::class, ['application' => $this->application])
+ ->assertSee('Terminal');
+});
+
+// --- Cross-team isolation ---
+
+test('user from different team cannot view application', function () {
+ $otherTeam = Team::factory()->create();
+ $otherUser = User::factory()->create();
+ $otherUser->teams()->attach($otherTeam, ['role' => 'admin']);
+
+ expect($otherUser->can('view', $this->application))->toBeFalse();
+});
+
+test('user from different team cannot update application', function () {
+ $otherTeam = Team::factory()->create();
+ $otherUser = User::factory()->create();
+ $otherUser->teams()->attach($otherTeam, ['role' => 'admin']);
+
+ expect($otherUser->can('update', $this->application))->toBeFalse();
+});
diff --git a/tests/Feature/Authorization/CanUpdateResourceMiddlewareTest.php b/tests/Feature/Authorization/CanUpdateResourceMiddlewareTest.php
new file mode 100644
index 0000000000..4d440b41a9
--- /dev/null
+++ b/tests/Feature/Authorization/CanUpdateResourceMiddlewareTest.php
@@ -0,0 +1,89 @@
+<?php
+
+use App\Http\Middleware\CanUpdateResource;
+use App\Models\InstanceSettings;
+use App\Models\Project;
+use App\Models\Server;
+use App\Models\Team;
+use App\Models\User;
+use Illuminate\Foundation\Testing\RefreshDatabase;
+use Illuminate\Http\Request;
+use Symfony\Component\HttpKernel\Exception\HttpException;
+use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
+
+uses(RefreshDatabase::class);
+
+function requestWithCanUpdateResourceRouteParameter(string $parameter, ?string $value): Request
+{
+ $parameters = [
+ 'application_uuid' => null,
+ 'database_uuid' => null,
+ 'stack_service_uuid' => null,
+ 'service_uuid' => null,
+ 'server_uuid' => null,
+ 'environment_uuid' => null,
+ 'project_uuid' => null,
+ $parameter => $value,
+ ];
+
+ $request = Mockery::mock(Request::class)->makePartial();
+ $request->shouldReceive('route')->andReturnUsing(fn (string $key): ?string => $parameters[$key] ?? null);
+
+ return $request;
+}
+
+beforeEach(function () {
+ InstanceSettings::unguarded(fn () => InstanceSettings::updateOrCreate(['id' => 0], ['id' => 0]));
+
+ $this->team = Team::factory()->create();
+ $this->project = Project::factory()->create(['team_id' => $this->team->id]);
+ $this->server = Server::factory()->create(['team_id' => $this->team->id]);
+
+ $this->admin = User::factory()->create();
+ $this->admin->teams()->attach($this->team, ['role' => 'admin']);
+
+ $this->member = User::factory()->create();
+ $this->member->teams()->attach($this->team, ['role' => 'member']);
+});
+
+it('blocks members from update-only project routes before the page renders', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ (new CanUpdateResource)->handle(
+ requestWithCanUpdateResourceRouteParameter('project_uuid', $this->project->uuid),
+ fn () => response('ok')
+ );
+})->throws(HttpException::class, 'You do not have permission to update this resource.');
+
+it('allows admins through update-only project routes', function () {
+ $this->actingAs($this->admin);
+ session(['currentTeam' => $this->team]);
+
+ $response = (new CanUpdateResource)->handle(
+ requestWithCanUpdateResourceRouteParameter('project_uuid', $this->project->uuid),
+ fn () => response('ok')
+ );
+
+ expect($response->getContent())->toBe('ok');
+});
+
+it('blocks members from update-only server routes before the page renders', function () {
+ $this->actingAs($this->member);
+ session(['currentTeam' => $this->team]);
+
+ (new CanUpdateResource)->handle(
+ requestWithCanUpdateResourceRouteParameter('server_uuid', $this->server->uuid),
+ fn () => response('ok')
+ );
+})->throws(HttpException::class, 'You do not have permission to update this resource.');
+
+it('returns not found when an update-only route references an unknown resource', function () {
+ $this->actingAs($this->admin);
+ session(['currentTeam' => $this->team]);
+
+ (new CanUpdateResource)->handle(
+ requestWithCanUpdateResourceRouteParameter('project_uuid', 'not-a-project'),
+ fn () => response('ok')
+ );
+})->throws(NotFoundHttpException::class, 'Resource not found.');
diff --git a/tests/Unit/Policies/TeamPolicyTest.php b/tests/Unit/Policies/TeamPolicyTest.php
new file mode 100644
index 0000000000..3b341d4888
--- /dev/null
+++ b/tests/Unit/Policies/TeamPolicyTest.php
@@ -0,0 +1,92 @@
+<?php
+
+use App\Models\Team;
+use App\Models\User;
+use App\Policies\TeamPolicy;
+
+function teamPolicyUserWithTeams(array $teamIds): User
+{
+ $user = Mockery::mock(User::class)->makePartial();
+ $user->shouldReceive('getAttribute')->with('teams')->andReturn(collect(
+ array_map(fn (int $teamId): object => (object) ['id' => $teamId], $teamIds)
+ ));
+
+ return $user;
+}
+
+function teamPolicyTeam(int $teamId): Team
+{
+ $team = Mockery::mock(Team::class)->makePartial();
+ $team->shouldReceive('getAttribute')->with('id')->andReturn($teamId);
+
+ return $team;
+}
+
+it('allows any authenticated user to view any teams list', function () {
+ $user = Mockery::mock(User::class)->makePartial();
+
+ expect((new TeamPolicy)->viewAny($user))->toBeTrue();
+});
+
+it('allows authenticated users to create teams', function () {
+ $user = Mockery::mock(User::class)->makePartial();
+
+ expect((new TeamPolicy)->create($user))->toBeTrue();
+});
+
+it('allows target team members to view the team', function () {
+ $user = teamPolicyUserWithTeams([1]);
+ $team = teamPolicyTeam(1);
+
+ expect((new TeamPolicy)->view($user, $team))->toBeTrue();
+});
+
+it('denies non-members from viewing the team', function () {
+ $user = teamPolicyUserWithTeams([2]);
+ $team = teamPolicyTeam(1);
+
+ expect((new TeamPolicy)->view($user, $team))->toBeFalse();
+});
+
+it('allows target team admins to perform privileged team actions', function (string $ability) {
+ $user = teamPolicyUserWithTeams([1]);
+ $user->shouldReceive('isAdminOfTeam')->with(1)->andReturn(true);
+ $team = teamPolicyTeam(1);
+
+ expect((new TeamPolicy)->{$ability}($user, $team))->toBeTrue();
+})->with([
+ 'update',
+ 'delete',
+ 'manageMembers',
+ 'viewAdmin',
+ 'manageInvitations',
+]);
+
+it('denies target team members even when their current session role is admin elsewhere', function (string $ability) {
+ $user = teamPolicyUserWithTeams([1, 2]);
+ $user->shouldReceive('isAdmin')->andReturn(true);
+ $user->shouldReceive('isOwner')->andReturn(false);
+ $user->shouldReceive('isAdminOfTeam')->with(1)->andReturn(false);
+ $team = teamPolicyTeam(1);
+
+ expect((new TeamPolicy)->{$ability}($user, $team))->toBeFalse();
+})->with([
+ 'update',
+ 'delete',
+ 'manageMembers',
+ 'viewAdmin',
+ 'manageInvitations',
+]);
+
+it('denies non-members from privileged team actions', function (string $ability) {
+ $user = teamPolicyUserWithTeams([2]);
+ $team = teamPolicyTeam(1);
+
+ expect((new TeamPolicy)->{$ability}($user, $team))->toBeFalse();
+})->with([
+ 'update',
+ 'delete',
+ 'manageMembers',
+ 'viewAdmin',
+ 'manageInvitations',
+]);