Skip to content

An open-source, self-hostable PaaS alternative to Vercel, Heroku & Netlify that lets you easily deploy static sites, databases, full-stack applications and 360+ one-click services on your own servers.

refactor: remove verbose logging and use explicit exception types

Andras Bacsaifef8e0b62270
diff --git a/app/Jobs/ServerConnectionCheckJob.php b/app/Jobs/ServerConnectionCheckJob.php
index d4a499865f..2c73ae43e4 100644
--- a/app/Jobs/ServerConnectionCheckJob.php
+++ b/app/Jobs/ServerConnectionCheckJob.php
@@ -108,10 +108,6 @@ class ServerConnectionCheckJob implements ShouldBeEncrypted, ShouldQueue
public function failed(?\Throwable $exception): void
{
if ($exception instanceof \Illuminate\Queue\TimeoutExceededException) {
- Log::warning('ServerConnectionCheckJob timed out', [
- 'server_id' => $this->server->id,
- 'server_name' => $this->server->name,
- ]);
$this->server->settings->update([
'is_reachable' => false,
'is_usable' => false,
@@ -131,11 +127,8 @@ class ServerConnectionCheckJob implements ShouldBeEncrypted, ShouldQueue
$serverData = $hetznerService->getServer($this->server->hetzner_server_id);
$status = $serverData['status'] ?? null;
- } catch (\Throwable $e) {
- Log::debug('ServerConnectionCheck: Hetzner status check failed', [
- 'server_id' => $this->server->id,
- 'error' => $e->getMessage(),
- ]);
+ } catch (\Throwable) {
+ // Silently ignore — server may have been deleted from Hetzner.
}
if ($this->server->hetzner_server_status !== $status) {
$this->server->update(['hetzner_server_status' => $status]);
diff --git a/app/Services/ContainerStatusAggregator.php b/app/Services/ContainerStatusAggregator.php
index 2be36d9059..8859a99809 100644
--- a/app/Services/ContainerStatusAggregator.php
+++ b/app/Services/ContainerStatusAggregator.php
@@ -54,13 +54,6 @@ class ContainerStatusAggregator
$maxRestartCount = 0;
}
- if ($maxRestartCount > 1000) {
- Log::warning('High maxRestartCount detected', [
- 'maxRestartCount' => $maxRestartCount,
- 'containers' => $containerStatuses->count(),
- ]);
- }
-
if ($containerStatuses->isEmpty()) {
return 'exited';
}
@@ -138,13 +131,6 @@ class ContainerStatusAggregator
$maxRestartCount = 0;
}
- if ($maxRestartCount > 1000) {
- Log::warning('High maxRestartCount detected', [
- 'maxRestartCount' => $maxRestartCount,
- 'containers' => $containers->count(),
- ]);
- }
-
if ($containers->isEmpty()) {
return 'exited';
}
diff --git a/app/Traits/ExecuteRemoteCommand.php b/app/Traits/ExecuteRemoteCommand.php
index a4ea6abe55..72e0adde8c 100644
--- a/app/Traits/ExecuteRemoteCommand.php
+++ b/app/Traits/ExecuteRemoteCommand.php
@@ -3,6 +3,7 @@
namespace App\Traits;
use App\Enums\ApplicationDeploymentStatus;
+use App\Exceptions\DeploymentException;
use App\Helpers\SshMultiplexingHelper;
use App\Models\Server;
use Carbon\Carbon;
@@ -103,7 +104,7 @@ trait ExecuteRemoteCommand
try {
$this->executeCommandWithProcess($command, $hidden, $customType, $append, $ignore_errors);
$commandExecuted = true;
- } catch (\RuntimeException $e) {
+ } catch (\RuntimeException|DeploymentException $e) {
$lastError = $e;
$errorMessage = $e->getMessage();
// Only retry if it's an SSH connection error and we haven't exhausted retries
@@ -233,7 +234,7 @@ trait ExecuteRemoteCommand
$error = $process_result->output() ?: 'Command failed with no error output';
}
$redactedCommand = $this->redact_sensitive_info($command);
- throw new \RuntimeException("Command execution failed (exit code {$process_result->exitCode()}): {$redactedCommand}\nError: {$error}");
+ throw new DeploymentException("Command execution failed (exit code {$process_result->exitCode()}): {$redactedCommand}\nError: {$error}");
}
}
}