Skip to content

armgit / core

Public Imported from GitHub
0

100% open-source IoT Platform - Integrate your devices, add intelligence, build custom apps

UI updates: Add user broken button fixed and select control validation bug fix (Fixes #549)

Rich Turner98b18417f3c2
diff --git a/ui/app/manager/src/pages/page-users.ts b/ui/app/manager/src/pages/page-users.ts
index 7ed8e1f6c..f9088f068 100644
--- a/ui/app/manager/src/pages/page-users.ts
+++ b/ui/app/manager/src/pages/page-users.ts
@@ -315,7 +315,7 @@ class PageUsers<S extends AppStateKeyed> extends Page<S> {
private async _createUpdateUser(user: UserModel) {
- if (!!user.username) {
+ if (!user.username) {
return;
}
diff --git a/ui/component/core/src/index.ts b/ui/component/core/src/index.ts
index 6cdfc901c..19638e375 100644
--- a/ui/component/core/src/index.ts
+++ b/ui/component/core/src/index.ts
@@ -702,7 +702,7 @@ export class Manager implements EventProviderFactory {
console.warn("Failed to initialise the manager");
}
- this._displayRealm = config.realm;
+ this.displayRealm = config.realm || "master";
return success;
}
@@ -1232,7 +1232,7 @@ export class Manager implements EventProviderFactory {
protected _emitEvent(event: OREvent) {
window.setTimeout(() => {
- const listeners = this._listeners.slice();
+ const listeners = this._listeners;
for (const listener of listeners) {
listener(event);
}
diff --git a/ui/component/or-mwc-components/src/or-mwc-input.ts b/ui/component/or-mwc-components/src/or-mwc-input.ts
index daf54f7f7..7f0ba2a37 100644
--- a/ui/component/or-mwc-components/src/or-mwc-input.ts
+++ b/ui/component/or-mwc-components/src/or-mwc-input.ts
@@ -1435,7 +1435,7 @@ export class OrMwcInput extends LitElement {
(this._mdcComponent as MDCSelect).layoutOptions();
}
(this._mdcComponent as MDCSelect).useDefaultValidation = !this.multiple;
- (this._mdcComponent as MDCSelect).valid = (!this.multiple && (this._mdcComponent as MDCSelect).valid) || (this.multiple && this.required && Array.isArray(this.value) && (this.value as []).length > 0);
+ (this._mdcComponent as MDCSelect).valid = !this.required || (!this.multiple && (this._mdcComponent as MDCSelect).valid) || (this.multiple && Array.isArray(this.value) && (this.value as []).length > 0);
const selectedText = this.getSelectedTextValue();
(this._mdcComponent as any).foundation.adapter.setSelectedText(selectedText);
(this._mdcComponent as any).foundation.adapter.floatLabel(!!selectedText);