Skip to content

armgit / core

Public Imported from GitHub
0

100% open-source IoT Platform - Integrate your devices, add intelligence, build custom apps

Fix the unstable asset tree UI test (#3458)

Martin Peeters9bab8b950be7
diff --git a/ui/app/manager/test/assettree.test.ts b/ui/app/manager/test/assettree.test.ts
index 4b96a0aef..df98fd520 100644
--- a/ui/app/manager/test/assettree.test.ts
+++ b/ui/app/manager/test/assettree.test.ts
@@ -183,7 +183,6 @@ test(`Open browser tab directly to the battery asset`, async ({
await applyParentAssets(parentAssets, manager);
const id = manager.assets.find((asset) => asset.name === batteryAssets[0].name)?.id;
expect(id).toBeDefined();
- await manager.goToRealmStartPage("smartcity");
await assetsPage.gotoAssetId("smartcity", id!);
await expect(assetTree.getFilterInput()).toHaveValue(id!);
await expect(assetTree.getAssetNodes()).toHaveCount(2); // The parent city asset + selected battery asset
diff --git a/ui/app/manager/test/fixtures/manager.ts b/ui/app/manager/test/fixtures/manager.ts
index f1ef457ba..2c5a19e8f 100644
--- a/ui/app/manager/test/fixtures/manager.ts
+++ b/ui/app/manager/test/fixtures/manager.ts
@@ -521,7 +521,6 @@ export class Manager {
// Provision assets
if (assets) {
- this.assets = [];
for (const asset of assets) {
await this.createAsset(asset, config);
}
diff --git a/ui/app/manager/test/fixtures/pages/assets.ts b/ui/app/manager/test/fixtures/pages/assets.ts
index bad4004e3..0d1af3637 100644
--- a/ui/app/manager/test/fixtures/pages/assets.ts
+++ b/ui/app/manager/test/fixtures/pages/assets.ts
@@ -31,8 +31,11 @@ export class AssetsPage implements BasePage {
this.manager.navigateToTab("Assets");
}
+ /**
+ * Navigate to an asset's page, as when opening its URL in a new tab.
+ */
async gotoAssetId(realm: string, id: string, editor = false) {
- this.page.goto(this.manager.getAppUrl(realm) + `#/assets/${editor}/${id}`);
+ await this.page.goto(this.manager.getAppUrl(realm) + `#/assets/${editor}/${id}`);
}
/**