Skip to content

armgit / core

Public Imported from GitHub
0

100% open-source IoT Platform - Integrate your devices, add intelligence, build custom apps

Increase test coverage

Wouter Bornbbb01d5fdad9
diff --git a/test/src/test/groovy/org/openremote/test/users/UserSessionResourceTest.groovy b/test/src/test/groovy/org/openremote/test/users/UserSessionResourceTest.groovy
index 277f61b78..3c72787b0 100644
--- a/test/src/test/groovy/org/openremote/test/users/UserSessionResourceTest.groovy
+++ b/test/src/test/groovy/org/openremote/test/users/UserSessionResourceTest.groovy
@@ -34,6 +34,7 @@ import static java.nio.charset.StandardCharsets.UTF_8
import static java.util.concurrent.TimeUnit.SECONDS
import static org.openremote.manager.mqtt.MQTTBrokerService.MQTT_SERVER_LISTEN_HOST
import static org.openremote.manager.mqtt.MQTTBrokerService.MQTT_SERVER_LISTEN_PORT
+import static org.openremote.model.Constants.KEYCLOAK_CLIENT_ID
import static org.openremote.model.Constants.MASTER_REALM
import static org.openremote.model.util.MapAccess.getInteger
import static org.openremote.model.util.MapAccess.getString
@@ -52,11 +53,13 @@ class UserSessionResourceTest extends Specification implements ManagerContainerT
def uri = serverUri(serverPort)
def ownerToken = authenticate(container, realm, owner.username, owner.secret)
def otherToken = authenticate(container, realm, other.username, other.secret)
+ def crossRealmToken = authenticate(container, MASTER_REALM, KEYCLOAK_CLIENT_ID, setup.testuser1.username, "testuser1")
def superuserToken = authenticate(container, MASTER_REALM, superuser.username, superuser.secret)
def ownerTarget = getClientApiTarget(uri, realm, ownerToken)
def superuserTarget = getClientApiTarget(uri, MASTER_REALM, superuserToken)
def ownerResource = ownerTarget.proxy(UserResource)
def otherResource = getClientApiTarget(uri, realm, otherToken).proxy(UserResource)
+ def crossRealmResource = getClientApiTarget(uri, MASTER_REALM, crossRealmToken).proxy(UserResource)
def anonymousResource = getClientApiTarget(uri, realm).proxy(UserResource)
def superuserResource = superuserTarget.proxy(UserResource)
def conditions = new PollingConditions(timeout: 15, initialDelay: 0.1, delay: 0.2)
@@ -102,6 +105,15 @@ class UserSessionResourceTest extends Specification implements ManagerContainerT
client.state == MqttClientState.CONNECTED
broker.getConnectionUserId(sessionId) == owner.id
+ when: "a non-superuser from another realm supplies the session owner's realm"
+ crossRealmResource.disconnectUserSession(null, realm, sessionId)
+
+ then:
+ def crossRealmException = thrown(WebApplicationException)
+ crossRealmException.response.status == 405
+ client.state == MqttClientState.CONNECTED
+ broker.getConnectionUserId(sessionId) == owner.id
+
when: "a superuser supplies the wrong realm"
superuserResource.disconnectUserSession(null, MASTER_REALM, sessionId)