Skip to content

armgit / core

Public Imported from GitHub
0

100% open-source IoT Platform - Integrate your devices, add intelligence, build custom apps

Add permission checks for creating/modifying JavaScript rules (#2671)

qxyuan853c0ce65b182ce
diff --git a/manager/src/main/java/org/openremote/manager/rules/RulesResourceImpl.java b/manager/src/main/java/org/openremote/manager/rules/RulesResourceImpl.java
index 5afd389f5..b709300cd 100644
--- a/manager/src/main/java/org/openremote/manager/rules/RulesResourceImpl.java
+++ b/manager/src/main/java/org/openremote/manager/rules/RulesResourceImpl.java
@@ -259,8 +259,8 @@ public class RulesResourceImpl extends ManagerWebResource implements RulesResour
// Only super users can create/modify groovy rules
// TODO: Implement robust groovy sandbox
- if (ruleset.getLang() == Ruleset.Lang.GROOVY && !isSuperUser()) {
- throw new ForbiddenException("Only super users can create/modify groovy rules for security reasons");
+ if ((ruleset.getLang() == Ruleset.Lang.GROOVY || ruleset.getLang() == Ruleset.Lang.JAVASCRIPT) && !isSuperUser()) {
+ throw new ForbiddenException("Only super users can create/modify groovy/javascript rules for security reasons");
}
ruleset = rulesetStorageService.merge(ruleset);
return ruleset.getId();