Skip to content

armgit / core

Public Imported from GitHub
0

100% open-source IoT Platform - Integrate your devices, add intelligence, build custom apps

Hotfix for or-mwc-input select; ripple not behaving to Material Design spec (#854)

Martin Peetersdcd52bc31661
diff --git a/.github/workflows/ci_cd.yml b/.github/workflows/ci_cd.yml
index b83a36a0a..c552dfdea 100644
--- a/.github/workflows/ci_cd.yml
+++ b/.github/workflows/ci_cd.yml
@@ -173,7 +173,7 @@ jobs:
- name: Backend files changed
id: backend-files-changed
if: github.event_name == 'pull_request'
- uses: tj-actions/changed-files@v32
+ uses: tj-actions/changed-files@v34
with:
files_ignore: |
.ci_cd/**
@@ -189,7 +189,7 @@ jobs:
- name: UI files changed
id: ui-files-changed
if: github.event_name == 'pull_request'
- uses: tj-actions/changed-files@v32
+ uses: tj-actions/changed-files@v34
with:
files: |
ui/app/manager/**
diff --git a/ui/component/or-mwc-components/src/or-mwc-input.ts b/ui/component/or-mwc-components/src/or-mwc-input.ts
index 4e55c4457..d9908cb24 100644
--- a/ui/component/or-mwc-components/src/or-mwc-input.ts
+++ b/ui/component/or-mwc-components/src/or-mwc-input.ts
@@ -1007,7 +1007,7 @@ export class OrMwcInput extends LitElement {
aria-expanded="false"
aria-disabled="${""+(this.disabled || this.readonly)}"
aria-labelledby="label selected-text">
- <span class="mdc-select__ripple"></span>
+ ${!outlined ? html`<span class="mdc-select__ripple"></span>` : undefined}
${outlined ? this.renderOutlined(labelTemplate) : labelTemplate}
<span class="mdc-select__selected-text-container">
<span id="selected-text" class="mdc-select__selected-text"></span>