A tiny friend in your Mac's notch and on your iPhone that keeps an eye on your AI coding agents: Claude Code, Codex, Cursor, Gemini CLI, Antigravity and more. Approve from the notch or your Lock Screen.
Swift ai-agentsanthropicantigravityclaudeclaude-codecodexcursordynamic-islandgemini-cliiosiphonlinuxmacosmacos-appmenubar-appnotchopen-sourceswiftswiftuiwindows
feat(security): extract safeWebURL, add tests, update docs and CI
Louis Raillec73c79d048ec
diff --git a/.github/workflows/build.yml b/.github/workflows/build.ymlindex 0e3a15a6..07e363f6 100644--- a/.github/workflows/build.yml+++ b/.github/workflows/build.yml@@ -21,6 +21,9 @@ jobs:- name: Test screen geometryrun: bash scripts/test-screen-geometry.sh+ - name: Test link filter+ run: bash scripts/test-safe-links.sh+- name: Buildrun: |xcodebuild \diff --git a/CHANGELOG.md b/CHANGELOG.mdindex d1ff711b..3260fb73 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -3,3 +3,4 @@## Unreleased- Compact island on screens without a notch (#22) — thanks @Kamasoutra+- Only web links (http/https) open from the notch; other kinds of links from Claude or integrations are ignored (#16) — thanks @Cris1670diff --git a/NotchBuddy/NotchBuddy.xcodeproj/project.pbxproj b/NotchBuddy/NotchBuddy.xcodeproj/project.pbxprojindex d5a8b20a..d83c7cdc 100644--- a/NotchBuddy/NotchBuddy.xcodeproj/project.pbxproj+++ b/NotchBuddy/NotchBuddy.xcodeproj/project.pbxproj@@ -38,6 +38,7 @@62C4EE3F74DAA59764729E62 /* UploadCanvasView.swift in Sources */ = {isa = PBXBuildFile; fileRef = B241B043223AFBBFB7418A5E /* UploadCanvasView.swift */; };651FA3F09608DE5D02D61CCE /* BotCanvasView.swift in Sources */ = {isa = PBXBuildFile; fileRef = A29F4C0B02BE91654D02AA0C /* BotCanvasView.swift */; };68A950E3C23FD612639D9776 /* IslandViewContent.swift in Sources */ = {isa = PBXBuildFile; fileRef = FA02B08886939FF6FE0475DD /* IslandViewContent.swift */; };+ 6FC65C190ED614C664C9BC17 /* SafeWebURL.swift in Sources */ = {isa = PBXBuildFile; fileRef = B2FDED98F7F6C755A72C97A3 /* SafeWebURL.swift */; };78B3C6814431B2DD9D1F4949 /* SoundEngine.swift in Sources */ = {isa = PBXBuildFile; fileRef = 1BE21C2B315D37AA70ED45E9 /* SoundEngine.swift */; };78FCEDC8F78B683AB10E6529 /* NotionPoller.swift in Sources */ = {isa = PBXBuildFile; fileRef = BE03E03D1804B0B92C5C2DAD /* NotionPoller.swift */; };878924960FC0F2B3524D48AC /* AppDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = 192844E7299DEED5C2372067 /* AppDelegate.swift */; };@@ -65,6 +66,7 @@F06EE0A97CB77096A337AA8B /* sounds in Resources */ = {isa = PBXBuildFile; fileRef = C066E2B991AA4F56B2724263 /* sounds */; };FAD78D74C6906D4EC8AA4101 /* UploadSequenceEngine.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6FD65943C32E150F1CD65C31 /* UploadSequenceEngine.swift */; };FBBC4CDE82B5886A83A27D7A /* Assets.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 506824380E9C80B9BC6DCE72 /* Assets.xcassets */; };+ FEFEF1EBAB0E6CA74A33C10B /* SafeWebURL.swift in Sources */ = {isa = PBXBuildFile; fileRef = B2FDED98F7F6C755A72C97A3 /* SafeWebURL.swift */; };/* End PBXBuildFile section *//* Begin PBXFileReference section */@@ -88,6 +90,7 @@A29F4C0B02BE91654D02AA0C /* BotCanvasView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = BotCanvasView.swift; sourceTree = "<group>"; };A83D5410BD030B243ADDCFF4 /* ClaudeService.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ClaudeService.swift; sourceTree = "<group>"; };B241B043223AFBBFB7418A5E /* UploadCanvasView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UploadCanvasView.swift; sourceTree = "<group>"; };+ B2FDED98F7F6C755A72C97A3 /* SafeWebURL.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SafeWebURL.swift; sourceTree = "<group>"; };B89DA1A0C21AE3535A1760BB /* N8nPoller.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = N8nPoller.swift; sourceTree = "<group>"; };BE03E03D1804B0B92C5C2DAD /* NotionPoller.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NotionPoller.swift; sourceTree = "<group>"; };C066E2B991AA4F56B2724263 /* sounds */ = {isa = PBXFileReference; lastKnownFileType = folder; name = sounds; path = Resources/sounds; sourceTree = SOURCE_ROOT; };@@ -125,6 +128,7 @@F1BD8F3CAA60CF37640759E1 /* NotchBuddyApp.swift */,BE03E03D1804B0B92C5C2DAD /* NotionPoller.swift */,61B5FDDE03F5F711146937E2 /* ResendPoller.swift */,+ B2FDED98F7F6C755A72C97A3 /* SafeWebURL.swift */,7C1A7D5CBE2AC084A10C5FF3 /* SettingsView.swift */,1BE21C2B315D37AA70ED45E9 /* SoundEngine.swift */,2EF78999D68D56ADE4CEFBE2 /* StripePoller.swift */,@@ -294,6 +298,7 @@06BF5FD95E03010CAFDBF2D0 /* NotchBuddyApp.swift in Sources */,2F36E3C6C073E968A682AFA4 /* NotionPoller.swift in Sources */,967B525F7D3837F31D740D18 /* ResendPoller.swift in Sources */,+ 6FC65C190ED614C664C9BC17 /* SafeWebURL.swift in Sources */,56BE8C733F10A030A638FB60 /* SettingsView.swift in Sources */,60E361FFE84C387E5E3ED1AA /* SoundEngine.swift in Sources */,1558BB00C530B721172F6E65 /* StripePoller.swift in Sources */,@@ -328,6 +333,7 @@DE05D09A32117582AC93A24A /* NotchBuddyApp.swift in Sources */,78FCEDC8F78B683AB10E6529 /* NotionPoller.swift in Sources */,EB23ED9F1C12EA8B54A76A91 /* ResendPoller.swift in Sources */,+ FEFEF1EBAB0E6CA74A33C10B /* SafeWebURL.swift in Sources */,8D1C01F283FA7806119A1C85 /* SettingsView.swift in Sources */,78B3C6814431B2DD9D1F4949 /* SoundEngine.swift in Sources */,E4B9986674F4D425826F15A8 /* StripePoller.swift in Sources */,diff --git a/NotchBuddy/Sources/App/IslandViewContent.swift b/NotchBuddy/Sources/App/IslandViewContent.swiftindex bbfa884f..3c283c66 100644--- a/NotchBuddy/Sources/App/IslandViewContent.swift+++ b/NotchBuddy/Sources/App/IslandViewContent.swift@@ -2790,17 +2790,6 @@ struct StatusBadge: View {// MARK: - Color extension (lighten)-/// Returns the URL only if it is a plain web link (http/https with a host). Model output-/// and API data can carry file://, smb:// or custom app schemes that would launch local apps-/// or deep links; those never reach NSWorkspace.open.-func safeWebURL(_ string: String?) -> URL? {- guard let string,- let url = URL(string: string.trimmingCharacters(in: .whitespacesAndNewlines)),- let scheme = url.scheme?.lowercased(), scheme == "https" || scheme == "http",- let host = url.host, !host.isEmpty else { return nil }- return url-}-extension Color {func lighter(by amount: Double) -> Color {guard let components = NSColor(self).usingColorSpace(.sRGB) else { return self }diff --git a/NotchBuddy/Sources/App/SafeWebURL.swift b/NotchBuddy/Sources/App/SafeWebURL.swiftnew file mode 100644index 00000000..d2e8d9b6--- /dev/null+++ b/NotchBuddy/Sources/App/SafeWebURL.swift@@ -0,0 +1,12 @@+import Foundation++/// Returns the URL only if it is a plain web link (http/https with a host). Model output+/// and API data can carry file://, smb:// or custom app schemes that would launch local apps+/// or deep links; those never reach NSWorkspace.open.+func safeWebURL(_ string: String?) -> URL? {+ guard let string,+ let url = URL(string: string.trimmingCharacters(in: .whitespacesAndNewlines)),+ let scheme = url.scheme?.lowercased(), scheme == "https" || scheme == "http",+ let host = url.host, !host.isEmpty else { return nil }+ return url+}diff --git a/docs/INTEGRATIONS.md b/docs/INTEGRATIONS.mdindex d5986016..0e839b5d 100644--- a/docs/INTEGRATIONS.md+++ b/docs/INTEGRATIONS.md@@ -120,7 +120,7 @@ Permissions : Enregistrement de l'écran (capture) et Automatisation (navigateur3 items maximum. Si le JSON est invalide : afficher le texte brut (3 lignes max) dans la vue `result`.- Contenu du message utilisateur : capture (bloc image) + « URL : … / Titre : … / Demande : … », ou fichier (§3) + demande, ou demande seule (onglet Demander).- Pendant l'appel : état `searching`, vue `searching`, texte scintillant. Réponse : état `finished`, vue `result`, émote Fier, son `finish`.-- Boutons du résultat : « Ouvrir » (premier lien), « Copier » (texte), « Fermer ».+- Boutons du résultat : « Ouvrir » (premier lien, seulement s'il est en http ou https ; sinon le bouton est grisé), « Copier » (texte), « Fermer ».- Erreur réseau ou clé invalide : état `error`, vue `note` avec la raison en une phrase et « Ouvre les réglages pour vérifier la clé ».- Micro (bouton du champ) : dictée `SFSpeechRecognizer` en `fr-FR`, sur l'appareil si possible. Optionnel (M9). Si la permission est refusée, masquer le bouton.diff --git a/docs/support.html b/docs/support.htmlindex 0b097c0b..23cbb534 100644--- a/docs/support.html+++ b/docs/support.html@@ -50,7 +50,7 @@<h3>Pas de son</h3><p>Vérifie l’icône haut-parleur dans l’en-tête du notch et le volume dans les Réglages.</p><h3>Ça marche sans notch ?</h3>-<p>Oui. Sur un iMac, un Mac mini ou un MacBook capot fermé branché à un écran externe, Mochi s'affiche dans une petite barre en haut de l'écran principal. Capot ouvert, il reste dans le notch.</p>+<p>Oui. Sur un iMac, un Mac mini ou un MacBook capot fermé branché à un écran externe, Mochi s’affiche dans une petite barre en haut de l’écran principal. Capot ouvert, il reste dans le notch.</p><h3>Comment désinstaller ?</h3><p>Réglages → Claude Code → <b>Uninstall</b> (retire seulement les hooks de Coucou), puis quitte l’app et mets-la à la corbeille. Tu peux aussi supprimer <code>~/Library/Application Support/NotchBuddy</code>.</p><p>Sous Windows : le même bouton <b>Uninstall</b> pour les hooks, puis Paramètres Windows → Applications → <b>Coucou</b> → Désinstaller. Tu peux aussi supprimer <code>%LOCALAPPDATA%\Coucou</code>.</p>diff --git a/scripts/test-safe-links.sh b/scripts/test-safe-links.shnew file mode 100755index 00000000..cfc112c3--- /dev/null+++ b/scripts/test-safe-links.sh@@ -0,0 +1,8 @@+#!/usr/bin/env bash+set -euo pipefail+cd "$(dirname "$0")/.."+TEST_DIR="$(mktemp -d "${TMPDIR:-/tmp}/coucou-safe-links.XXXXXX")"+trap 'rm -rf "$TEST_DIR"' EXIT+swiftc NotchBuddy/Sources/App/SafeWebURL.swift \+ tests/SafeWebURLTests.swift -o "$TEST_DIR/safe-links-tests"+"$TEST_DIR/safe-links-tests"diff --git a/tests/SafeWebURLTests.swift b/tests/SafeWebURLTests.swiftnew file mode 100644index 00000000..e8896820--- /dev/null+++ b/tests/SafeWebURLTests.swift@@ -0,0 +1,27 @@+import Foundation++@main+enum SafeWebURLTests {+ static func main() {+ // Accepted: plain http/https URLs+ precondition(safeWebURL("https://example.com") != nil)+ precondition(safeWebURL("http://example.com/a?b=1") != nil)+ precondition(safeWebURL("HTTPS://EXAMPLE.COM") != nil)+ precondition(safeWebURL(" https://example.com \n") != nil)+ precondition(safeWebURL("http://localhost:5678") != nil)++ // Rejected: nil, empty, non-web schemes, malformed+ precondition(safeWebURL(nil) == nil)+ precondition(safeWebURL("") == nil)+ precondition(safeWebURL("file:///etc/hosts") == nil)+ precondition(safeWebURL("javascript:alert(1)") == nil)+ precondition(safeWebURL("vscode://file/etc/hosts") == nil)+ precondition(safeWebURL("smb://server/share") == nil)+ precondition(safeWebURL("mailto:[email protected]") == nil)+ precondition(safeWebURL("https://") == nil)+ precondition(safeWebURL("https:example.com") == nil)+ precondition(safeWebURL("//example.com") == nil)++ print("Safe web links: 15 cases passed")+ }+}