Skip to content

armgit / cra

Public Imported from GitHub
0

The open-source Arc replacement for macOS. Spaces, pinned tabs, split view, Little Windows and Arc's shortcuts on Chromium, with your Arc sidebar imported in one go.

Shipped sidebar issues are pinned by locked tests

Victor42c0b2c734c2
diff --git a/Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift b/Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift
index 483dc25..3df1c99 100644
--- a/Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift
@@ -10,14 +10,16 @@ struct CloseSuccessorTests {
CloseSuccessor.next(closing: closing, previous: previous, hasPage: loaded.contains, list: list ?? today)
}
- @Test func backToTheTabShownBeforeWhileItHasAPage() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/105"))
+ func backToTheTabShownBeforeWhileItHasAPage() {
// A opened from S in the background, reached from D: back to D, not to S.
#expect(next("A", previous: "D", loaded: ["S", "D", "A"]) == "D")
// A pinned tab goes back the same way.
#expect(next("S", previous: "P2", loaded: ["S", "P2"], list: []) == "P2")
}
- @Test func aPreviousTabWithoutAPageDoesNotCount() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/105"))
+ func aPreviousTabWithoutAPageDoesNotCount() {
// Closed (a pinned tab's ⌘W) or not loaded since launch: the neighbour above instead.
#expect(next("D", previous: "S", loaded: ["D"]) == "A")
#expect(next("B", previous: "D", loaded: ["B"]) == "C")
@@ -26,7 +28,8 @@ struct CloseSuccessorTests {
#expect(next("S", previous: nil, loaded: ["S"], list: []) == nil)
}
- @Test func theNeighbourAboveThenBelow() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/105"))
+ func theNeighbourAboveThenBelow() {
#expect(next("B", previous: nil, loaded: []) == "C")
#expect(next("C", previous: "B", loaded: ["C"]) == "B")
#expect(next("C", previous: nil, loaded: []) == "B")
@@ -35,13 +38,15 @@ struct CloseSuccessorTests {
#expect(next("C", previous: nil, loaded: [], list: ["C"]) == nil)
}
- @Test func aPinnedSplitHandsOverToNothing() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/105"))
+ func aPinnedSplitHandsOverToNothing() {
#expect(CloseSuccessor.afterPinned(closing: "PS", isSplit: true, previous: "D", hasPage: { _ in true }) == nil)
#expect(CloseSuccessor.afterPinned(closing: "F1", isSplit: false, previous: "D", hasPage: { _ in true }) == "D")
#expect(CloseSuccessor.afterPinned(closing: "F1", isSplit: false, previous: "D", hasPage: { _ in false }) == nil)
}
- @Test func theClosingTabIsNeverItsOwnSuccessor() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/105"))
+ func theClosingTabIsNeverItsOwnSuccessor() {
#expect(next("A", previous: "A", loaded: ["A"]) == "B")
}
}
diff --git a/Packages/CraCore/Tests/CraCoreTests/FavoritesLayoutTests.swift b/Packages/CraCore/Tests/CraCoreTests/FavoritesLayoutTests.swift
index e335b27..500b111 100644
--- a/Packages/CraCore/Tests/CraCoreTests/FavoritesLayoutTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/FavoritesLayoutTests.swift
@@ -7,7 +7,7 @@ import Testing
struct FavoritesLayoutTests {
/// Arc 1.170, 29 Oct: four favorites, sidebar width → columns and the tile width Arc's AX
/// frames report (whole points; nil where it wasn't written down).
- @Test(arguments: [
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/12"), arguments: [
(347, 4, 76), (300, 4, nil), (260, 4, 55), (230, 4, 47),
(227, 2, 101), (225, 2, 100), (220, 2, 98), (212, 2, 94), (205, 2, 90), (200, 2, 88),
(170, 2, 73), (140, 2, 58), (100, 1, 84),
@@ -21,7 +21,7 @@ struct FavoritesLayoutTests {
/// Arc 1.171, 31 Oct: 1–9 favorites at five sidebar widths. The widest grid keeps tiles at
/// least 47 pt (4 at 347 and 230, 3 at 200, 2 at 140, 1 at 100), then takes the fewest
/// columns that need no more rows: 5 → 3 + 2, 6 → 3 × 2, 7 → 4 + 3, 9 → 3 × 3, 4 at 200 → 2 × 2.
- @Test(arguments: [
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/29"), arguments: [
(347, [1, 2, 3, 4, 3, 3, 4, 4, 3]),
(230, [1, 2, 3, 4, 3, 3, 4, 4, 3]),
(200, [1, 2, 3, 2, 3, 3, 3, 3, 3]),
@@ -59,7 +59,8 @@ struct FavoritesLayoutTests {
}
/// #176: the slot under the pointer, across rows, with gaps going to the nearer tile.
- @Test func slotUnderThePointer() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/176"))
+ func slotUnderThePointer() {
let grid = FavoritesLayout(count: 5, width: 331) // 3 + 2, tiles 105 wide, 55 pt row pitch
#expect(grid.slot(at: CGPoint(x: 10, y: 10)) == 0)
#expect(grid.slot(at: CGPoint(x: 120, y: 10)) == 1)
@@ -74,7 +75,8 @@ struct FavoritesLayoutTests {
#expect(FavoritesLayout(count: 0, width: 331).slot(at: .zero) == 0)
}
- @Test func tilesMoveAlongPastTheOpenSlot() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/176"))
+ func tilesMoveAlongPastTheOpenSlot() {
#expect((0..<4).map { FavoritesLayout.slot(ofTile: $0, opening: nil) } == [0, 1, 2, 3])
#expect((0..<4).map { FavoritesLayout.slot(ofTile: $0, opening: 0) } == [1, 2, 3, 4])
#expect((0..<4).map { FavoritesLayout.slot(ofTile: $0, opening: 2) } == [0, 1, 3, 4])
diff --git a/Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift b/Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift
index 9b2713d..53e8876 100644
--- a/Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift
@@ -10,7 +10,8 @@ struct FavoritesSharingTests {
static func ids(_ n: Int) -> [UUID] { (0..<n).map { _ in UUID() } }
- @Test func eachProfileGetsOneListOfItsSpacesFavorites() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/154"))
+ func eachProfileGetsOneListOfItsSpacesFavorites() {
let sp = Self.ids(4), c = Self.ids(4), f = Self.ids(5), made = Self.ids(2), work = UUID()
var next = made.makeIterator()
let plan = FavoritesSharing.share([
@@ -30,7 +31,8 @@ struct FavoritesSharingTests {
}
/// Arc keeps a profile's list while no space uses it; turning sharing on again starts from it.
- @Test func aProfilesListIsReused() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/154"))
+ func aProfilesListIsReused() {
let sp = UUID(), c = UUID(), list = UUID(), f = Self.ids(3)
let plan = FavoritesSharing.share(
[S(spaceID: sp, profileID: nil, containerID: c, items: [E(id: f[1], key: "tab https://a.example"), E(id: f[2], key: "tab https://b.example")])],
@@ -40,7 +42,8 @@ struct FavoritesSharingTests {
#expect(plan.moves == [.init(item: f[2], container: list)] && plan.duplicates == [f[1]: f[0]])
}
- @Test func twoOfAPageInOneSpaceBothStay() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/154"))
+ func twoOfAPageInOneSpaceBothStay() {
let sp = UUID(), c = UUID(), f = Self.ids(2)
let plan = FavoritesSharing.share([S(spaceID: sp, profileID: nil, containerID: c,
items: [E(id: f[0], key: "tab https://a.example"), E(id: f[1], key: "tab https://a.example")])], lists: [])
@@ -49,7 +52,8 @@ struct FavoritesSharingTests {
/// Off gives each space its own list again; on folds the copies back, so the list comes back
/// as it was, not doubled.
- @Test func offAndOnAgainChangesNothing() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/154"))
+ func offAndOnAgainChangesNothing() {
let sp = Self.ids(3), list = UUID(), c = Self.ids(2), f = Self.ids(4)
let shared = [E(id: f[0], key: "tab https://a.example"), E(id: f[1], key: "split https://b.example https://c.example")]
let lists = [ProfileFavorites(profileID: nil, containerID: list)]
@@ -64,7 +68,8 @@ struct FavoritesSharingTests {
#expect(on.duplicates == [f[2]: f[0], f[3]: f[1]])
}
- @Test func sharedListsStayPut() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/154"))
+ func sharedListsStayPut() {
let sp = Self.ids(2), list = UUID(), work = UUID(), f = UUID()
let lists = [L(ProfileFavorites(profileID: work, containerID: list), items: [E(id: f, key: "tab https://a.example")])]
let plan = FavoritesSharing.share(sp.map { S(spaceID: $0, profileID: work, containerID: list, items: lists[0].items) }, lists: lists)
@@ -74,7 +79,8 @@ struct FavoritesSharingTests {
"a space with its own list keeps it")
}
- @Test func keys() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/154"))
+ func keys() {
let tab = SidebarItem.tab("https://mail.example/inbox", parent: nil)
#expect(FavoritesSharing.key(of: tab, children: []) == "tab https://mail.example/inbox")
#expect(FavoritesSharing.key(of: SidebarItem.tab("", parent: nil), children: []) == nil, "an empty pane matches nothing")
@@ -86,14 +92,16 @@ struct FavoritesSharingTests {
#expect(FavoritesSharing.key(of: SidebarItem.folder("F", parent: nil), children: []) == nil)
}
- @Test func settingIsOffUntilTurnedOn() throws {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/154"))
+ func settingIsOffUntilTurnedOn() throws {
let empty = try JSONDecoder().decode(AppSettings.self, from: Data("{}".utf8))
#expect(!empty.sharedFavorites)
let on = try JSONDecoder().decode(AppSettings.self, from: Data(#"{"sharedFavorites": true}"#.utf8))
#expect(on.sharedFavorites)
}
- @Test func listsRoundTrip() throws {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/154"))
+ func listsRoundTrip() throws {
var doc = SidebarDocument.fresh()
doc.profileFavorites = [ProfileFavorites(profileID: nil, containerID: UUID()), ProfileFavorites(profileID: UUID(), containerID: UUID())]
let data = try JSONEncoder().encode(doc)
diff --git a/Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift b/Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift
index 3ee39b3..d4186e5 100644
--- a/Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift
@@ -6,14 +6,16 @@ struct FolderPeekTests {
// Pinned: outer ▸ inner ▸ tab, both closed unless a test opens them.
let outer = "outer", inner = "inner", tab = "tab", other = "other"
- @Test func outermostClosedFolderHostsTheTab() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/85"))
+ func outermostClosedFolderHostsTheTab() {
#expect(FolderPeek.host(folders: [outer, inner], isExpanded: { _ in false }) == outer)
#expect(FolderPeek.host(folders: [outer, inner], isExpanded: { $0 == outer }) == inner)
#expect(FolderPeek.host(folders: [outer, inner], isExpanded: { _ in true }) == nil)
#expect(FolderPeek.host(folders: [String](), isExpanded: { _ in false }) == nil)
}
- @Test func openingATabInClosedFoldersPeeksItUnderTheOutermost() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/85"))
+ func openingATabInClosedFoldersPeeksItUnderTheOutermost() {
let peeks = FolderPeek.opening(tab, folders: [outer, inner], isExpanded: { _ in false }, peeks: [:])
#expect(peeks == [outer: [tab]])
// Again: nothing changes. Another tab joins the same peek, the first one stays (Arc).
@@ -21,12 +23,14 @@ struct FolderPeekTests {
#expect(FolderPeek.opening(other, folders: [outer], isExpanded: { _ in false }, peeks: peeks) == [outer: [tab, other]])
}
- @Test func openingATabInOpenFoldersPeeksNothing() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/85"))
+ func openingATabInOpenFoldersPeeksNothing() {
#expect(FolderPeek.opening(tab, folders: [outer, inner], isExpanded: { _ in true }, peeks: [:]).isEmpty)
#expect(FolderPeek.opening(tab, folders: [String](), isExpanded: { _ in false }, peeks: [:]).isEmpty)
}
- @Test func openingTheFolderDropsItsPeekClosingKeepsTheOpenTab() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/85"))
+ func openingTheFolderDropsItsPeekClosingKeepsTheOpenTab() {
let peeks = [outer: [tab, other]]
#expect(FolderPeek.expanding(outer, true, openTabInside: tab, peeks: peeks).isEmpty)
#expect(FolderPeek.expanding(outer, false, openTabInside: tab, peeks: [:]) == [outer: [tab]])
@@ -35,7 +39,8 @@ struct FolderPeekTests {
#expect(FolderPeek.expanding(inner, true, openTabInside: nil, peeks: peeks) == peeks)
}
- @Test func aClickOnAPeekedFolderClosesIt() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/85"))
+ func aClickOnAPeekedFolderClosesIt() {
#expect(FolderPeek.clickOpens(expanded: false, peeked: false))
#expect(!FolderPeek.clickOpens(expanded: true, peeked: false))
#expect(!FolderPeek.clickOpens(expanded: false, peeked: true))
@@ -44,13 +49,15 @@ struct FolderPeekTests {
#expect(FolderPeek.expanding(outer, false, openTabInside: tab, peeks: [outer: [tab, other]]) == [outer: [tab]])
}
- @Test func closingATabDropsItFromEveryPeek() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/85"))
+ func closingATabDropsItFromEveryPeek() {
let peeks = [outer: [tab, other], inner: [tab]]
#expect(FolderPeek.removing(tab, peeks: peeks) == [outer: [other]])
#expect(FolderPeek.removing(other, peeks: [outer: [other]]).isEmpty)
}
- @Test func listedRowsFollowTheSidebarAndSkipTabsThatLeft() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/85"))
+ func listedRowsFollowTheSidebarAndSkipTabsThatLeft() {
let peeks = [outer: [other, tab, "moved away"]]
#expect(FolderPeek.listed(in: outer, peeks: peeks, tabsInside: ["a", tab, other]) == [tab, other])
#expect(FolderPeek.listed(in: inner, peeks: peeks, tabsInside: [tab]).isEmpty)
diff --git a/Packages/CraCore/Tests/CraCoreTests/KeyChordTests.swift b/Packages/CraCore/Tests/CraCoreTests/KeyChordTests.swift
index a826ca0..92b68f6 100644
--- a/Packages/CraCore/Tests/CraCoreTests/KeyChordTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/KeyChordTests.swift
@@ -45,7 +45,7 @@ struct KeyChordTests {
}
/// ⌘Return opens the command bar's row in a background tab (GitHub #85).
- @Test(arguments: [
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/85"), arguments: [
(UInt16(36), command, true), // ⌘Return
(76, command, true), // ⌘Enter on the keypad
(36, command | 0x10000 | 0x800000, true), // Caps Lock and the function-key bit don't count
diff --git a/Packages/CraCore/Tests/CraCoreTests/LinkMenuTests.swift b/Packages/CraCore/Tests/CraCoreTests/LinkMenuTests.swift
index f314ea9..67480f0 100644
--- a/Packages/CraCore/Tests/CraCoreTests/LinkMenuTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/LinkMenuTests.swift
@@ -3,19 +3,22 @@ import CraCore
import Foundation
@Suite struct LinkMenuTests {
- @Test func defaultSwitchesToTheNewTabLikeArc() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/183"))
+ func defaultSwitchesToTheNewTabLikeArc() {
let items = LinkMenu.items(openLinksInBackground: false)
#expect(items.map(\.title) == ["Open Link in New Tab", "Open Link in Background Tab"])
#expect(items.map(\.opensInBackground) == [false, true])
}
- @Test func settingOnKeepsThePageInFrontAndOffersTheSwitch() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/183"))
+ func settingOnKeepsThePageInFrontAndOffersTheSwitch() {
let items = LinkMenu.items(openLinksInBackground: true)
#expect(items.map(\.title) == ["Open Link in New Tab", "Open Link in Foreground Tab"])
#expect(items.map(\.opensInBackground) == [true, false])
}
- @Test func settingIsOffForSettingsWithoutIt() throws {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/183"))
+ func settingIsOffForSettingsWithoutIt() throws {
let s = try JSONDecoder().decode(AppSettings.self, from: Data("{}".utf8))
#expect(!s.openLinksInBackground)
}
diff --git a/Packages/CraCore/Tests/CraCoreTests/PeekTriggerTests.swift b/Packages/CraCore/Tests/CraCoreTests/PeekTriggerTests.swift
index ffb740c..1d32dcd 100644
--- a/Packages/CraCore/Tests/CraCoreTests/PeekTriggerTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/PeekTriggerTests.swift
@@ -15,7 +15,8 @@ struct PeekTriggerTests {
return PeekTrigger.opens(url, from: page, shiftClick: shift, newTab: newTab, fromPinned: pinned, settings: s)
}
- @Test func pinnedTabPeeksAtOtherHosts() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/12"))
+ func pinnedTabPeeksAtOtherHosts() {
#expect(Self.opens(Self.other))
#expect(Self.opens(Self.other, newTab: true))
#expect(!Self.opens(Self.same))
@@ -25,13 +26,15 @@ struct PeekTriggerTests {
#expect(Self.opens(Self.same, newTab: true))
}
- @Test func todayTabsLoadUnlessEveryTabIsOn() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/12"))
+ func todayTabsLoadUnlessEveryTabIsOn() {
#expect(!Self.opens(Self.other, pinned: false))
#expect(!Self.opens(Self.same, newTab: true, pinned: false))
#expect(Self.opens(Self.other, pinned: false) { $0.peekInEveryTab = true })
}
- @Test func shiftClickPeeksFromAnyTab() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/12"))
+ func shiftClickPeeksFromAnyTab() {
#expect(Self.opens(Self.same, shift: true, pinned: false))
#expect(!Self.opens(Self.same, shift: true) { $0.peekOnShiftClick = false })
}
diff --git a/Packages/CraCore/Tests/CraCoreTests/ShippedSidebarTests.swift b/Packages/CraCore/Tests/CraCoreTests/ShippedSidebarTests.swift
new file mode 100644
index 0000000..e2de311
--- /dev/null
+++ b/Packages/CraCore/Tests/CraCoreTests/ShippedSidebarTests.swift
@@ -0,0 +1,50 @@
+import CraCore
+import Foundation
+import Testing
+
+/// What closed sidebar issues shipped, where no test of the same type held it already. The
+/// settings files are the made-up ones in Fixtures/Model/input.
+struct ShippedSidebarTests {
+ static func settings(_ name: String) throws -> AppSettings {
+ try ModelFixtureTests.decoder.decode(AppSettings.self, from: ModelFixtureTests.data("input", name))
+ }
+
+ static func reloaded(_ settings: AppSettings) throws -> AppSettings {
+ try ModelFixtureTests.decoder.decode(AppSettings.self, from: ModelFixtureTests.encoder.encode(settings))
+ }
+
+ /// The New Tab row leads Today, where Arc has it (#47): on a new Mac, and once for settings
+ /// 0.1.15–0.1.23 saved with the row below Today. Moved back below after that, it stays there.
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/47"))
+ func newTabRowLeadsToday() throws {
+ #expect(AppSettings().newTabButtonAtTop, "a first launch has the row above Today")
+ let legacy = try Self.settings("settings-legacy.json")
+ #expect(legacy.newTabButtonAtTop && legacy.newTabButtonDefaultMigrated,
+ "settings saved before the move, with the row below Today, get it above once")
+ let chosen = try Self.settings("settings.json")
+ #expect(!chosen.newTabButtonAtTop, "settings saved since keep the row where the user put it")
+ #expect(try !Self.reloaded(chosen).newTabButtonAtTop && Self.reloaded(legacy).newTabButtonAtTop,
+ "and a save and a relaunch keep it there")
+ }
+
+ /// Settings ▸ Tabs ▸ Links ▸ "Open links in new tabs in the background" (#183) is off unless
+ /// turned on, and survives a restart once on.
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/183"))
+ func backgroundLinksSettingIsKept() throws {
+ #expect(!AppSettings().openLinksInBackground)
+ let on = try Self.settings("settings.json")
+ #expect(try on.openLinksInBackground && Self.reloaded(on).openLinksInBackground)
+ }
+
+ /// Peek (#12): links to other sites peek from Favorites and Pinned tabs and Shift-click peeks
+ /// from any tab, both on by default as in Arc; "In every tab" is off unless turned on. Settings
+ /// saved before these existed get the same.
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/12"))
+ func peekOptionsDefaultToArcs() throws {
+ for s in [AppSettings(), try ModelFixtureTests.decoder.decode(AppSettings.self, from: Data("{}".utf8))] {
+ #expect(s.peekLinksToOtherSites && s.peekOnShiftClick && !s.peekInEveryTab)
+ }
+ let changed = try Self.reloaded(Self.settings("settings.json"))
+ #expect(!changed.peekLinksToOtherSites && !changed.peekOnShiftClick && changed.peekInEveryTab, "a choice is kept")
+ }
+}
diff --git a/Packages/CraCore/Tests/CraCoreTests/SidebarCloseTests.swift b/Packages/CraCore/Tests/CraCoreTests/SidebarCloseTests.swift
index 82f1cc4..57ba9e5 100644
--- a/Packages/CraCore/Tests/CraCoreTests/SidebarCloseTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/SidebarCloseTests.swift
@@ -3,7 +3,8 @@ import Testing
/// GitHub #139: Arc 1.171's close buttons, as recorded in an offline Arc.
struct SidebarCloseTests {
- @Test func tabRows() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/139"))
+ func tabRows() {
let open = SidebarClose.tab(pinned: true, current: true, navigatedAway: false, peeked: false)
#expect(open.minus && open.help == "Close and Keep Pinned (⌘W)")
let away = SidebarClose.tab(pinned: true, current: false, navigatedAway: true, peeked: false)
@@ -16,14 +17,16 @@ struct SidebarCloseTests {
#expect(SidebarClose.tab(pinned: false, current: false, navigatedAway: true, peeked: true).help == "Archive this tab")
}
- @Test func splitRows() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/139"))
+ func splitRows() {
#expect(SidebarClose.split(pinned: true, current: true) == .row(.init(action: .keep, help: "Close this item (⌘W)")))
#expect(SidebarClose.split(pinned: true, current: false) == .row(.init(action: .archive, help: "Archive this item")))
#expect(SidebarClose.split(pinned: false, current: false) == .row(.init(action: .archive, help: "Archive this item")))
#expect(SidebarClose.split(pinned: false, current: true) == .perPane(.init(action: .archive, help: "Archive this item")))
}
- @Test func commandW() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/139"))
+ func commandW() {
#expect(SidebarClose.commandW(anyToday: true) == .archive)
#expect(SidebarClose.commandW(anyToday: false) == .keep)
}
diff --git a/Packages/CraCore/Tests/CraCoreTests/SidebarModelTests.swift b/Packages/CraCore/Tests/CraCoreTests/SidebarModelTests.swift
index 6b262f6..17923a2 100644
--- a/Packages/CraCore/Tests/CraCoreTests/SidebarModelTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/SidebarModelTests.swift
@@ -48,7 +48,7 @@ struct SidebarModelTests {
/// The line under a tab's title (GitHub #88, #139): Arc's TabCellState.subtitle is a
/// developer-mode site's host (and port), else a pull request's author. Leaving a pinned
/// page shows none.
- @Test(.bug("https://github.com/VictorKildahl/cra/issues/88"))
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/88"), .bug("https://github.com/VictorKildahl/cra/issues/139"))
func sidebarSubtitle() {
var tab = TabData(url: "https://www.youtube.com/watch?v=1", title: "Video")
#expect(tab.sidebarSubtitle(developerMode: false) == nil)
@@ -65,7 +65,8 @@ struct SidebarModelTests {
/// GitHub #139: a pinned tab that goes back to its page shows that page's name and favicon,
/// not the last page's, before it loads again.
- @Test func returningHomeShowsTheHomesNameAndIcon() throws {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/139"))
+ func returningHomeShowsTheHomesNameAndIcon() throws {
var tab = TabData(url: "https://github.com/", title: "")
tab.noteTitle("GitHub", pinned: true)
#expect(tab.homeTitle == "GitHub")
diff --git a/Packages/CraCore/Tests/CraCoreTests/SpaceWindowTests.swift b/Packages/CraCore/Tests/CraCoreTests/SpaceWindowTests.swift
index 86c5d6a..1df3978 100644
--- a/Packages/CraCore/Tests/CraCoreTests/SpaceWindowTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/SpaceWindowTests.swift
@@ -8,19 +8,22 @@ struct SpaceWindowTests {
let victor = UUID(), jysk = UUID(), work = UUID()
/// Arc: window A shows Victor and was used last, window B shows JYSK; JYSK goes to B.
- @Test func aWindowShowingTheSpaceTakesThePage() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/92"))
+ func aWindowShowingTheSpaceTakesThePage() {
#expect(SpaceWindow.window(for: jysk, windows: [(a, victor), (b, jysk)], lastUsed: a) == b)
#expect(SpaceWindow.window(for: victor, windows: [(a, victor), (b, jysk)], lastUsed: a) == a)
}
- @Test func otherwiseTheWindowInUseLastSwitches() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/92"))
+ func otherwiseTheWindowInUseLastSwitches() {
#expect(SpaceWindow.window(for: work, windows: [(b, jysk), (a, victor)], lastUsed: a) == a)
// The window in use can be hidden (the last one closed), so not in the list.
#expect(SpaceWindow.window(for: work, windows: [], lastUsed: a) == a)
}
/// Of several windows on the space, the one in use last, else the frontmost.
- @Test func severalWindowsOnTheSpace() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/92"))
+ func severalWindowsOnTheSpace() {
#expect(SpaceWindow.window(for: jysk, windows: [(b, jysk), (c, jysk), (a, victor)], lastUsed: c) == c)
#expect(SpaceWindow.window(for: jysk, windows: [(c, jysk), (b, jysk), (a, victor)], lastUsed: a) == c)
}
diff --git a/Packages/CraCore/Tests/CraCoreTests/TabSearchScopeTests.swift b/Packages/CraCore/Tests/CraCoreTests/TabSearchScopeTests.swift
index abe2b19..bfec247 100644
--- a/Packages/CraCore/Tests/CraCoreTests/TabSearchScopeTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/TabSearchScopeTests.swift
@@ -7,14 +7,15 @@ struct TabSearchScopeTests {
typealias C = TabSearchScope.Candidate<String>
let now = Date(timeIntervalSinceReferenceDate: 800_000_000)
- @Test(arguments: [("%", true), (" % ", true), ("%a", false), ("50%", false), ("%%", false), ("", false)])
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/49"), arguments: [("%", true), (" % ", true), ("%a", false), ("50%", false), ("%%", false), ("", false)])
func percentAloneOffersTheScope(query: String, offered: Bool) {
#expect(TabSearchScope.isOffered(by: query) == offered)
}
/// "%" Tab lists the space's tabs: the latest first, tabs not opened since launch after them
/// in sidebar order.
- @Test func nothingTypedListsByRecency() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/49"))
+ func nothingTypedListsByRecency() {
let tabs = [
C(id: "unopened-a", score: 0, lastActive: nil),
C(id: "old", score: 0, lastActive: now.addingTimeInterval(-3600)),
@@ -25,7 +26,8 @@ struct TabSearchScopeTests {
}
/// Typed: scattered-letter matches drop out, the best match leads and recency breaks ties.
- @Test func typedRanksByMatchThenRecency() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/49"))
+ func typedRanksByMatchThenRecency() {
let tabs = [
C(id: "scattered", score: 45, lastActive: now),
C(id: "word", score: 85, lastActive: now.addingTimeInterval(-60)),
@@ -36,7 +38,8 @@ struct TabSearchScopeTests {
#expect(TabSearchScope.rank(tabs, typed: true) == ["prefix-new", "prefix-old", "word", "url"])
}
- @Test func noTabsNoRows() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/49"))
+ func noTabsNoRows() {
#expect(TabSearchScope.rank([C](), typed: false).isEmpty)
#expect(TabSearchScope.rank([C(id: "a", score: 10, lastActive: now)], typed: true).isEmpty)
}
diff --git a/Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift b/Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift
index b9caac8..2e7944e 100644
--- a/Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift
+++ b/Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift
@@ -10,20 +10,23 @@ struct WheelSpaceSwitchTests {
return events.map { wheel.step(dx: $0.0, inverted: inverted, at: $0.1) }
}
- @Test func oneSlowNotchDoesNothing() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func oneSlowNotchDoesNothing() {
#expect(steps([(-1, 10)]) == [0])
// Notches further apart than the pause never add up.
#expect(steps([(-1, 10), (-1, 10.065), (-1, 10.13), (-1, 10.2)]) == [0, 0, 0, 0])
}
- @Test func aFlickSwitches() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func aFlickSwitches() {
#expect(steps([(-2, 10)]) == [1])
#expect(steps([(-1, 10), (-1, 10.035)]) == [0, 1])
#expect(steps([(-3, 10)]) == [1])
}
/// A positive delta (Shift + wheel one way, fingers right on a trackpad) goes back.
- @Test func directionFollowsTheSwipe() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func directionFollowsTheSwipe() {
#expect(steps([(2, 10)]) == [-1])
#expect(steps([(1, 10), (1, 10.02)]) == [0, -1])
}
@@ -31,27 +34,31 @@ struct WheelSpaceSwitchTests {
/// With natural scrolling (macOS's default) the deltas arrive flipped and the event says so;
/// the same wheel turn still pages the same way (Arc 1.171 XORs the sign with
/// isDirectionInvertedFromDevice; issue #93, reversed in Cra 0.1.27).
- @Test func naturalScrollingPagesTheSameWay() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func naturalScrollingPagesTheSameWay() {
#expect(steps([(2, 10)], inverted: true) == [1])
#expect(steps([(-2, 10)], inverted: true) == [-1])
#expect(steps([(1, 10), (1, 10.02)], inverted: true) == [0, 1])
}
/// A turn subtracts from what had added up rather than starting afresh (Arc keeps one sum).
- @Test func aTurnCancelsOut() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func aTurnCancelsOut() {
#expect(steps([(-1, 10), (1, 10.02), (-1, 10.04)]) == [0, 0, 0])
#expect(steps([(-0.8, 10), (0.5, 10.02), (-0.8, 10.04)]) == [0, 0, 1])
}
/// Arc forgets the sum after 0.05 s without a wheel event.
- @Test func aPauseForgets() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func aPauseForgets() {
#expect(steps([(-1, 10), (-1, 10.045)]) == [0, 1])
#expect(steps([(-1, 10), (-1, 10.055)]) == [0, 0])
}
/// One switch per quarter second, however fast the wheel spins (Arc: a 0.245 s burst of
/// 3-line events switched once, a 0.254 s burst twice).
- @Test func coolsDownAfterASwitch() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func coolsDownAfterASwitch() {
let burst = (0..<11).map { (CGFloat(-3), 10 + Double($0) * 0.0245) }
#expect(steps(burst).filter { $0 != 0 } == [1])
let longer = (0..<12).map { (CGFloat(-3), 10 + Double($0) * 0.023) }
@@ -59,16 +66,18 @@ struct WheelSpaceSwitchTests {
}
/// What adds up during the cooldown is dropped, so the next switch needs a flick of its own.
- @Test func theCooldownDropsWhatItSees() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func theCooldownDropsWhatItSees() {
#expect(steps([(-2, 10), (-1, 10.03), (-1, 10.06), (-1, 10.26)]) == [1, 0, 0, 0])
#expect(steps([(-2, 10), (-1, 10.26), (-1, 10.28)]) == [1, 0, 1])
}
- @Test func sidewaysDeltaOfZeroIsIgnored() {
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"))
+ func sidewaysDeltaOfZeroIsIgnored() {
#expect(steps([(-1, 10), (0, 10.02), (-1, 10.04)]) == [0, 0, 1])
}
- @Test(arguments: [
+ @Test(.bug("https://github.com/VictorKildahl/cra/issues/93"), arguments: [
// (step, index, count, inLibrary, libraryAllowed, target)
(1, 0, 3, false, true, WheelSpaceSwitch.Target.space(1)),
(-1, 2, 3, false, true, .space(1)),
diff --git a/Tests/BrowserManagerLifecycleTests.swift b/Tests/BrowserManagerLifecycleTests.swift
index 165db6a..6602f11 100644
--- a/Tests/BrowserManagerLifecycleTests.swift
+++ b/Tests/BrowserManagerLifecycleTests.swift
@@ -104,10 +104,12 @@ enum BrowserManagerLifecycleTests {
await discardCase()
shortTimerCase()
recentlyAudibleCase()
+ await audiblePageStaysAwakeCase()
devToolsCase()
await beforeUnloadCase()
nowPlayingCase()
await nowPlayingPictureInPictureCase()
+ nowPlayingSkipsPictureInPictureCase()
await leaveVideoTabPictureInPictureCase()
await splitCopySleepsPinnedTabCase()
await coveredWindowPictureInPictureCase()
@@ -247,6 +249,9 @@ enum BrowserManagerLifecycleTests {
manager.closeAll()
}
+ // promise: #2 #4
+ /// A tab open in another window moves its page over without reloading it (#2), and back to the
+ /// first window when that one is used again (#4): the same runtime, its views reattached.
@MainActor
private static func embeddedPageHandoffCase() {
_ = NSApplication.shared
@@ -581,6 +586,27 @@ enum BrowserManagerLifecycleTests {
manager.closeAll()
}
+ // promise: #28
+ /// A tab playing sound, Web Audio included (Chromium's own audible state, #28), is never put
+ /// to sleep, however long it has been out of sight, and one that starts playing while it is
+ /// being asked stays awake too.
+ @MainActor
+ private static func audiblePageStaysAwakeCase() async {
+ let store = SidebarStore()
+ let manager = BrowserManager(store: store, favicons: FaviconCache(), container: NSView())
+ manager.protectedRecentTabs = 0
+ let id = store.createTab(url: "https://example.test/playing").id
+ let runtime = manager.ensureRuntime(for: id)!
+ runtime.hiddenAt = Date.distantPast
+ runtime.browser.isAudible = true
+ manager.sleepIdleTabs(TabSleepPolicy(hiddenFor: 60))
+ manager.sleepIdleTabs(.memoryPressure)
+ expect(!runtime.browser.replies.contains { $0.method == isolatedProbe } && !asleep(manager, id),
+ "a page playing sound is never asked to sleep, on the timer or under memory pressure")
+ manager.closeAll()
+ await sleepCase("a page that starts playing while it is asked stays awake") { _, rt in rt.browser.isAudible = true }
+ }
+
/// ⌥⌘I pressed again while CEF is still closing DevTools opens them once they are gone,
/// instead of closing them a second time. Console and Network switch panels on open DevTools.
@MainActor
@@ -630,6 +656,7 @@ enum BrowserManagerLifecycleTests {
manager.closeAll()
}
+ // promise: #33
/// The sidebar player lists pages that played sound, keeps paused ones, hides the one on
/// screen, and drops a page that navigates while quiet or closes.
@MainActor
@@ -662,6 +689,30 @@ enum BrowserManagerLifecycleTests {
manager.closeAll()
}
+ // promise: #33
+ /// The sidebar player (#33) has no card for a tab whose video is in Picture in Picture; the
+ /// card comes back when the video leaves it.
+ @MainActor
+ private static func nowPlayingSkipsPictureInPictureCase() {
+ let store = SidebarStore()
+ let manager = BrowserManager(store: store, favicons: FaviconCache(), container: NSView())
+ let np = NowPlaying()
+ manager.nowPlaying = np
+ let a = store.createTab(url: "https://example.test/video").id, b = store.createTab(url: "https://example.test/other").id
+ let ra = manager.ensureRuntime(for: a)!
+ manager.show(b, focus: false)
+ ra.browser.isAudible = true
+ manager.browser(ra.browser, didChangeAudible: true)
+ expect(np.shown.map(\.id) == [a], "a tab playing out of sight has a card")
+ ra.browser.isInPictureInPicture = true
+ manager.browser(ra.browser, didChangePictureInPicture: true)
+ expect(np.shown.isEmpty && np.entries.map(\.id) == [a], "its video in Picture in Picture: no card")
+ ra.browser.isInPictureInPicture = false
+ manager.browser(ra.browser, didChangePictureInPicture: false)
+ expect(np.shown.map(\.id) == [a], "back from Picture in Picture, the card is back")
+ manager.closeAll()
+ }
+
/// The player's Picture in Picture button asks the off-screen page through the protocol, as a
/// user gesture; only a page with no video of its own (a player in an iframe) gets the
/// context menu's request.
@@ -840,6 +891,7 @@ enum BrowserManagerLifecycleTests {
manager.closeAll()
}
+ // promise: #33
/// The sidebar player in a Chromium tab: Chromium runs the page's media session handlers
/// (`Cra.mediaSession`, like Arc's media actions) and reports which it has, however early the
/// page registered them; a page without a play/pause handler has its media elements played or
diff --git a/Tests/Scenarios/open-in-space.scenario b/Tests/Scenarios/open-in-space.scenario
new file mode 100644
index 0000000..6382931
--- /dev/null
+++ b/Tests/Scenarios/open-in-space.scenario
@@ -0,0 +1,31 @@
+# promise: #168
+# cra://open?url=…&space=<space id> (#168): the link opens as a tab in that space and the window
+# goes there; background=1 adds it there and leaves the window where it is. An unknown id, or a
+# space's title instead of its id, opens it where it did before, in the space in use. Each step
+# reads which space the window shows (themeShown).
+budget rss=600 stalls50=10
+seed sidebar.json {"version":1,"spaceOrder":["A0000000-0000-0000-0000-000000000001","A0000000-0000-0000-0000-000000000002"],"spaces":[{"id":"A0000000-0000-0000-0000-000000000001","title":"Home","emoji":"🏠","theme":{"colors":["#8389FF","#8389FF"],"intensity":0.5,"noise":0,"appearance":"light","accent":"#8389FF","solid":true,"key":["#8389FF"]},"favoritesContainerID":"C0000000-0000-0000-0000-000000000011","pinnedContainerID":"C0000000-0000-0000-0000-000000000012","todayContainerID":"C0000000-0000-0000-0000-000000000013","createdAt":"2026-11-06T08:00:00Z"},{"id":"A0000000-0000-0000-0000-000000000002","title":"Work","emoji":"💼","theme":{"colors":["#8389FF","#8389FF"],"intensity":0.5,"noise":0,"appearance":"light","accent":"#8389FF","solid":true,"key":["#8389FF"]},"favoritesContainerID":"C0000000-0000-0000-0000-000000000021","pinnedContainerID":"C0000000-0000-0000-0000-000000000022","todayContainerID":"C0000000-0000-0000-0000-000000000023","createdAt":"2026-11-06T08:00:00Z"}],"items":[{"id":"C0000000-0000-0000-0000-000000000011","children":[],"isUnread":false,"createdAt":"2026-11-06T08:00:00Z","data":{"container":{"_0":{"favorites":{"spaceID":"A0000000-0000-0000-0000-000000000001"}}}}},{"id":"C0000000-0000-0000-0000-000000000012","children":[],"isUnread":false,"createdAt":"2026-11-06T08:00:00Z","data":{"container":{"_0":{"pinned":{"spaceID":"A0000000-0000-0000-0000-000000000001"}}}}},{"id":"C0000000-0000-0000-0000-000000000013","children":[],"isUnread":false,"createdAt":"2026-11-06T08:00:00Z","data":{"container":{"_0":{"today":{"spaceID":"A0000000-0000-0000-0000-000000000001"}}}}},{"id":"C0000000-0000-0000-0000-000000000021","children":[],"isUnread":false,"createdAt":"2026-11-06T08:00:00Z","data":{"container":{"_0":{"favorites":{"spaceID":"A0000000-0000-0000-0000-000000000002"}}}}},{"id":"C0000000-0000-0000-0000-000000000022","children":[],"isUnread":false,"createdAt":"2026-11-06T08:00:00Z","data":{"container":{"_0":{"pinned":{"spaceID":"A0000000-0000-0000-0000-000000000002"}}}}},{"id":"C0000000-0000-0000-0000-000000000023","children":[],"isUnread":false,"createdAt":"2026-11-06T08:00:00Z","data":{"container":{"_0":{"today":{"spaceID":"A0000000-0000-0000-0000-000000000002"}}}}}]}
+cra://open?url=${PAGE}?n=home
+wait 2
+cra://debug?themeShown=start
+expect-log Cra theme shown start: space=Home
+cra://open?url=${PAGE}?n=work-background&space=A0000000-0000-0000-0000-000000000002&background=1
+wait 2
+cra://debug?themeShown=background
+expect-log Cra theme shown background: space=Home
+cra://open?url=${PAGE}?n=work&space=A0000000-0000-0000-0000-000000000002
+wait 2
+cra://debug?themeShown=work
+expect-log Cra theme shown work: space=Work
+cra://open?url=${PAGE}?n=unknown&space=A0000000-0000-0000-0000-000000000009
+wait 2
+cra://debug?themeShown=unknown
+expect-log Cra theme shown unknown: space=Work
+cra://open?url=${PAGE}?n=title&space=Home
+wait 2
+cra://debug?themeShown=title
+expect-log Cra theme shown title: space=Work
+cra://open?url=${PAGE}?n=home-again&space=A0000000-0000-0000-0000-000000000001
+wait 2
+cra://debug?themeShown=home-again
+expect-log Cra theme shown home-again: space=Home
diff --git a/Tests/StoreTests.swift b/Tests/StoreTests.swift
index 541951c..2f98d0a 100644
--- a/Tests/StoreTests.swift
+++ b/Tests/StoreTests.swift
@@ -40,6 +40,9 @@ enum StoreTests {
try arcSpacesWithoutAThemeShareOneDefault()
tidyTabs()
pinHook()
+ dropOnPinnedTabSplits()
+ reopenClosedTabs()
+ windowsShareTheSidebar()
print("Store: \(checks) checks passed")
}
@@ -454,6 +457,7 @@ enum StoreTests {
expect(store.item(eks.id)?.tab?.faviconKey == eksIcon, "and the other tab never changes")
}
+ // promise: #54
/// Edit Pinned URL… (#54, PR #55 by Anoninz): a new pinned URL keeps the item's
/// name, icon, colour and place, and survives a relaunch.
@MainActor
@@ -508,6 +512,7 @@ enum StoreTests {
expect(store.integrityProblems().isEmpty, "and the sidebar stays sound")
}
+ // promise: #157
/// Arc's "Drag to add Favorites" card (#157): its × closes it for that space's favorites only,
/// for good, and readers see the change.
@MainActor
@@ -530,6 +535,7 @@ enum StoreTests {
"and it stays closed after a relaunch")
}
+ // promise: #154
/// Settings ▸ Tabs ▸ Share Favorites (#154): Arc's one favorites list per profile.
@MainActor
private static func sharedFavorites() {
@@ -641,6 +647,7 @@ enum StoreTests {
store.deleteProfile(paths.id)
}
+ // promise: #86
/// Move Tab to Space N (#86) and the command bar's Move Tab to <space>, like Arc's "Move to
/// Today in <space>": the tab goes to the top of the other space's Today, the window follows
/// it there with the tab selected, and the space it left opens another tab.
@@ -718,6 +725,7 @@ enum StoreTests {
expect(store.integrityProblems().isEmpty, "the sidebar stays sound")
}
+ // promise: #105
/// The tab shown after ⌘W (Arc 1.171, GitHub #105): the one shown before while its page is
/// loaded, else the Today neighbour above (below at the top), else nothing; it reads as read.
@MainActor
@@ -863,6 +871,7 @@ enum StoreTests {
expect(store.closeSuccessor(ofPinned: pl.id, window: main) == nil, "a pinned split hands over to nothing (Arc)")
}
+ // promise: #85
/// A closed folder keeps its open tab in sight (Arc, GitHub #85): picking a tab two closed
/// folders down lists it under the outer one without opening either.
@MainActor
@@ -1004,6 +1013,81 @@ enum StoreTests {
expect(heard == [a.id, a.id], "pinning it again does")
}
+ // promise: #191
+ /// A tab dropped on a pinned tab makes a split, as on a Today tab (Arc, #191): the pinned tab
+ /// stays pinned where it was, and the split opens at the top of Today with the dropped tab on
+ /// the side it was dropped and a copy of the pinned page beside it.
+ @MainActor
+ private static func dropOnPinnedTabSplits() {
+ let store = AppComposition(clock: ManualScheduler()).store
+ let sid = store.createSpace(title: "Drop", emoji: "🪂").id
+ guard let space = store.space(sid) else { return expect(false, "the space is made") }
+ let pinned = store.createTab(url: "https://example.com/pinned", title: "Pinned", in: sid, pinned: true, select: false)
+ let older = store.createTab(url: "https://example.com/older", in: sid, select: false)
+ let dragged = store.createTab(url: "https://example.com/dragged", in: sid, select: false)
+ let pinnedOrder = store.children(of: space.pinnedContainerID).map(\.id)
+ // What the list does with a drop on the left half of the pinned row: .split(with: pinned, leading: true).
+ guard let split = store.createSplit(with: [dragged.id, pinned.id], at: pinned.id) else { return expect(false, "the drop makes a split") }
+ expect(store.isPinned(pinned.id) && store.children(of: space.pinnedContainerID).map(\.id) == pinnedOrder,
+ "the pinned tab stays pinned, in its place")
+ expect(store.children(of: space.todayContainerID).map(\.id) == [split.id, older.id], "the split opens at the top of Today")
+ let panes = store.children(of: split.id)
+ expect(panes.count == 2 && panes[0].id == dragged.id && panes[1].id != pinned.id
+ && panes[1].tab?.url == "https://example.com/pinned" && store.paneID(for: pinned.id, in: split) == panes[1].id,
+ "the dropped tab takes the side it was dropped on, a copy of the pinned page the other")
+ expect(store.integrityProblems().isEmpty, "and the sidebar stays sound")
+ }
+
+ // promise: #21
+ /// ⌘Z (Arc, #21) brings back the tab closed last, open, then the one closed before it, each
+ /// where it was: a pinned tab closed with its ✕ comes back pinned.
+ @MainActor
+ private static func reopenClosedTabs() {
+ let store = AppComposition(clock: ManualScheduler()).store
+ let sid = store.createSpace(title: "Undo", emoji: "↩️").id
+ guard let space = store.space(sid) else { return expect(false, "the space is made") }
+ let pinned = store.createTab(url: "https://example.com/undo-pinned", in: sid, pinned: true, select: false)
+ let first = store.createTab(url: "https://example.com/undo-first", in: sid)
+ let second = store.createTab(url: "https://example.com/undo-second", in: sid)
+ store.archiveTab(pinned.id, reason: .manual)
+ store.archiveTab(first.id, reason: .manual)
+ store.archiveTab(second.id, reason: .manual)
+ expect(store.reopenLastArchived()?.id == second.id && store.selectedTabID == second.id
+ && store.spaceID(ofItem: second.id) == sid && !store.isPinned(second.id),
+ "⌘Z brings back the tab closed last, in its space's Today, open")
+ expect(store.reopenLastArchived()?.id == first.id && store.selectedTabID == first.id, "again: the one closed before it")
+ expect(store.reopenLastArchived()?.id == pinned.id && store.isPinned(pinned.id)
+ && store.children(of: space.pinnedContainerID).map(\.id) == [pinned.id], "a pinned tab comes back pinned")
+ expect(store.integrityProblems().isEmpty, "and the sidebar stays sound")
+ }
+
+ // promise: #2 #4
+ /// ⌘N (#2): a new window opens on the space in use, every window lists the same tabs, and
+ /// each window shows a space of its own. A tab open in two windows stays selected in both (#4).
+ @MainActor
+ private static func windowsShareTheSidebar() {
+ let store = AppComposition(clock: ManualScheduler()).store
+ let home = store.createSpace(title: "Windows Home", emoji: "🏠").id
+ let work = store.createSpace(title: "Windows Work", emoji: "💼", focus: false).id
+ let first = store.activeWindowID
+ let tab = store.createTab(url: "https://example.com/both-windows", in: home, window: first)
+ let second = store.addWindow(spaceID: store.focusedSpaceID(window: first), frame: nil).id
+ expect(store.focusedSpaceID(window: second) == home, "a new window opens on the space in use")
+ let made = store.createTab(url: "https://example.com/second-window", window: second)
+ let today = store.space(home)!.todayContainerID
+ expect(store.spaceID(ofItem: made.id) == home && store.tabs(under: today).map(\.id).contains(made.id),
+ "a tab opened in the new window is in the space's Today, which the first window shows too")
+ store.selectTab(tab.id, window: second)
+ expect(store.selectedTabID(in: home, window: second) == tab.id && store.selectedTabID(in: home, window: first) == tab.id,
+ "a tab opened in the second window stays selected in the first (#4)")
+ store.focusSpace(work, window: second)
+ expect(store.focusedSpaceID(window: second) == work && store.focusedSpaceID(window: first) == home
+ && store.selectedTabID(in: home, window: first) == tab.id, "each window shows a space of its own")
+ store.removeWindow(second)
+ expect(store.item(tab.id) != nil && store.item(made.id) != nil, "closing a window keeps the tabs")
+ expect(store.integrityProblems().isEmpty, "and the sidebar stays sound")
+ }
+
private static func expect(_ condition: @autoclosure () -> Bool, _ message: String) {
guard condition() else {
FileHandle.standardError.write(Data("FAIL: \(message)\n".utf8))
diff --git a/Tests/promises.lock b/Tests/promises.lock
index 452fa5c..00e810b 100644
--- a/Tests/promises.lock
+++ b/Tests/promises.lock
@@ -1,66 +1,84 @@
# Tests that pin what a closed issue shipped (scripts/promises.py). Each line: issue, test, hash
# of its code. Change a test here only when the promise changes on purpose: name the issue and why
# in the commit, and tell its reporter. Regenerate with scripts/promises.py --update.
-#24 Packages/CraCore/Tests/CraCoreTests/ShippedThemesTests.swift::edgeToEdgeIsOffUnlessChosen 96da512d440f
-#24 Tests/FloatingSidebarTests.swift::geometry be69a5b5124d
-#30 Packages/CraCore/Tests/CraCoreTests/ArcThemeImportTests.swift::solidThemeKeepsItsColour 02956e3cc1bb
-#30 Packages/CraCore/Tests/CraCoreTests/ArcThemeImportTests.swift::unknownStyleFallsBackToThePalettesMidTone 33d9d79c196b
-#30 Tests/Scenarios/solid-spaces.scenario 69283ced9624
-#30 Tests/StoreTests.swift::arcSpacesWithoutAThemeShareOneDefault f642318e5d34
-#46 Tests/BrowserManagerLifecycleTests.swift::pageColoursCase ac9d2aee01ca
-#50 Packages/CraCore/Tests/CraCoreTests/ToolbarCompositionTests.swift::theFullBar 53b4dec5d2fb
-#50 Packages/CraCore/Tests/CraCoreTests/ToolbarCompositionTests.swift::theShownSidebarCarriesTheToggle 083c181ed9ac
-#50 Tests/CommandBarGlyphTests.swift::leadingGlyph 3e90bfdbd048
-#50 Tests/Scenarios/toolbar-chrome.scenario 1fa8505c4e49
-#80 Packages/CraCore/Tests/CraCoreTests/DisplayDiagnosticsTests.swift::differentTopRatesAreMixed e6736f0fff82
-#80 Packages/CraCore/Tests/CraCoreTests/DisplayDiagnosticsTests.swift::fixedRateDisplayShowsOneRate 7c3babaccb16
-#80 Packages/CraCore/Tests/CraCoreTests/DisplayDiagnosticsTests.swift::intervalsBecomeWholeHertz 7fba8a629c39
-#80 Packages/CraCore/Tests/CraCoreTests/DisplayDiagnosticsTests.swift::sameTopRateOrUnknownIsNotMixed c1cf7d725296
-#80 Packages/CraCore/Tests/CraCoreTests/DisplayDiagnosticsTests.swift::variableRateDisplayShowsItsRange bd4f54224644
-#80 Tests/BrowserManagerLifecycleTests.swift::pageProbeCase 6cd5b47ee6e3
-#83 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::fullscreenSwapsTheBlurForTheDesktopTint dbfce1b4413d
-#83 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::lightVibrantThemesKeepTheirCalibration 71fe23c0c000
-#83 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::logLineNamesTheState 16b128ce2bbf
-#84 Packages/CraCore/Tests/CraCoreTests/ToolbarColorTests.swift::reportedThenRememberedThenWhite ab391410bce9
-#84 Tests/BrowserManagerLifecycleTests.swift::pageColoursCase ac9d2aee01ca
-#88 Packages/CraCore/Tests/CraCoreTests/DismissingClickTests.swift::closedWithoutAClick a2593763fe16
-#88 Packages/CraCore/Tests/CraCoreTests/DismissingClickTests.swift::theClosingClickDoesNotReopen 3300c4839f6d
-#88 Packages/CraCore/Tests/CraCoreTests/DismissingClickTests.swift::theNextClickOpens 9cf0eeb51035
-#88 Packages/CraCore/Tests/CraCoreTests/SidebarModelTests.swift::sidebarSubtitle 514765ca8908
-#88 Packages/CraCore/Tests/CraCoreTests/SidebarModelTests.swift::toolbarShowsTheHostOnlyUnlessAsked f6ce32167e2f
-#88 Packages/CraCore/Tests/CraCoreTests/ToolbarCompositionTests.swift::theDeveloperBar 74ae28676b62
-#88 Tests/PolicyTests.swift::devToolsToggle 5786fe494c6e
-#88 Tests/Scenarios/toolbar-chrome.scenario 1fa8505c4e49
-#132 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::fullscreenSwapsTheBlurForTheDesktopTint dbfce1b4413d
-#132 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::logLineNamesTheState 16b128ce2bbf
-#132 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::solidThemesBlurWhileActiveAndGoFlatWhileInactive d974cca84f6e
-#152 Packages/CraCore/Tests/CraCoreTests/KeyChordTests.swift::capsSplitTheDisplay 8672a7488fff
-#152 Packages/CraCore/Tests/CraCoreTests/ShippedThemesTests.swift::cloudDevTipTakesArcsTones 9ffad78d3b27
-#152 Packages/CraCore/Tests/CraCoreTests/ThemeTonesTests.swift::shadedDarkKeepsTheHueAtTenPercentLuminance 5f3b98ef816d
-#152 Packages/CraCore/Tests/CraCoreTests/ThemeTonesTests.swift::tonesAreArcsPaletteSlots 53cd2a932167
-#152 Packages/CraCore/Tests/CraCoreTests/ThemeTonesTests.swift::victorsThemeRebuildsArcsShade 2d1eddcfe6e1
+#2 Tests/BrowserManagerLifecycleTests.swift::embeddedPageHandoffCase 81c5bd4fc4f4
+#2 Tests/StoreTests.swift::windowsShareTheSidebar 9d351f248862
+#4 Tests/BrowserManagerLifecycleTests.swift::embeddedPageHandoffCase 81c5bd4fc4f4
+#4 Tests/StoreTests.swift::windowsShareTheSidebar 9d351f248862
+#12 Packages/CraCore/Tests/CraCoreTests/FavoritesLayoutTests.swift::fourFavoritesMatchArc 5b32a86494ff
+#12 Packages/CraCore/Tests/CraCoreTests/PeekTriggerTests.swift::pinnedTabPeeksAtOtherHosts 78eb016aceed
+#12 Packages/CraCore/Tests/CraCoreTests/PeekTriggerTests.swift::shiftClickPeeksFromAnyTab 894f7cc98ad5
+#12 Packages/CraCore/Tests/CraCoreTests/PeekTriggerTests.swift::todayTabsLoadUnlessEveryTabIsOn 1da8b221f2dc
+#12 Packages/CraCore/Tests/CraCoreTests/ShippedSidebarTests.swift::peekOptionsDefaultToArcs d9ae2dbf0f29
+#21 Tests/StoreTests.swift::reopenClosedTabs 1b97b17bcf25
+#28 Tests/BrowserManagerLifecycleTests.swift::audiblePageStaysAwakeCase 662b3dabe041
+#29 Packages/CraCore/Tests/CraCoreTests/FavoritesLayoutTests.swift::columnsByCountMatchArc 9ab00f8c8434
+#33 Tests/BrowserManagerLifecycleTests.swift::nowPlayingCase 896f39d0c04e
+#33 Tests/BrowserManagerLifecycleTests.swift::nowPlayingSkipsPictureInPictureCase df2bec09cf49
+#33 Tests/BrowserManagerLifecycleTests.swift::playerMediaSessionCase 70013060dd84
+#47 Packages/CraCore/Tests/CraCoreTests/ShippedSidebarTests.swift::newTabRowLeadsToday 9d7d6f680abe
+#49 Packages/CraCore/Tests/CraCoreTests/TabSearchScopeTests.swift::noTabsNoRows c4ea01d1f480
+#49 Packages/CraCore/Tests/CraCoreTests/TabSearchScopeTests.swift::nothingTypedListsByRecency 535e122471df
+#49 Packages/CraCore/Tests/CraCoreTests/TabSearchScopeTests.swift::percentAloneOffersTheScope dce33dc44297
+#49 Packages/CraCore/Tests/CraCoreTests/TabSearchScopeTests.swift::typedRanksByMatchThenRecency baeabb72626c
+#54 Tests/StoreTests.swift::pinnedURL 83caea3b3e16
+#85 Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift::aClickOnAPeekedFolderClosesIt 24a4f57dacd5
+#85 Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift::closingATabDropsItFromEveryPeek ec91340a5580
+#85 Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift::listedRowsFollowTheSidebarAndSkipTabsThatLeft 225937730d3a
+#85 Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift::openingATabInClosedFoldersPeeksItUnderTheOutermost 1350dd0a01f0
+#85 Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift::openingATabInOpenFoldersPeeksNothing b31730025693
+#85 Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift::openingTheFolderDropsItsPeekClosingKeepsTheOpenTab d89a10784f95
+#85 Packages/CraCore/Tests/CraCoreTests/FolderPeekTests.swift::outermostClosedFolderHostsTheTab 8a27ba632a92
+#85 Packages/CraCore/Tests/CraCoreTests/KeyChordTests.swift::commandReturn 8915403f4ea9
+#85 Tests/StoreTests.swift::folderPeek 881cfa7358e9
+#86 Tests/StoreTests.swift::moveTabToSpace dbeb51b2193b
+#92 Packages/CraCore/Tests/CraCoreTests/SpaceWindowTests.swift::aWindowShowingTheSpaceTakesThePage 390d2d0bee66
+#92 Packages/CraCore/Tests/CraCoreTests/SpaceWindowTests.swift::otherwiseTheWindowInUseLastSwitches 2d5ce0f25d2c
+#92 Packages/CraCore/Tests/CraCoreTests/SpaceWindowTests.swift::severalWindowsOnTheSpace 05f1c8e148fa
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::aFlickSwitches 9a08a5bcb84b
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::aPauseForgets db51661cda31
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::aTurnCancelsOut ceae2e8e3adf
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::coolsDownAfterASwitch ad96a1e74d39
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::directionFollowsTheSwipe 97f5e60f59ad
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::naturalScrollingPagesTheSameWay e995be70a20f
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::oneSlowNotchDoesNothing cf9da6771638
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::pagesLikeASwipeWithoutWrapping b13c899ca70e
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::sidewaysDeltaOfZeroIsIgnored 0895de69c11e
+#93 Packages/CraCore/Tests/CraCoreTests/WheelSpaceSwitchTests.swift::theCooldownDropsWhatItSees 7bbdde00bed3
+#105 Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift::aPinnedSplitHandsOverToNothing 14f062585d10
+#105 Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift::aPreviousTabWithoutAPageDoesNotCount 7e52205db07d
+#105 Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift::backToTheTabShownBeforeWhileItHasAPage 4d2a7299a2cf
+#105 Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift::theClosingTabIsNeverItsOwnSuccessor 0806d70756c6
+#105 Packages/CraCore/Tests/CraCoreTests/CloseSuccessorTests.swift::theNeighbourAboveThenBelow dc125040991f
+#105 Tests/StoreTests.swift::closeSuccessor e120a628d3be
+#139 Packages/CraCore/Tests/CraCoreTests/SidebarCloseTests.swift::commandW 7dbc0ee8396c
+#139 Packages/CraCore/Tests/CraCoreTests/SidebarCloseTests.swift::splitRows 54f8abac7a61
+#139 Packages/CraCore/Tests/CraCoreTests/SidebarCloseTests.swift::tabRows 4a5bf2b97c09
+#139 Packages/CraCore/Tests/CraCoreTests/SidebarModelTests.swift::returningHomeShowsTheHomesNameAndIcon 42a76c8e9cff
+#139 Packages/CraCore/Tests/CraCoreTests/SidebarModelTests.swift::sidebarSubtitle 6d9802f25217
+#154 Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift::aProfilesListIsReused 56b12941287c
+#154 Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift::eachProfileGetsOneListOfItsSpacesFavorites 5ef6f88b9e36
+#154 Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift::keys c19e757f0423
+#154 Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift::listsRoundTrip fae9338a3816
+#154 Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift::offAndOnAgainChangesNothing f7af2a60b7bf
+#154 Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift::settingIsOffUntilTurnedOn bec1ff33d052
+#154 Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift::sharedListsStayPut c4b4ba09fce7
+#154 Packages/CraCore/Tests/CraCoreTests/FavoritesSharingTests.swift::twoOfAPageInOneSpaceBothStay 95492abd0d48
+#154 Tests/StoreTests.swift::sharedFavorites db5eca7d0a92
#155 Packages/CraCore/Tests/CraCoreTests/ArcThemeImportTests.swift::autoShowsTheHalfMacOSAsksFor 73a172a01086
#155 Packages/CraCore/Tests/CraCoreTests/ArcThemeImportTests.swift::everySwatchOnAutoFollowsMacOS 2abd1f76b828
#155 Packages/CraCore/Tests/CraCoreTests/ArcThemeImportTests.swift::everySwatchOnLightOrDarkKeepsOneLook 95d16ff2c954
#155 Packages/CraCore/Tests/CraCoreTests/ModelFixtureTests.swift::autoSpacesKeepBothHalves 89e5047a5e96
#155 Packages/CraCore/Tests/CraCoreTests/SpaceColorPresetsTests.swift::newSpaceIsOneColourOnAuto 32095d76196a
#155 Tests/Scenarios/auto-theme.scenario ecf687c1ce39
-#156 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::activeLookFollowsTheWindowLikeAppKit d175c47f026e
-#156 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::floatingSidebarDropsItsLiftUnderReduceTransparency 74009e2249b1
-#156 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::fullScreenWindowKeepsAppKitsActiveAppearance 15325dadc104
-#156 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::logLineNamesTheState 16b128ce2bbf
-#156 Packages/CraCore/Tests/CraCoreTests/SidebarBackdropTests.swift::reduceTransparencyNeverShowsACapture af6fa6d2d572
-#170 Packages/CraCore/Tests/CraCoreTests/ShippedThemesTests.swift::newSpaceStartsOnOneBrandColour 37cb20e10c4b
-#170 Packages/CraCore/Tests/CraCoreTests/ShippedThemesTests.swift::oneColourIsSavedLikeAnArcSingleImport c847f6695226
-#170 Packages/CraCore/Tests/CraCoreTests/SpaceColorPresetsTests.swift::brandPairs 9ae9693433ba
-#170 Packages/CraCore/Tests/CraCoreTests/SpaceColorPresetsTests.swift::catalogColours 3739d0009dc7
-#170 Packages/CraCore/Tests/CraCoreTests/SpaceColorPresetsTests.swift::pageOfAKey 1030ea02929f
-#170 Packages/CraCore/Tests/CraCoreTests/SpaceColorPresetsTests.swift::pages c20880c3012c
+#157 Tests/StoreTests.swift::favoritesEmptyState d14897207ce4
+#168 Tests/Scenarios/open-in-space.scenario 9f2fdc2279a0
#170 Tests/StoreTests.swift::themePreview d10606ab1689
-#171 Packages/CraCore/Tests/CraCoreTests/ArcThemeImportTests.swift::appearanceBasedWithOneHalfKeepsIt 8c8e340cb468
#171 Packages/CraCore/Tests/CraCoreTests/ArcThemeImportTests.swift::autoThemeWithOneHalfKeepsItsLook 6162547ce294
-#171 Packages/CraCore/Tests/CraCoreTests/ArcThemeImportTests.swift::singleWithoutAppearanceKeepsItsSide 90d071ca989c
-#205 Packages/CraCore/Tests/CraCoreTests/ModelFixtureTests.swift::stackedSpaceIconLoadsAsItsSymbol b4a6c64e1ddc
-#205 Packages/CraCore/Tests/CraCoreTests/SpaceIconTests.swift::iconsNeverStack 7ffc5abe0004
-#205 Packages/CraCore/Tests/CraCoreTests/SpaceIconTests.swift::readingTheStoredPair 517e549811b6
-#205 Packages/CraCore/Tests/CraCoreTests/SpaceIconTests.swift::savingTheIconItReadsChangesNothing d7e745d4f478
+#176 Packages/CraCore/Tests/CraCoreTests/FavoritesLayoutTests.swift::slotUnderThePointer bb151154628a
+#176 Packages/CraCore/Tests/CraCoreTests/FavoritesLayoutTests.swift::tilesMoveAlongPastTheOpenSlot e3dab87749f3
+#183 Packages/CraCore/Tests/CraCoreTests/LinkMenuTests.swift::defaultSwitchesToTheNewTabLikeArc 169e27801cfa
+#183 Packages/CraCore/Tests/CraCoreTests/LinkMenuTests.swift::settingIsOffForSettingsWithoutIt 6d661c8bddc5
+#183 Packages/CraCore/Tests/CraCoreTests/LinkMenuTests.swift::settingOnKeepsThePageInFrontAndOffersTheSwitch 9086830db26d
+#183 Packages/CraCore/Tests/CraCoreTests/ShippedSidebarTests.swift::backgroundLinksSettingIsKept f4c02e2bd336
+#191 Tests/StoreTests.swift::dropOnPinnedTabSplits ac72302089d5