Skip to content

armgit / cra

Public Imported from GitHub
0

The open-source Arc replacement for macOS. Spaces, pinned tabs, split view, Little Windows and Arc's shortcuts on Chromium, with your Arc sidebar imported in one go.

promises: a commented-out call doesn't count as running a locked harness test

Victor7dd12edcf5c6
diff --git a/scripts/promises.py b/scripts/promises.py
index eefa972..ec2a0c4 100755
--- a/scripts/promises.py
+++ b/scripts/promises.py
@@ -138,7 +138,7 @@ def promises(rev=None):
sys.exit(f"promises: {rel}: a `// promise:` line with no func right below it")
body_end = balanced(s, s.index("{", fn.end()), "{", "}")
# A harness runs only what its main() calls: a promise nobody calls proves nothing.
- if len(re.findall(r"\b%s\s*\(" % fn.group(1), s)) < 2:
+ if len(re.findall(r"\b%s\s*\(" % fn.group(1), re.sub(r"//[^\n]*", "", s))) < 2:
sys.exit(f"promises: {rel}::{fn.group(1)} is a promise that nothing calls")
for issue in sorted({int(n) for n in re.findall(r"\d+", m.group(1))}):
found.append((issue, f"{rel}::{fn.group(1)}", digest(s[fn.start():body_end])))