Skip to content

armgit / cra

Public Imported from GitHub
0

The open-source Arc replacement for macOS. Spaces, pinned tabs, split view, Little Windows and Arc's shortcuts on Chromium, with your Arc sidebar imported in one go.

Favorites empty card shows its top dashed edge, as in Arc

Victore946ea264269
diff --git a/Sources/Cra/UI/Sidebar/List/SpaceColumnView.swift b/Sources/Cra/UI/Sidebar/List/SpaceColumnView.swift
index 1edc23f..a93974f 100644
--- a/Sources/Cra/UI/Sidebar/List/SpaceColumnView.swift
+++ b/Sources/Cra/UI/Sidebar/List/SpaceColumnView.swift
@@ -845,7 +845,7 @@ final class FavoritesDropStrip: FavoritesDropTarget {
/// "Drag to add Favorites" and a line on what they are, in the space's own ink. It takes a dragged
/// tab, and its × (sidebarFavoritesEmptyStateDismissButton) closes it for good. Measured at 2x:
/// the fill sits where the first tile would (8 pt in, 12 pt corners) and is 93.5 pt tall; a 1 pt
-/// dashed line (5.5 on, 4.5 off) runs just outside it; the header goes 4 pt further down than
+/// dashed line (5.5 on, 4.5 off) runs just outside it (in Cra, on its edge: see layout); the header goes 4 pt further down than
/// under a row of tiles. No hover state; a tab dragged over it makes the line solid, lightens the
/// fill and dims the rest to half.
final class FavoritesEmptyCard: FavoritesDropTarget {
@@ -927,7 +927,10 @@ final class FavoritesEmptyCard: FavoritesDropTarget {
fill.frame = bounds
border.frame = bounds
fill.path = CGPath(roundedRect: card, cornerWidth: 12, cornerHeight: 12, transform: nil)
- border.path = CGPath(roundedRect: card.insetBy(dx: -0.5, dy: -0.5), cornerWidth: 12.5, cornerHeight: 12.5, transform: nil)
+ // Arc's line runs just outside the fill, but the card sits at the top of the space pager,
+ // which clips its pages for swipes, so a line outside the fill loses its top edge. It runs
+ // on the fill's outer point instead, 1 pt in from Arc's.
+ border.path = CGPath(roundedRect: card.insetBy(dx: 0.5, dy: 0.5), cornerWidth: 11.5, cornerHeight: 11.5, transform: nil)
content.frame = card
// Arc's centres and frames, from the fill's top-left: badge centre 19.75 pt down, title 33.5–49.5,
// subtitle 53–83 (two 15 pt lines, 150 pt wide), × centred 15 pt in from the top-right corner.
diff --git a/docs/arc-reverse-engineering.md b/docs/arc-reverse-engineering.md
index 2e52923..4208f51 100644
--- a/docs/arc-reverse-engineering.md
+++ b/docs/arc-reverse-engineering.md
@@ -910,7 +910,9 @@ Observed live on a throwaway Today split (example.com | example.org), archived a
in Split View, Duplicate, Move to, New Folder with 2 Items, Archive Tabs…).
- [?] Not measured: the drag-over fill on a dark theme, coloured dark themes (the star's colour there), 1x.
- Cra: FavoritesEmptyCard, dismissed per favorites container (WindowPrefs.favoritesEmptyStateDismissed, since
- Cra's favorites are per space). Badge, title, subtitle and × land within 1 px of Arc's at 2x.
+ Cra's favorites are per space). Badge, title, subtitle and × land within 1 px of Arc's at 2x. The dashed line
+ runs on the fill's outer point, not just outside it: the card sits at the top of the space pager, which clips,
+ so a line outside the fill lost its top edge.
### Space header row (Arc 1.171, live, 1 Nov, issue #39)
- [O] At rest: the space icon, then the title; nothing else. A space with an emoji shows it (the issue's