Skip to content

Craft Anything: understand how any software works, and craft your own.

Rust

Warn an agent before setup drops a client's --all-tools (#1064)

istarsd784d0a609b3
diff --git a/crates/setup/src/skill.md b/crates/setup/src/skill.md
index df246b88..e444d68e 100644
--- a/crates/setup/src/skill.md
+++ b/crates/setup/src/skill.md
@@ -2,7 +2,7 @@
name: craft-anything
description: Investigate how shipped software works (programs, apps, packages, firmware, web bundles) with evidence-backed answers through the Craft Anything MCP tools, keeping a durable brief, plan, hypotheses, findings and handoff in the project.
metadata:
- version: "1"
+ version: "2"
---
# Craft Anything: evidence-first investigation
@@ -20,6 +20,14 @@ instead; that is faster and more direct.
- If the tools are missing or failing to start, run `craft-anything-cli doctor` and then
`craft-anything-cli setup --dry-run` and show the user the plan before applying anything. After a
successful setup the user must restart or reconnect their app.
+- **Never run `setup --yes` (or `setup --client …`) on an entry that already lists every tool.**
+ `setup` writes the plain `mcp` command, so it drops an `--all-tools` that is already in the entry
+ and the server falls back to the small core toolset instead of the whole list. `doctor` calls such
+ an entry "a different copy or shape of the command" and then suggests exactly that command, so
+ the warning is not a reason to run it. Read the client's config file first: if the `args` of
+ `craft-anything` end in `--all-tools`, leave the entry alone. `setup --dry-run` only prints the
+ plan and changes nothing, so that one is safe to run. To add a client, write the entry by hand
+ with `--all-tools`.
- Only a small core toolset is listed at first. Call `list_toolsets` to see the others and
`enable_toolset` to switch one on (native code, Android, Apple, web, runtime…).
- In Clean room (Deep mode off, the default) nothing inside a target is read: only the tools that
diff --git a/crates/setup/src/skill.rs b/crates/setup/src/skill.rs
index a980c49c..f76e6fe7 100644
--- a/crates/setup/src/skill.rs
+++ b/crates/setup/src/skill.rs
@@ -7,7 +7,7 @@ use std::path::{Path, PathBuf};
/// Folder name under each skills directory.
pub const SKILL_DIR: &str = "craft-anything";
/// Bumped whenever the skill text changes.
-pub const SKILL_VERSION: &str = "1";
+pub const SKILL_VERSION: &str = "2";
/// How an installed SKILL.md identifies itself as ours.
pub const SKILL_PREFIX: &str = "---\nname: craft-anything\n";
const REFERENCE_MARKER: &str = "<!-- craft-anything skill reference -->";
diff --git a/docs/ROADMAP.md b/docs/ROADMAP.md
index f045768e..3cca23e5 100644
--- a/docs/ROADMAP.md
+++ b/docs/ROADMAP.md
@@ -776,6 +776,11 @@ Owner: open · Status: in progress
going through our server — claimed: 0231071, branch `feature/dsh-agent-adapter`
- [ ] DeepSeek Harness: no resume (its headless profile keeps no session), a build on the harness's
desktop profile is untried, and the task still goes over in argv (see the argv note above)
+- [ ] `setup` writes the plain `mcp` command, so it drops an `--all-tools` an entry already has, and
+ `doctor` then calls that entry "a different copy or shape of the command" and suggests the very
+ command that breaks it. The installed skill now warns against running `setup` on such an entry;
+ `doctor` and `setup` should keep the person's extra arguments instead
+ — claimed: 18923837179wjt-dot, branch fix/setup-skill-warns-before-setup-drops-all-tools
### R2.4 Runtime study for apps and games (with consent)
Owner: maintainers · Status: in progress