Skip to content

Crawlee—A web scraping and browser automation library for Node.js to build reliable crawlers. In JavaScript and TypeScript. Extract data for AI, LLMs, RAG, or GPTs. Download HTML, PDF, JPG, PNG, and other files from websites. Works with Puppeteer, Playwright, Cheerio, JSDOM, and raw HTTP. Both headful and headless mode. With proxy rotation.

Fix almost all hanging tests

Ondra Urban2b4d6355b32e
diff --git a/package.json b/package.json
index 69726bcf7..5921da104 100644
--- a/package.json
+++ b/package.json
@@ -41,7 +41,7 @@
"build": "rm -rf ./build && babel src --out-dir build",
"build-docs": "npm run clean && npm run build && node ./website/tools/build_docs.js",
"build-readme": "node ./tools/build_readme.js",
- "test": "npm run build && nyc --reporter=html --reporter=text mocha --timeout 60000 --compilers js:babel-core/register --recursive",
+ "test": "npm run build && nyc --reporter=html --reporter=text mocha --timeout 60000 --require babel-core/register --recursive --exit",
"prepare": "npm run build",
"prepublishOnly": "(test $RUNNING_FROM_SCRIPT || (echo \"You must use publish.sh instead of 'npm publish' directly!\"; exit 1)) && npm test && npm run lint",
"clean": "rm -rf build",
diff --git a/src/puppeteer_live_view_server.js b/src/puppeteer_live_view_server.js
index b41ecbc62..c2ea52cd6 100644
--- a/src/puppeteer_live_view_server.js
+++ b/src/puppeteer_live_view_server.js
@@ -310,7 +310,10 @@ export default class PuppeteerLiveViewServer extends EventEmitter {
addBrowser(browser) {
this.browsers.add(browser);
this.emit('browsercreated', browser);
- browser.on('disconnected', () => this.deleteBrowser(browser));
+ browser.on('disconnected', () => {
+ this.deleteBrowser(browser);
+ if (!this.browsers.size) this.httpServer.close();
+ });
}
/**