Skip to content

Crawlee—A web scraping and browser automation library for Node.js to build reliable crawlers. In JavaScript and TypeScript. Extract data for AI, LLMs, RAG, or GPTs. Download HTML, PDF, JPG, PNG, and other files from websites. Works with Puppeteer, Playwright, Cheerio, JSDOM, and raw HTTP. Both headful and headless mode. With proxy rotation.

chore: remove unused eslint ignore comments

Martin Adámek5d372cbeade2
diff --git a/src/actor.js b/src/actor.js
index 57f9ae196..f461345f1 100644
--- a/src/actor.js
+++ b/src/actor.js
@@ -17,7 +17,7 @@ import {
} from './utils';
import { maybeStringify } from './storages/key_value_store';
-// eslint-disable-next-line import/named,no-unused-vars,import/first
+// eslint-disable-next-line import/named,no-unused-vars
import { ActorRun } from './typedefs';
import { ApifyCallError } from './errors';
@@ -472,7 +472,6 @@ export const callTask = async (taskId, input, options = {}) => {
if (isRunUnsuccessful(run.status)) {
// TODO It should be callTask in the message, but I'm keeping it this way not to introduce a breaking change.
- // eslint-disable-next-line max-len
const message = `The actor task ${taskId} invoked by Apify.call() did not succeed. For details, see https://console.apify.com/view/runs/${run.id}`;
throw new ApifyCallError(run, message);
}
diff --git a/src/apify.js b/src/apify.js
index 7f0b46ba0..252284369 100644
--- a/src/apify.js
+++ b/src/apify.js
@@ -111,7 +111,6 @@ export class Apify {
*/
main(userFunc) {
if (!userFunc || typeof (userFunc) !== 'function') {
- // eslint-disable-next-line max-len
throw new Error(`Apify.main() accepts a single parameter that must be a function (was '${userFunc === null ? 'null' : typeof userFunc}').`);
}
@@ -270,7 +269,6 @@ export class Apify {
}
if (this._isRunUnsuccessful(run.status)) {
- // eslint-disable-next-line max-len
const message = `The actor ${actId} invoked by Apify.call() did not succeed. For details, see https://console.apify.com/view/runs/${run.id}`;
throw new ApifyCallError(run, message);
}
@@ -385,7 +383,6 @@ export class Apify {
}
if (this._isRunUnsuccessful(run.status)) {
- // eslint-disable-next-line max-len
const message = `The actor task ${taskId} invoked by Apify.callTask() did not succeed. For details, see https://console.apify.com/view/runs/${run.id}`;
throw new ApifyCallError(run, message);
}
diff --git a/src/autoscaling/snapshotter.js b/src/autoscaling/snapshotter.js
index 0418eb440..2831927a5 100644
--- a/src/autoscaling/snapshotter.js
+++ b/src/autoscaling/snapshotter.js
@@ -213,7 +213,7 @@ class Snapshotter {
* @protected
* @internal
*/
- _getSample(snapshots, sampleDurationMillis) { // eslint-disable-line class-methods-use-this
+ _getSample(snapshots, sampleDurationMillis) {
if (!sampleDurationMillis) return snapshots;
const sample = [];
@@ -397,7 +397,7 @@ class Snapshotter {
* @protected
* @internal
*/
- _getCurrentCpuTicks() { // eslint-disable-line class-methods-use-this
+ _getCurrentCpuTicks() {
const cpus = os.cpus();
return cpus.reduce((acc, cpu) => {
const cpuTimes = Object.values(cpu.times);
diff --git a/src/autoscaling/system_status.js b/src/autoscaling/system_status.js
index 90f39d750..edd1dbfdd 100644
--- a/src/autoscaling/system_status.js
+++ b/src/autoscaling/system_status.js
@@ -1,5 +1,5 @@
import ow from 'ow';
-import Snapshotter from './snapshotter'; // eslint-disable-line import/no-duplicates
+import Snapshotter from './snapshotter';
import { weightedAvg } from '../utils';
// TODO yin: Add `@property clientInfo` as in `SystemStatus._isSystemIdle()`
@@ -223,7 +223,7 @@ class SystemStatus {
* @protected
* @internal
*/
- _isSampleOverloaded(sample, ratio) { // eslint-disable-line class-methods-use-this
+ _isSampleOverloaded(sample, ratio) {
const weights = [];
const values = [];
for (let i = 1; i < sample.length; i++) {
diff --git a/src/browser_launchers/playwright_launcher.js b/src/browser_launchers/playwright_launcher.js
index 4e8e68c47..e1756ced1 100644
--- a/src/browser_launchers/playwright_launcher.js
+++ b/src/browser_launchers/playwright_launcher.js
@@ -1,5 +1,5 @@
import ow from 'ow';
-import { LaunchOptions } from 'playwright'; // eslint-disable-line no-unused-vars,import/named
+import { LaunchOptions } from 'playwright'; // eslint-disable-line no-unused-vars
import { PlaywrightPlugin } from 'browser-pool';
import BrowserLauncher from './browser_launcher';
diff --git a/src/browser_launchers/puppeteer_launcher.js b/src/browser_launchers/puppeteer_launcher.js
index a02fe7219..56decd040 100644
--- a/src/browser_launchers/puppeteer_launcher.js
+++ b/src/browser_launchers/puppeteer_launcher.js
@@ -1,5 +1,5 @@
import ow from 'ow';
-import { PuppeteerNode } from 'puppeteer'; // eslint-disable-line no-unused-vars,import/named
+import { PuppeteerNode } from 'puppeteer'; // eslint-disable-line no-unused-vars
import { PuppeteerPlugin } from 'browser-pool';
import BrowserLauncher from './browser_launcher';
import { isAtHome } from '../utils';
diff --git a/src/constants.js b/src/constants.js
index 62d287132..fa99f7061 100644
--- a/src/constants.js
+++ b/src/constants.js
@@ -4,7 +4,6 @@ import { ACTOR_EVENT_NAMES } from '@apify/consts';
* The default user agent used by `Apify.launchPuppeteer`.
* Last updated on 2020-05-22.
*/
-// eslint-disable-next-line max-len
export const DEFAULT_USER_AGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.67 Safari/537.36';
/**
diff --git a/src/crawlers/basic_crawler.js b/src/crawlers/basic_crawler.js
index 3135c4fd2..ea31e71bb 100644
--- a/src/crawlers/basic_crawler.js
+++ b/src/crawlers/basic_crawler.js
@@ -11,7 +11,7 @@ import defaultLog from '../utils_log'; // eslint-disable-line import/no-duplicat
import { validators } from '../validators';
// TYPE IMPORTS
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
+/* eslint-disable no-unused-vars,import/named,import/no-duplicates */
import { AutoscaledPoolOptions } from '../autoscaling/autoscaled_pool';
import { ProxyInfo } from '../proxy_configuration';
import Request from '../request';
@@ -399,7 +399,7 @@ export class BasicCrawler {
* @protected
* @internal
*/
- async _handleRequestFunction(crawlingContext) { // eslint-disable-line no-unused-vars
+ async _handleRequestFunction(crawlingContext) {
await this.userProvidedHandler(crawlingContext);
}
diff --git a/src/crawlers/browser_crawler.js b/src/crawlers/browser_crawler.js
index 9fb876fc8..3bde468f0 100644
--- a/src/crawlers/browser_crawler.js
+++ b/src/crawlers/browser_crawler.js
@@ -2,7 +2,7 @@ import ow from 'ow';
import { addTimeoutToPromise, tryCancel } from '@apify/timeout';
import { BrowserPool, BrowserController } from 'browser-pool'; // eslint-disable-line import/no-duplicates,no-unused-vars
import { BASIC_CRAWLER_TIMEOUT_BUFFER_SECS } from '../constants';
-import EVENTS from '../session_pool/events'; // eslint-disable-line import/no-duplicates
+import EVENTS from '../session_pool/events';
import { validators } from '../validators';
import {
throwOnBlockedRequest,
diff --git a/src/crawlers/cheerio_crawler.js b/src/crawlers/cheerio_crawler.js
index 9d62850c2..dbb678784 100644
--- a/src/crawlers/cheerio_crawler.js
+++ b/src/crawlers/cheerio_crawler.js
@@ -1,4 +1,3 @@
-/* eslint-disable class-methods-use-this */
import { readStreamToString, concatStreamToBuffer } from '@apify/utilities';
import { addTimeoutToPromise, tryCancel } from '@apify/timeout';
import cheerio from 'cheerio'; // eslint-disable-line import/no-duplicates
@@ -508,7 +507,7 @@ class CheerioCrawler extends BasicCrawler {
delete extensionOptions.handlePageFunction;
for (const [key, value] of Object.entries(extensionOptions)) {
- const isConfigurable = this.hasOwnProperty(key); // eslint-disable-line
+ const isConfigurable = this.hasOwnProperty(key);
const originalType = typeof this[key];
const extensionType = typeof value; // What if we want to null something? It is really needed?
const isSameType = originalType === extensionType || value == null; // fast track for deleting keys
diff --git a/src/crawlers/crawler_utils.js b/src/crawlers/crawler_utils.js
index 24b03e038..967eb4a7b 100644
--- a/src/crawlers/crawler_utils.js
+++ b/src/crawlers/crawler_utils.js
@@ -1,6 +1,6 @@
import { Cookie, CookieJar } from 'tough-cookie';
// TYPE IMPORTS
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
+/* eslint-disable no-unused-vars */
import { Session } from '../session_pool/session';
import log from '../utils_log';
/* eslint-enable no-unused-vars,import/named,import/no-duplicates,import/order */
diff --git a/src/crawlers/playwright_crawler.js b/src/crawlers/playwright_crawler.js
index 8540128a4..188dd6c86 100644
--- a/src/crawlers/playwright_crawler.js
+++ b/src/crawlers/playwright_crawler.js
@@ -1,6 +1,6 @@
import ow from 'ow';
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
+/* eslint-disable no-unused-vars,import/named */
import { Page } from 'playwright';
import { BrowserPoolOptions, BrowserPool } from 'browser-pool';
import { PlaywrightLauncher, PlaywrightLaunchContext } from '../browser_launchers/playwright_launcher';
diff --git a/src/enqueue_links/shared.js b/src/enqueue_links/shared.js
index 8f3f712fe..d71f367e0 100644
--- a/src/enqueue_links/shared.js
+++ b/src/enqueue_links/shared.js
@@ -4,7 +4,7 @@ import PseudoUrl from '../pseudo_url';
import Request from '../request'; // eslint-disable-line import/no-duplicates
// TYPES IMPORT
-/* eslint-disable import/order,no-unused-vars,import/named,import/no-duplicates */
+/* eslint-disable no-unused-vars,import/named,import/no-duplicates */
import { RequestQueue, QueueOperationInfo } from '../storages/request_queue';
import { RequestOptions } from '../request';
/* eslint-enable */
diff --git a/src/request.js b/src/request.js
index e2fda3979..99f620513 100644
--- a/src/request.js
+++ b/src/request.js
@@ -184,7 +184,7 @@ class Request {
// .stack includes the message
: errorOrMessage.stack;
} else if (errorOrMessage.message) {
- message = errorOrMessage.message; // eslint-disable-line prefer-destructuring
+ message = errorOrMessage.message;
} else if (errorOrMessage.toString() !== '[object Object]') {
message = errorOrMessage.toString();
} else {
diff --git a/src/request_list.js b/src/request_list.js
index e5a31fb3f..90114e63f 100644
--- a/src/request_list.js
+++ b/src/request_list.js
@@ -9,7 +9,7 @@ import { getValue, setValue } from './storages/key_value_store';
import { serializeArray, createDeserialize } from './serialization';
// TYPE IMPORTS
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
+/* eslint-disable no-unused-vars,import/named,import/no-duplicates */
import { RequestOptions } from './request';
/* eslint-enable no-unused-vars,import/named,import/no-duplicates,import/order */
@@ -713,7 +713,7 @@ export class RequestList {
this._ensureUniqueKeyValid(uniqueKey);
// Skip requests with duplicate uniqueKey
- if (!this.uniqueKeyToIndex.hasOwnProperty(uniqueKey)) { // eslint-disable-line no-prototype-builtins
+ if (!this.uniqueKeyToIndex.hasOwnProperty(uniqueKey)) {
this.uniqueKeyToIndex[uniqueKey] = this.requests.length;
this.requests.push(request);
} else if (this.keepDuplicateUrls) {
@@ -729,7 +729,7 @@ export class RequestList {
* @protected
* @internal
*/
- _ensureUniqueKeyValid(uniqueKey) { // eslint-disable-line class-methods-use-this
+ _ensureUniqueKeyValid(uniqueKey) {
if (typeof uniqueKey !== 'string' || !uniqueKey) {
throw new Error('Request object\'s uniqueKey must be a non-empty string');
}
diff --git a/src/serialization.js b/src/serialization.js
index 7514c4428..b832fc328 100644
--- a/src/serialization.js
+++ b/src/serialization.js
@@ -5,7 +5,7 @@ import util from 'util';
import zlib from 'zlib';
// TYPE IMPORTS
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
+/* eslint-disable no-unused-vars,import/no-duplicates */
import { Readable } from 'stream';
// eslint-enable-line import/no-duplicates
@@ -129,7 +129,7 @@ export const createDeserialize = (compressedData) => {
function createChunkCollector(options = {}) {
const { fromValuesStream = false } = options;
const chunks = [];
- const collector = new stream.Writable({ // eslint-disable-line no-shadow
+ const collector = new stream.Writable({
decodeStrings: false,
objectMode: fromValuesStream,
write(chunk, nil, callback) {
diff --git a/src/session_pool/session.js b/src/session_pool/session.js
index 1555045a2..8dcce4a3d 100644
--- a/src/session_pool/session.js
+++ b/src/session_pool/session.js
@@ -7,7 +7,7 @@ import { getCookiesFromResponse } from './session_utils';
import defaultLog from '../utils_log';
// TYPE IMPORTS
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order,import/no-cycle */
+/* eslint-disable no-unused-vars,import/order,import/no-cycle */
import { SessionPool } from './session_pool';
import { IncomingMessage } from 'http';
import { HTTPResponse as PuppeteerResponse } from 'puppeteer';
diff --git a/src/storages/dataset.js b/src/storages/dataset.js
index b26518ac5..931ab5725 100644
--- a/src/storages/dataset.js
+++ b/src/storages/dataset.js
@@ -4,7 +4,7 @@ import { MAX_PAYLOAD_SIZE_BYTES } from '@apify/consts';
import { StorageManager } from './storage_manager';
import log from '../utils_log';
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
+/* eslint-disable no-unused-vars,import/order */
// @ts-ignore
import { ApifyClient } from 'apify-client';
// @ts-ignore
@@ -69,7 +69,7 @@ export const chunkBySize = (items, limitBytes) => {
let lastChunkBytes = 2; // Add 2 bytes for [] wrapper.
const chunks = [];
// Split payloads into buckets of valid size.
- for (const payload of items) { // eslint-disable-line
+ for (const payload of items) {
const bytes = Buffer.byteLength(payload);
if (bytes <= limitBytes && (bytes + 2) > limitBytes) {
@@ -181,7 +181,6 @@ export class Dataset {
*/
async pushData(data) {
ow(data, ow.object);
- // eslint-disable-next-line no-return-await
const dispatch = async (payload) => await this.client.pushItems(payload);
const limit = MAX_PAYLOAD_SIZE_BYTES - Math.ceil(MAX_PAYLOAD_SIZE_BYTES * SAFETY_BUFFER_PERCENT);
diff --git a/src/storages/key_value_store.js b/src/storages/key_value_store.js
index 93880b1a0..e01679be7 100644
--- a/src/storages/key_value_store.js
+++ b/src/storages/key_value_store.js
@@ -4,7 +4,7 @@ import ow, { ArgumentError } from 'ow';
import { StorageManager } from './storage_manager';
import log from '../utils_log';
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
+/* eslint-disable no-unused-vars,import/order */
// @ts-ignore
import { ApifyClient } from 'apify-client';
// @ts-ignore
diff --git a/src/storages/request_queue.js b/src/storages/request_queue.js
index 5cabec522..6d8ae14fc 100644
--- a/src/storages/request_queue.js
+++ b/src/storages/request_queue.js
@@ -7,8 +7,8 @@ import { StorageManager } from './storage_manager';
import { sleep } from '../utils';
import log from '../utils_log';
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
-import Request, { RequestOptions } from '../request'; // eslint-disable-line import/named,no-unused-vars
+/* eslint-disable no-unused-vars,import/named,import/order */
+import Request, { RequestOptions } from '../request';
// @ts-ignore
import { ApifyClient } from 'apify-client';
// @ts-ignore
diff --git a/src/storages/storage_manager.js b/src/storages/storage_manager.js
index e33b46b04..90d2b98c5 100644
--- a/src/storages/storage_manager.js
+++ b/src/storages/storage_manager.js
@@ -1,6 +1,6 @@
import { ENV_VARS } from '@apify/consts';
-/* eslint-disable no-unused-vars,import/named,import/no-duplicates,import/order */
+/* eslint-disable no-unused-vars */
// @ts-ignore
import { ApifyClient } from 'apify-client';
// @ts-ignore
diff --git a/src/utils.js b/src/utils.js
index 0e3c597ea..2e40eb622 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -207,7 +207,7 @@ export const isDocker = (forceReset) => {
export const weightedAvg = (arrValues, arrWeights) => {
const result = arrValues.map((value, i) => {
const weight = arrWeights[i];
- const sum = value * weight; // eslint-disable-line no-shadow
+ const sum = value * weight;
return [sum, weight];
}).reduce((p, c) => [p[0] + c[0], p[1] + c[1]], [0, 0]);
@@ -636,7 +636,6 @@ export const printOutdatedSdkWarning = () => {
const latestApifyVersion = process.env[ENV_VARS.SDK_LATEST_VERSION];
if (!latestApifyVersion || !semver.lt(apifyVersion, latestApifyVersion)) return;
- // eslint-disable-next-line
log.warning(`You are using an outdated version (${apifyVersion}) of Apify SDK. We recommend you to update to the latest version (${latestApifyVersion}).
Read more about Apify SDK versioning at: https://help.apify.com/en/articles/3184510-updates-and-versioning-of-apify-sdk`);
};
diff --git a/src/utils_request.js b/src/utils_request.js
index 8dbb57421..532355475 100644
--- a/src/utils_request.js
+++ b/src/utils_request.js
@@ -2,7 +2,7 @@ import { gotScraping } from 'got-scraping';
import ow from 'ow';
import log from './utils_log';
-/* eslint-disable no-unused-vars,import/named,import/order */
+/* eslint-disable no-unused-vars,import/order */
import { IncomingMessage } from 'http';
/* eslint-enable no-unused-vars,import/named,import/order */
diff --git a/src/utils_social.js b/src/utils_social.js
index 706c530a6..67aab804a 100644
--- a/src/utils_social.js
+++ b/src/utils_social.js
@@ -1,4 +1,3 @@
-/* eslint-disable no-continue */
import _ from 'underscore';
import cheerio from 'cheerio';
import log from './utils_log';
@@ -186,24 +185,24 @@ const LINKEDIN_REGEX_STRING = '(?<!\\w)(?:(?:http(?:s)?:\\/\\/)?(?:(?:(?:[a-z]+\
const INSTAGRAM_REGEX_STRING = '(?<!\\w)(?:http(?:s)?:\\/\\/)?(?:(?:www\\.)?(?:instagram\\.com|instagr\\.am)\\/)(?!explore|_n|_u)([a-z0-9_.]{2,30})(?![a-z0-9_.])(?:/)?';
const TWITTER_RESERVED_PATHS = 'oauth|account|tos|privacy|signup|home|hashtag|search|login|widgets|i|settings|start|share|intent|oct';
-// eslint-disable-next-line max-len, quotes
+// eslint-disable-next-line max-len
const TWITTER_REGEX_STRING = `(?<!\\w)(?:http(?:s)?:\\/\\/)?(?:www.)?(?:twitter.com)\\/(?!(?:${TWITTER_RESERVED_PATHS})(?:[\\'\\"\\?\\.\\/]|$))([a-z0-9_]{1,15})(?![a-z0-9_])(?:/)?`;
-// eslint-disable-next-line max-len, quotes
+// eslint-disable-next-line max-len
const FACEBOOK_RESERVED_PATHS = 'rsrc\\.php|apps|groups|events|l\\.php|friends|images|photo.php|chat|ajax|dyi|common|policies|login|recover|reg|help|security|messages|marketplace|pages|live|bookmarks|games|fundraisers|saved|gaming|salesgroups|jobs|people|ads|ad_campaign|weather|offers|recommendations|crisisresponse|onthisday|developers|settings|connect|business|plugins|intern|sharer';
-// eslint-disable-next-line max-len, quotes
+// eslint-disable-next-line max-len
const FACEBOOK_REGEX_STRING = `(?<!\\w)(?:http(?:s)?:\\/\\/)?(?:www.)?(?:facebook.com|fb.com)\\/(?!(?:${FACEBOOK_RESERVED_PATHS})(?:[\\'\\"\\?\\.\\/]|$))(profile\\.php\\?id\\=[0-9]{3,20}|(?!profile\\.php)[a-z0-9\\.]{5,51})(?![a-z0-9\\.])(?:/)?`;
-// eslint-disable-next-line max-len, quotes
+// eslint-disable-next-line max-len
const YOUTUBE_REGEX_STRING = '(?<!\\w)(?:https?:\\/\\/)?(?:youtu\\.be\\/|(?:www\\.|m\\.)?youtube\\.com(?:\\/(?:watch|v|embed|user|c(?:hannel)?)(?:\\.php)?)?(?:\\?[^ ]*v=|\\/))([a-zA-Z0-9\\-_]{2,100})';
-// eslint-disable-next-line max-len, quotes
+// eslint-disable-next-line max-len
const TIKTOK_REGEX_STRING = '(?<!\\w)(?:http(?:s)?:\\/\\/)?(?:(?:www|m)\\.)?(?:tiktok\\.com)\\/(((?:(?:v|embed|trending)(?:\\?shareId=|\\/))[0-9]{2,50}(?![0-9]))|(?:@)[a-z0-9\\-_\\.]+((?:\\/video\\/)[0-9]{2,50}(?![0-9]))?)(?:\\/)?';
-// eslint-disable-next-line max-len, quotes
+// eslint-disable-next-line max-len
const PINTEREST_REGEX_STRING = '(?<!\\w)(?:http(?:s)?:\\/\\/)?(?:(?:(?:(?:www\\.)?pinterest(?:\\.com|(?:\\.[a-z]{2}){1,2}))|(?:[a-z]{2})\\.pinterest\\.com)(?:\\/))((pin\\/[0-9]{2,50})|((?!pin)[a-z0-9\\-_\\.]+(\\/[a-z0-9\\-_\\.]+)?))(?:\\/)?';
-// eslint-disable-next-line max-len, quotes
+// eslint-disable-next-line max-len
const DISCORD_REGEX_STRING = '(?<!\\w)(?:https?:\\/\\/)?(?:www\\.)?((?:(?:(?:canary|ptb).)?(?:discord|discordapp)\\.com\\/channels(?:\\/)[0-9]{2,50}(\\/[0-9]{2,50})*)|(?:(?:(?:canary|ptb).)?(?:discord\\.(?:com|me|li|gg|io)|discordapp\\.com)(?:\\/invite)?)\\/(?!channels)[a-z0-9\\-_]{2,50})(?:\\/)?';
/** @type RegExp */
diff --git a/test/apify.test.js b/test/apify.test.js
index 68924294d..82cd3229b 100644
--- a/test/apify.test.js
+++ b/test/apify.test.js
@@ -341,7 +341,6 @@ describe('new Apify({ ... })', () => {
const actorSpy = jest.spyOn(ApifyClient.prototype, 'actor');
actorSpy.mockReturnValueOnce({ call: callMock });
- // eslint-disable-next-line max-len
const err = 'The actor some-act-id invoked by Apify.call() did not succeed. For details, see https://console.apify.com/view/runs/some-run-id';
await expect(new Apify().call(actId, null)).rejects.toThrowError(new ApifyCallError(failedRun, err));
@@ -471,7 +470,6 @@ describe('new Apify({ ... })', () => {
const taskSpy = jest.spyOn(ApifyClient.prototype, 'task');
taskSpy.mockReturnValueOnce({ call: callMock });
- // eslint-disable-next-line max-len
const err = 'The actor task some-task-id invoked by Apify.callTask() did not succeed. For details, see https://console.apify.com/view/runs/some-run-id';
await expect(new Apify().callTask(taskId)).rejects.toThrowError(new ApifyCallError(failedRun, err));
@@ -576,7 +574,7 @@ describe('new Apify({ ... })', () => {
expect(warningMock).toBeCalledTimes(2);
// eslint-disable-next-line max-len
expect(warningMock).toBeCalledWith(`Neither APIFY_LOCAL_STORAGE_DIR nor APIFY_TOKEN environment variable is set, defaulting to APIFY_LOCAL_STORAGE_DIR="${sdk.config.get('localStorageDir')}"`);
- // eslint-disable-next-line max-len
+
expect(warningMock).toBeCalledWith('Apify.addWebhook() is only supported when running on the Apify platform. The webhook will not be invoked.');
});
diff --git a/test/browser_launchers/playwright_launcher.test.js b/test/browser_launchers/playwright_launcher.test.js
index 6044f2bca..15a4fd6dd 100644
--- a/test/browser_launchers/playwright_launcher.test.js
+++ b/test/browser_launchers/playwright_launcher.test.js
@@ -15,9 +15,9 @@ import { PlaywrightLauncher } from '../../build/browser_launchers/playwright_lau
let prevEnvHeadless;
let proxyServer;
-let proxyPort; // eslint-disable-line no-unused-vars
+let proxyPort;
const proxyAuth = { scheme: 'Basic', username: 'username', password: 'password' };
-let wasProxyCalled = false; // eslint-disable-line no-unused-vars
+let wasProxyCalled = false;
// Setup local proxy server for the tests
beforeAll(() => {
diff --git a/test/browser_launchers/puppeteer_launcher.test.js b/test/browser_launchers/puppeteer_launcher.test.js
index 32cef886a..7174cd408 100644
--- a/test/browser_launchers/puppeteer_launcher.test.js
+++ b/test/browser_launchers/puppeteer_launcher.test.js
@@ -15,9 +15,9 @@ import * as utils from '../../build/utils';
let prevEnvHeadless;
let proxyServer;
-let proxyPort; // eslint-disable-line no-unused-vars
+let proxyPort;
const proxyAuth = { scheme: 'Basic', username: 'username', password: 'password' };
-let wasProxyCalled = false; // eslint-disable-line no-unused-vars
+let wasProxyCalled = false;
const HOSTNAME = '127.0.0.1';
let port;
diff --git a/test/crawlers/browser_crawler.test.js b/test/crawlers/browser_crawler.test.js
index 9368bce20..df3fbb506 100644
--- a/test/crawlers/browser_crawler.test.js
+++ b/test/crawlers/browser_crawler.test.js
@@ -1,5 +1,3 @@
-/* eslint-disable no-prototype-builtins */
-
import { URL } from 'url';
import { ENV_VARS } from '@apify/consts';
import sinon from 'sinon';
@@ -430,7 +428,7 @@ describe('BrowserCrawler', () => {
useSessionPool: true,
persistCookiesPerSession: false,
maxRequestRetries: 0,
- handlePageFunction: async () => { // eslint-disable-line no-loop-func
+ handlePageFunction: async () => {
called = true;
},
handleFailedRequestFunction: async ({ request }) => {
@@ -472,7 +470,7 @@ describe('BrowserCrawler', () => {
useSessionPool: true,
persistCookiesPerSession: false,
maxRequestRetries: 0,
- handlePageFunction: async () => { // eslint-disable-line no-loop-func
+ handlePageFunction: async () => {
called = true;
},
gotoFunction: ({ page, request }) => page.goto(request.url),
diff --git a/test/crawlers/cheerio_crawler.test.js b/test/crawlers/cheerio_crawler.test.js
index cd25687e9..f5e0e6516 100644
--- a/test/crawlers/cheerio_crawler.test.js
+++ b/test/crawlers/cheerio_crawler.test.js
@@ -1,5 +1,3 @@
-/* eslint-disable no-prototype-builtins */
-
import fs from 'fs';
import path from 'path';
import { ENV_VARS } from '@apify/consts';
diff --git a/test/main.test.js b/test/main.test.js
index 4a9b51317..819b706d4 100644
--- a/test/main.test.js
+++ b/test/main.test.js
@@ -1,13 +1,11 @@
-// eslint-disable-next-line import/no-duplicates
import {
ENV_VARS,
KEY_VALUE_STORE_KEYS,
} from '@apify/consts';
import ApifyDefault from '../build/index';
-// eslint-disable-next-line import/no-duplicates
import * as ApifyWithWildcard from '../build/index';
import LocalStorageDirEmulator from './local_storage_dir_emulator';
-// eslint-disable-next-line global-require
+
const Apify = require('../build');
describe('Apify module', () => {
diff --git a/test/proxy_configuration.test.js b/test/proxy_configuration.test.js
index e5e18a8b7..853453a27 100644
--- a/test/proxy_configuration.test.js
+++ b/test/proxy_configuration.test.js
@@ -371,7 +371,6 @@ describe('Apify.createProxyConfiguration()', () => {
.once()
.returns({ get: async () => fakeUserData });
- // eslint-disable-next-line no-unused-vars
const proxyConfiguration = new ProxyConfiguration(basicOpts);
const logMock = sinon.mock(proxyConfiguration.log);
logMock.expects('warning').once();
diff --git a/test/pseudo_url.test.js b/test/pseudo_url.test.js
index 819a9b84c..574543aad 100644
--- a/test/pseudo_url.test.js
+++ b/test/pseudo_url.test.js
@@ -2,7 +2,7 @@ import Apify from '../build/index';
describe('Apify.PseudoUrl', () => {
test('matches() should work', () => {
- let purl = new Apify.PseudoUrl('http://www.example.com/PAGES/[(\\w|-)*]'); // eslint-disable-line
+ let purl = new Apify.PseudoUrl('http://www.example.com/PAGES/[(\\w|-)*]');
expect(purl.matches('http://www.example.com/PAGES/')).toBe(true);
expect(purl.matches('http://www.example.com/pages/my-awesome-page')).toBe(true);
diff --git a/test/request_list.test.js b/test/request_list.test.js
index 65079dcd3..3c4856d1b 100644
--- a/test/request_list.test.js
+++ b/test/request_list.test.js
@@ -693,7 +693,7 @@ describe('Apify.RequestList', () => {
// Get requests from list
let reqs = [];
for (let i = 0; i < 5; i++) {
- const request = await requestList.fetchNextRequest(); // eslint-disable-line
+ const request = await requestList.fetchNextRequest();
if (!request) break;
reqs.push(request);
}
@@ -701,7 +701,7 @@ describe('Apify.RequestList', () => {
reqs = _.shuffle(reqs);
for (let i = 0; i < reqs.length; i++) {
- await requestList.reclaimRequest(reqs[i]); // eslint-disable-line
+ await requestList.reclaimRequest(reqs[i]);
}
});
diff --git a/test/session_pool/session.test.js b/test/session_pool/session.test.js
index 70fdfe562..88b542919 100644
--- a/test/session_pool/session.test.js
+++ b/test/session_pool/session.test.js
@@ -33,8 +33,8 @@ describe('Session - testing session behaviour ', () => {
} catch (e) {
err = e;
}
- expect(err).toBeDefined(); // eslint-disable-line
- expect(err.message.includes('object `sessionPool` `{}` to be of type `SessionPool`')).toBe(true); // eslint-disable-line
+ expect(err).toBeDefined();
+ expect(err.message.includes('object `sessionPool` `{}` to be of type `SessionPool`')).toBe(true);
});
test('should mark session markBad', () => {
@@ -87,7 +87,7 @@ describe('Session - testing session behaviour ', () => {
discarded = true;
});
session.retire();
- expect(discarded).toBe(true); // eslint-disable-line
+ expect(discarded).toBe(true);
expect(session.usageCount).toBe(1);
});
diff --git a/test/stealth/stealth.test.js b/test/stealth/stealth.test.js
index bf593a72e..ffef5eefe 100644
--- a/test/stealth/stealth.test.js
+++ b/test/stealth/stealth.test.js
@@ -130,7 +130,7 @@ describe('Stealth - testing headless chrome hiding tricks', () => {
const { hasChrome } = await getFingerPrint(page);
const chrome = await page.evaluate(() => window.chrome); //eslint-disable-line
expect(chrome).toBeInstanceOf(Object);
- expect(chrome.runtime).toEqual({}); // eslint-disable-line
+ expect(chrome.runtime).toEqual({});
expect(hasChrome).toBe(true);
});
diff --git a/test/storages/key_value_store.test.js b/test/storages/key_value_store.test.js
index a31cfbcfe..4145cda26 100644
--- a/test/storages/key_value_store.test.js
+++ b/test/storages/key_value_store.test.js
@@ -172,7 +172,7 @@ describe('KeyValueStore remote', () => {
const INVALID_CHARACTERS = '?|\\/"*<>%:';
let counter = 0;
- for (const char of INVALID_CHARACTERS) { // eslint-disable-line
+ for (const char of INVALID_CHARACTERS) {
try {
await store.setValue(`my_id_${char}`, 'value');
} catch (err) {
diff --git a/test/utils.test.js b/test/utils.test.js
index 76b173248..d7566b3d8 100644
--- a/test/utils.test.js
+++ b/test/utils.test.js
@@ -1,4 +1,3 @@
-// eslint-disable-next-line max-classes-per-file
import sinon from 'sinon';
import _ from 'underscore';
import fs from 'fs';