Skip to content

Crawlee—A web scraping and browser automation library for Node.js to build reliable crawlers. In JavaScript and TypeScript. Extract data for AI, LLMs, RAG, or GPTs. Download HTML, PDF, JPG, PNG, and other files from websites. Works with Puppeteer, Playwright, Cheerio, JSDOM, and raw HTTP. Both headful and headless mode. With proxy rotation.

chore(ci): pin lerna's minimatch to v3 and fail step on lerna error

Martin Adámek69157f5c8a34
diff --git a/.github/workflows/test-ci.yml b/.github/workflows/test-ci.yml
index f8853e81b..406b3cb02 100644
--- a/.github/workflows/test-ci.yml
+++ b/.github/workflows/test-ci.yml
@@ -263,8 +263,14 @@ jobs:
- name: Generate changed packages list
id: changed-packages
+ # `set -eo pipefail` plus an explicit assignment ensures a lerna
+ # crash fails the step instead of being swallowed by the outer
+ # `echo | tee` (which would otherwise emit `changed_packages=0`
+ # and skip the publish step silently).
run: |
- echo "changed_packages=$(node ./node_modules/.bin/lerna changed -p | wc -l | xargs)" | tee -a $GITHUB_OUTPUT
+ set -eo pipefail
+ changed=$(node ./node_modules/.bin/lerna changed -p | wc -l | xargs)
+ echo "changed_packages=$changed" | tee -a "$GITHUB_OUTPUT"
- name: Report nothing to release
if: steps.changed-packages.outputs.changed_packages == '0'
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 95d0723a1..0806ed572 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -8,6 +8,7 @@ overrides:
playwright-core: 1.58.2
'@browserbasehq/stagehand': 3.0.7
minimatch: ^9.0.0
+ lerna>minimatch: ^3.1.4
patchedDependencies:
'@docusaurus/[email protected]':
@@ -5491,6 +5492,9 @@ packages:
resolution: {integrity: sha512-2hCgjEmP8YLWQ130n2FerGv7rYpfBmnmp9Uy2Le1vge6X3gZIfSmEzP5QTDElFxcvVcXlEn8Aq6MU/PZygIOog==}
engines: {node: '>=14.16'}
+ resolution: {integrity: sha512-MWPGfDxnyzKU7rNOW9SP/c50vi3xrmrua/+6hfPbCS2ABNWfx24vPidzvC7krjU/RTo235sV776ymlsMtGKj8g==}
+
resolution: {integrity: sha512-TN1kCZAgdgweJhWWpgKYrQaMNHcDULHkWwQIspdtjV4Y5aurRdZpjAqn6yX3FPqTA9ngHCc4hJxMAMgGfve85w==}
@@ -5926,6 +5930,9 @@ packages:
resolution: {integrity: sha512-9mAqGPHLakhCLeNyxPkK4xVo746zQ/czLH1Ky+vkitMnWfWZps8r0qXuwhwizagCRttsL4lfG4pIOvaWLpAP0w==}
engines: {node: '>= 0.8.0'}
+ resolution: {integrity: sha512-/Srv4dswyQNBfohGpz9o6Yb3Gz3SrUDqBH5rTuhGR7ahtlbYKnVxw2bCFMRljaA7EXHaXZ8wsHdodFvbkhKmqg==}
+
resolution: {integrity: sha512-MWufYdFw53ccGjCA+Ol7XJYpAlW6/prSMzuPOTRnJGcGzuhLn4Scrz7qf6o8bROZ514ltazcIFJZevcfbo0x7A==}
engines: {'0': node >= 6.0}
@@ -9418,6 +9425,9 @@ packages:
resolution: {integrity: sha512-JIYlbt6g8i5jKfJ3xz7rF0LXmv2TkDxBLUkiBeZ7bAx4GnnNMr8xFpGnOxn6GhTEHx3SjRrZEoU+j04prX1ktg==}
+ resolution: {integrity: sha512-VgjWUsnnT6n+NUk6eZq77zeFdpW2LWDzP6zFGrCbHXiYNul5Dzqk2HHQ5uFH2DNW5Xbp8+jVzaeNt94ssEEl4w==}
+
resolution: {integrity: sha512-OBwBN9AL4dqmETlpS2zasx+vTeWclWzkblfZk7KTA5j3jeOONz/tRCnZomUyvNg83wL5Zv9Ss6HMJXAgL8R2Yg==}
engines: {node: '>=16 || 14 >=14.17'}
@@ -18445,6 +18455,11 @@ snapshots:
widest-line: 4.0.1
wrap-ansi: 8.1.0
+ dependencies:
+ balanced-match: 1.0.2
+ concat-map: 0.0.1
+
dependencies:
balanced-match: 1.0.2
@@ -18944,6 +18959,8 @@ snapshots:
transitivePeerDependencies:
- supports-color
+
dependencies:
buffer-from: 1.1.2
@@ -22335,7 +22352,7 @@ snapshots:
libnpmpublish: 11.1.2
load-json-file: 6.2.0
make-fetch-happen: 15.0.2
- minimatch: 9.0.9
+ minimatch: 3.1.5
npm-package-arg: 13.0.1
npm-packlist: 10.0.3
npm-registry-fetch: 19.1.0
@@ -23346,6 +23363,10 @@ snapshots:
+ dependencies:
+ brace-expansion: 1.1.14
+
dependencies:
brace-expansion: 2.1.0
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index 6c7059819..d051357b6 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -15,12 +15,17 @@ minimumReleaseAgeExclude:
overrides:
playwright-core: 1.61.1
"@browserbasehq/stagehand": 3.0.7
+ # Dedup minimatch to v9 everywhere except inside lerna — lerna 9.x's bundled
+ # code (`__toESM(require('minimatch')).default(...)`) only works with v3,
+ # whose CJS export *is* the function. Pinning v9 there caused the publish
+ # step to silently report 0 changed packages.
minimatch: "^9.0.0"
tmp: "^0.2.7"
"@puppeteer/browsers": "^3.0.4"
form-data: "^4.0.6"
tar: "^7.5.16"
"lerna>js-yaml": "^4.2.0"
+ "lerna>minimatch": "^3.1.4"
onlyBuiltDependencies:
- "@apify/ui-icons"