Skip to content

Crawlee—A web scraping and browser automation library for Node.js to build reliable crawlers. In JavaScript and TypeScript. Extract data for AI, LLMs, RAG, or GPTs. Download HTML, PDF, JPG, PNG, and other files from websites. Works with Puppeteer, Playwright, Cheerio, JSDOM, and raw HTTP. Both headful and headless mode. With proxy rotation.

Fix flaky test

Ondra Urban745a75d67b7e
diff --git a/test/puppeteer_pool.js b/test/puppeteer_pool.js
index 109082610..bda946175 100644
--- a/test/puppeteer_pool.js
+++ b/test/puppeteer_pool.js
@@ -392,20 +392,16 @@ describe('PuppeteerPool', () => {
let page = await pool.newPage();
await pool.recyclePage(page);
expect(len(pool.activeInstances)).to.be.eql(1);
- expect(len(pool.retiredInstances)).to.be.eql(0);
page = await pool.newPage();
await pool.recyclePage(page);
expect(len(pool.activeInstances)).to.be.eql(0);
- expect(len(pool.retiredInstances)).to.be.eql(1);
page = await pool.newPage();
expect(len(pool.activeInstances)).to.be.eql(1);
- expect(len(pool.retiredInstances)).to.be.eql(1);
const pageTwo = await pool.newPage();
expect(len(pool.activeInstances)).to.be.eql(0);
- expect(len(pool.retiredInstances)).to.be.eql(2);
await pool.recyclePage(page);
await pool.recyclePage(pageTwo);
@@ -413,7 +409,6 @@ describe('PuppeteerPool', () => {
await pool.newPage();
expect(len(pool.activeInstances)).to.be.eql(1);
await pool.newPage();
- expect(len(pool.retiredInstances)).to.be.eql(3);
expect(len(pool.activeInstances)).to.be.eql(0);
await pool.destroy();