Skip to content

Crawlee—A web scraping and browser automation library for Node.js to build reliable crawlers. In JavaScript and TypeScript. Extract data for AI, LLMs, RAG, or GPTs. Download HTML, PDF, JPG, PNG, and other files from websites. Works with Puppeteer, Playwright, Cheerio, JSDOM, and raw HTTP. Both headful and headless mode. With proxy rotation.

fixed the (o)n problem.

Petr Patek98f8461c3434
diff --git a/src/crawlers/puppeteer_crawler.js b/src/crawlers/puppeteer_crawler.js
index 16ab01df5..46740c581 100644
--- a/src/crawlers/puppeteer_crawler.js
+++ b/src/crawlers/puppeteer_crawler.js
@@ -289,7 +289,7 @@ class PuppeteerCrawler {
// @TODO: Handle cookies load here.
const browser = page.browser();
// @TODO: Session pool method find my id;
- session = this.sessionPool.sessions.find(ses => ses.id === browser[BROWSER_SESSION_ID_KEY_NAME]);
+ session = browser.session;
}
try {
diff --git a/src/puppeteer_pool.js b/src/puppeteer_pool.js
index 27b078f98..82026b449 100644
--- a/src/puppeteer_pool.js
+++ b/src/puppeteer_pool.js
@@ -254,7 +254,7 @@ class PuppeteerPool {
}
browser.recycleDiskCacheDir = diskCacheDir;
- if (session) browser[BROWSER_SESSION_ID_KEY_NAME] = session.id;
+ if (session) browser[BROWSER_SESSION_ID_KEY_NAME] = session;
return browser;
};
@@ -322,7 +322,7 @@ class PuppeteerPool {
browser = await browserPromise;
if (this.sessionPool) {
- instance.sessionId = browser[BROWSER_SESSION_ID_KEY_NAME];
+ instance.session = browser[BROWSER_SESSION_ID_KEY_NAME];
}
} catch (err) {
log.exception(err, 'PuppeteerPool: Browser launch failed', { id });
@@ -732,7 +732,7 @@ class PuppeteerPool {
_findInstancesBySession(session) {
const instances = Object.values(this.activeInstances);
- return instances.filter(instance => instance.sessionId === session.id);
+ return instances.filter(instance => instance.session.id === session.id);
}
async _retireBrowserWithSession(session) {
diff --git a/test/puppeteer_pool.test.js b/test/puppeteer_pool.test.js
index 70a3653c4..f7b42eb3c 100644
--- a/test/puppeteer_pool.test.js
+++ b/test/puppeteer_pool.test.js
@@ -647,9 +647,9 @@ describe('PuppeteerPool', () => {
expect(pool.sessionPool.constructor.name).toEqual('SessionPool');
const page = await pool.newPage();
const browser = page.browser();
- expect(browser[BROWSER_SESSION_ID_KEY_NAME]).toEqual(sessionPool.sessions[0].id);
+ expect(browser[BROWSER_SESSION_ID_KEY_NAME].id).toEqual(sessionPool.sessions[0].id);
expect(
- Object.values(pool.activeInstances).filter(instance => instance.sessionId === browser[BROWSER_SESSION_ID_KEY_NAME]),
+ Object.values(pool.activeInstances).filter(instance => instance.session.id === browser[BROWSER_SESSION_ID_KEY_NAME].id),
).toHaveLength(1);
sessionPool.sessions[0].retire();