Skip to content

Crawlee—A web scraping and browser automation library for Node.js to build reliable crawlers. In JavaScript and TypeScript. Extract data for AI, LLMs, RAG, or GPTs. Download HTML, PDF, JPG, PNG, and other files from websites. Works with Puppeteer, Playwright, Cheerio, JSDOM, and raw HTTP. Both headful and headless mode. With proxy rotation.

fix: handle non-error objects thrown gracefully (#1652)

Vlad Franguc3a4e1a9b7d0
diff --git a/packages/utils/src/internals/error_tracker.ts b/packages/utils/src/internals/error_tracker.ts
index f32814c9a..0d1c3599c 100644
--- a/packages/utils/src/internals/error_tracker.ts
+++ b/packages/utils/src/internals/error_tracker.ts
@@ -219,6 +219,10 @@ const mergeMessages = (a: string, b: string, storage: Record<string, unknown>) =
const getErrorMessageGroup = (error: ErrnoException, storage: Record<string, unknown>, showFullMessage: boolean) => {
let { message } = error;
+ if (!message) {
+ message = typeof error === 'string' ? error : `Unknown error message. Received non-error object: ${JSON.stringify(error)}`;
+ }
+
if (!showFullMessage) {
const newLineIndex = message.indexOf('\n');
message = message.slice(0, newLineIndex === -1 ? undefined : newLineIndex);
diff --git a/packages/utils/test/non-error-objects-working.test.ts b/packages/utils/test/non-error-objects-working.test.ts
new file mode 100644
index 000000000..167f1b44b
--- /dev/null
+++ b/packages/utils/test/non-error-objects-working.test.ts
@@ -0,0 +1,9 @@
+import { ErrorTracker } from '../src/internals/error_tracker';
+
+describe('ErrorTracker', () => {
+ test('processing a non-error error should not crash', () => {
+ const errorTracker = new ErrorTracker();
+ // @ts-expect-error tracking non-error errors
+ expect(() => errorTracker.add('foo')).not.toThrow();
+ });
+});