Skip to content

Crawlee—A web scraping and browser automation library for Node.js to build reliable crawlers. In JavaScript and TypeScript. Extract data for AI, LLMs, RAG, or GPTs. Download HTML, PDF, JPG, PNG, and other files from websites. Works with Puppeteer, Playwright, Cheerio, JSDOM, and raw HTTP. Both headful and headless mode. With proxy rotation.

Add trivial test. Apify.launchPuppeteer() now waits on server start.

Ondrej Urband377bf4ae22d
diff --git a/src/puppeteer.js b/src/puppeteer.js
index 5e93519d6..69bfc78b8 100644
--- a/src/puppeteer.js
+++ b/src/puppeteer.js
@@ -201,7 +201,7 @@ export const launchPuppeteer = (opts = {}) => {
const wrapped = newPromise().then(() => browserPromise);
// start LiveView server if requested
- if (optsCopy.liveView) startPuppeteerLiveView(wrapped).catch(err => log.error(err));
+ if (optsCopy.liveView) return startPuppeteerLiveView(wrapped).then(() => wrapped);
return wrapped;
};
diff --git a/src/puppeteer_live_view_server.js b/src/puppeteer_live_view_server.js
index 616518a7e..068150775 100644
--- a/src/puppeteer_live_view_server.js
+++ b/src/puppeteer_live_view_server.js
@@ -228,7 +228,7 @@ export const startPuppeteerLiveView = (browserPromise, opts = {}) => {
return defaultServer;
});
- return Promise.all([serverPromise, browserPromise]);
+ return Promise.all([serverPromise, browserPromise]).then(() => defaultServer); // return PuppeteerLiveViewServer instance
};
/**
diff --git a/test/puppeteer_live_view_server.js b/test/puppeteer_live_view_server.js
new file mode 100644
index 000000000..9f43c4077
--- /dev/null
+++ b/test/puppeteer_live_view_server.js
@@ -0,0 +1,33 @@
+import http from 'http';
+import { expect, assert } from 'chai';
+import Promise from 'bluebird';
+import Apify from '../build/index';
+
+const httpGet = (port) => {
+ return new Promise((resolve, reject) => {
+ const opts = {
+ host: 'localhost',
+ port,
+ };
+ http.get(opts, (res) => {
+ let body = '';
+ res.on('data', (d) => {
+ body += d;
+ });
+ res.on('end', () => resolve(body));
+ res.on('error', reject);
+ });
+ });
+};
+
+
+describe('Starting the PuppeteerLiveViewServer', () => {
+ it('should start using Apify.launchPuppeteer()', () => {
+ return Apify.launchPuppeteer({ liveView: true })
+ .then(() => httpGet(1234))
+ .catch(err => assert.fail(err, 'Server response.'))
+ .then((body) => {
+ expect(body.trim().substr(0, 15)).to.equal('<!doctype html>');
+ });
+ });
+});