Skip to content

Crawlee—A web scraping and browser automation library for Node.js to build reliable crawlers. In JavaScript and TypeScript. Extract data for AI, LLMs, RAG, or GPTs. Download HTML, PDF, JPG, PNG, and other files from websites. Works with Puppeteer, Playwright, Cheerio, JSDOM, and raw HTTP. Both headful and headless mode. With proxy rotation.

fix(types): make return type of RequestProvider.open and RequestQueue(v2).open strict and accurate (#2096)

Vlad Frangudfaddb920d97
diff --git a/packages/core/src/storages/request_provider.ts b/packages/core/src/storages/request_provider.ts
index 50ad2f6f8..187cd0953 100644
--- a/packages/core/src/storages/request_provider.ts
+++ b/packages/core/src/storages/request_provider.ts
@@ -614,7 +614,7 @@ export abstract class RequestProvider implements IStorage {
* the function returns the default request queue associated with the crawler run.
* @param [options] Open Request Queue options.
*/
- static async open(queueIdOrName?: string | null, options: StorageManagerOptions = {}): Promise<BuiltRequestProvider> {
+ static async open(queueIdOrName?: string | null, options: StorageManagerOptions = {}): Promise<RequestProvider> {
ow(queueIdOrName, ow.optional.any(ow.string, ow.null));
ow(options, ow.object.exactShape({
config: ow.optional.object.instanceOf(Configuration),
diff --git a/packages/core/src/storages/request_queue.ts b/packages/core/src/storages/request_queue.ts
index 1eccddea5..4eb94a457 100644
--- a/packages/core/src/storages/request_queue.ts
+++ b/packages/core/src/storages/request_queue.ts
@@ -323,4 +323,8 @@ export class RequestQueue extends RequestProvider {
super._reset();
this.lastActivity = new Date();
}
+
+ static override open(...args: Parameters<typeof RequestProvider.open>): Promise<RequestQueue> {
+ return super.open(...args) as Promise<RequestQueue>;
+ }
}
diff --git a/packages/core/src/storages/request_queue_v2.ts b/packages/core/src/storages/request_queue_v2.ts
index 9051d2e51..bcf8fb1eb 100644
--- a/packages/core/src/storages/request_queue_v2.ts
+++ b/packages/core/src/storages/request_queue_v2.ts
@@ -291,6 +291,10 @@ class RequestQueue extends RequestProvider {
}
}
}
+
+ static override open(...args: Parameters<typeof RequestProvider.open>): Promise<RequestQueue> {
+ return super.open(...args) as Promise<RequestQueue>;
+ }
}
export { RequestQueue as RequestQueueV2 };