Skip to content

Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.

fix: replay emits CrewKickoffFailedEvent when the replayed run fails (#8418)

Wilson_Jiang0b5053e33fae
diff --git a/lib/crewai/src/crewai/crew.py b/lib/crewai/src/crewai/crew.py
index ecab6d596..d9fbcc114 100644
--- a/lib/crewai/src/crewai/crew.py
+++ b/lib/crewai/src/crewai/crew.py
@@ -2162,7 +2162,21 @@ class Crew(FlowTrackable, BaseModel):
self.tasks[i].output = task_output
self._logging_color = "bold_blue"
- return self._execute_tasks(self.tasks, start_index, True)
+ try:
+ return self._execute_tasks(self.tasks, start_index, True)
+ except Exception as e:
+ # Mirror kickoff()'s failure terminal: the start event above is
+ # scope-starting, so a failed replay must close its own scope or
+ # the leaked frame parents every later event in this context.
+ crewai_event_bus.emit(
+ self,
+ CrewKickoffFailedEvent(
+ error=str(e),
+ crew_name=self.name,
+ started_event_id=self._kickoff_event_id,
+ ),
+ )
+ raise
def query_knowledge(
self, query: list[str], results_limit: int = 3, score_threshold: float = 0.35
diff --git a/lib/crewai/tests/test_crew.py b/lib/crewai/tests/test_crew.py
index 1205fae83..89491b9b4 100644
--- a/lib/crewai/tests/test_crew.py
+++ b/lib/crewai/tests/test_crew.py
@@ -19,6 +19,7 @@ from crewai.crew import Crew
from crewai.crews.crew_output import CrewOutput
from crewai.events.event_bus import crewai_event_bus
from crewai.events.types.crew_events import (
+ CrewKickoffFailedEvent,
CrewKickoffStartedEvent,
CrewTestCompletedEvent,
CrewTestStartedEvent,
@@ -3207,6 +3208,153 @@ def test_replay_emits_paired_kickoff_events(researcher, writer):
assert crew._kickoff_event_id == replay_starts[-1].event_id
+def test_replay_failure_emits_kickoff_failed_event(researcher, writer):
+ """A failed replay must terminate its own start event like kickoff() does.
+
+ replay() emits CrewKickoffStartedEvent (scoping the completion), but its
+ execution tail had no except: a failure raised out of _execute_tasks left
+ the start event dangling — no CrewKickoffFailedEvent for listeners, and a
+ leaked crew_kickoff_started frame on the event-scope stack that parents
+ every later event in the context.
+ """
+ list_ideas = Task(
+ description="Generate a list of 5 interesting ideas.",
+ expected_output="Bullet point list of 5 ideas.",
+ agent=researcher,
+ )
+ write = Task(
+ description="Write a sentence about the events",
+ expected_output="A sentence about the events",
+ agent=writer,
+ context=[list_ideas],
+ )
+
+ crew = Crew(
+ agents=[researcher, writer],
+ tasks=[list_ideas, write],
+ process=Process.sequential,
+ )
+
+ started_events: list[CrewKickoffStartedEvent] = []
+ failed_events: list[CrewKickoffFailedEvent] = []
+
+ def on_started(source, event: CrewKickoffStartedEvent):
+ started_events.append(event)
+
+ def on_failed(source, event: CrewKickoffFailedEvent):
+ failed_events.append(event)
+
+ crewai_event_bus.register_handler(CrewKickoffStartedEvent, on_started)
+ crewai_event_bus.register_handler(CrewKickoffFailedEvent, on_failed)
+ try:
+ with patch.object(Task, "execute_sync") as mock_execute_task:
+ mock_execute_task.side_effect = [
+ TaskOutput(
+ description=task.description,
+ raw="Mocked output",
+ agent="Researcher",
+ json_dict=None,
+ output_format=OutputFormat.RAW,
+ pydantic=None,
+ summary="Mocked output",
+ messages=[],
+ )
+ for task in [list_ideas, write]
+ ]
+ crew.kickoff()
+ kickoff_start_ids = {event.event_id for event in started_events}
+
+ with patch.object(Task, "execute_sync") as mock_execute_task:
+ mock_execute_task.side_effect = RuntimeError("boom during replay")
+ with pytest.raises(RuntimeError, match="boom during replay"):
+ crew.replay(str(write.id))
+ crewai_event_bus.flush()
+ finally:
+ crewai_event_bus.off(CrewKickoffStartedEvent, on_started)
+ crewai_event_bus.off(CrewKickoffFailedEvent, on_failed)
+
+ replay_starts = [
+ event for event in started_events if event.event_id not in kickoff_start_ids
+ ]
+ assert replay_starts, "replay() must emit its own CrewKickoffStartedEvent"
+ assert failed_events, (
+ "replay() failure emitted no CrewKickoffFailedEvent; the "
+ "CrewKickoffStartedEvent from replay is left dangling"
+ )
+ assert failed_events[-1].started_event_id == replay_starts[-1].event_id
+ assert "boom during replay" in failed_events[-1].error
+
+
+def test_replay_failure_does_not_leak_kickoff_scope_into_next_kickoff(
+ researcher, writer,
+):
+ """The leaked replay start scope must not parent the next kickoff's events."""
+ from crewai.events.event_context import _event_id_stack
+
+ list_ideas = Task(
+ description="Generate a list of 5 interesting ideas.",
+ expected_output="Bullet point list of 5 ideas.",
+ agent=researcher,
+ )
+ write = Task(
+ description="Write a sentence about the events",
+ expected_output="A sentence about the events",
+ agent=writer,
+ context=[list_ideas],
+ )
+
+ crew = Crew(
+ agents=[researcher, writer],
+ tasks=[list_ideas, write],
+ process=Process.sequential,
+ )
+
+ def _mocked_outputs():
+ return [
+ TaskOutput(
+ description=task.description,
+ raw="Mocked output",
+ agent="Researcher",
+ json_dict=None,
+ output_format=OutputFormat.RAW,
+ pydantic=None,
+ summary="Mocked output",
+ messages=[],
+ )
+ for task in [list_ideas, write]
+ ]
+
+ started_events: list[CrewKickoffStartedEvent] = []
+
+ def on_started(source, event: CrewKickoffStartedEvent):
+ started_events.append(event)
+
+ _event_id_stack.set(())
+ crewai_event_bus.register_handler(CrewKickoffStartedEvent, on_started)
+ try:
+ with patch.object(Task, "execute_sync") as mock_execute_task:
+ mock_execute_task.side_effect = _mocked_outputs()
+ crew.kickoff()
+
+ with patch.object(Task, "execute_sync") as mock_execute_task:
+ mock_execute_task.side_effect = RuntimeError("boom during replay")
+ with pytest.raises(RuntimeError):
+ crew.replay(str(write.id))
+
+ with patch.object(Task, "execute_sync") as mock_execute_task:
+ mock_execute_task.side_effect = _mocked_outputs()
+ crew.kickoff()
+ crewai_event_bus.flush()
+ finally:
+ crewai_event_bus.off(CrewKickoffStartedEvent, on_started)
+ _event_id_stack.set(())
+
+ assert started_events[-1].parent_event_id is None, (
+ "previous failed replay's crew_kickoff_started scope leaked onto the "
+ "event-id stack; the next kickoff's start event is parented to it"
+ )
+
+
def test_replay_rejects_changed_task_order(researcher):
"""Replay must not restore a saved output onto a different current task."""
research = Task(