Skip to content

Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.

feat: Enhance agent knowledge setup with optional crew embedder (#2232)

Lorenze Jay1e8ee247ca9a
diff --git a/src/crewai/agent.py b/src/crewai/agent.py
index f07408133..cfebc18e5 100644
--- a/src/crewai/agent.py
+++ b/src/crewai/agent.py
@@ -114,7 +114,6 @@ class Agent(BaseAgent):
@model_validator(mode="after")
def post_init_setup(self):
- self._set_knowledge()
self.agent_ops_agent_name = self.role
self.llm = create_llm(self.llm)
@@ -134,8 +133,11 @@ class Agent(BaseAgent):
self.cache_handler = CacheHandler()
self.set_cache_handler(self.cache_handler)
- def _set_knowledge(self):
+ def set_knowledge(self, crew_embedder: Optional[Dict[str, Any]] = None):
try:
+ if self.embedder is None and crew_embedder:
+ self.embedder = crew_embedder
+
if self.knowledge_sources:
full_pattern = re.compile(r"[^a-zA-Z0-9\-_\r\n]|(\.\.)")
knowledge_agent_name = f"{re.sub(full_pattern, '_', self.role)}"
diff --git a/src/crewai/agents/agent_builder/base_agent.py b/src/crewai/agents/agent_builder/base_agent.py
index 64110c2ae..f39fafb99 100644
--- a/src/crewai/agents/agent_builder/base_agent.py
+++ b/src/crewai/agents/agent_builder/base_agent.py
@@ -351,3 +351,6 @@ class BaseAgent(ABC, BaseModel):
if not self._rpm_controller:
self._rpm_controller = rpm_controller
self.create_agent_executor()
+
+ def set_knowledge(self, crew_embedder: Optional[Dict[str, Any]] = None):
+ pass
diff --git a/src/crewai/crew.py b/src/crewai/crew.py
index cf627700e..9cecfed3a 100644
--- a/src/crewai/crew.py
+++ b/src/crewai/crew.py
@@ -600,6 +600,7 @@ class Crew(BaseModel):
agent.i18n = i18n
# type: ignore[attr-defined] # Argument 1 to "_interpolate_inputs" of "Crew" has incompatible type "dict[str, Any] | None"; expected "dict[str, Any]"
agent.crew = self # type: ignore[attr-defined]
+ agent.set_knowledge(crew_embedder=self.embedder)
# TODO: Create an AgentFunctionCalling protocol for future refactoring
if not agent.function_calling_llm: # type: ignore # "BaseAgent" has no attribute "function_calling_llm"
agent.function_calling_llm = self.function_calling_llm # type: ignore # "BaseAgent" has no attribute "function_calling_llm"