Skip to content

Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.

fix(telemetry): record crew_memory as a string, not a bool (#7064)

João Moura456c67d7c279
diff --git a/lib/crewai/src/crewai/telemetry/telemetry.py b/lib/crewai/src/crewai/telemetry/telemetry.py
index 3ed1d388d..64ded3055 100644
--- a/lib/crewai/src/crewai/telemetry/telemetry.py
+++ b/lib/crewai/src/crewai/telemetry/telemetry.py
@@ -302,7 +302,14 @@ class Telemetry:
self._add_attribute(span, "python_version", platform.python_version())
add_crew_attributes(span, crew, self._add_attribute)
self._add_attribute(span, "crew_process", crew.process)
- self._add_attribute(span, "crew_memory", crew.memory)
+ # A string, for the reason already documented on `resumed` below: this
+ # pipeline cannot carry a false boolean at all. Measured across
+ # 218,400,577 spans, not one carries vBool=false, because proto3 omits
+ # the bool zero value - so "memory disabled" was structurally
+ # unrepresentable and presence had to stand in for the value. Truthiness
+ # rather than `is True`: memory counts as enabled when set by any means,
+ # including a Memory/MemoryScope/MemorySlice instance.
+ self._add_attribute(span, "crew_memory", "true" if crew.memory else "false")
self._add_attribute(span, "crew_number_of_tasks", len(crew.tasks))
self._add_attribute(span, "crew_number_of_agents", len(crew.agents))
diff --git a/lib/crewai/tests/telemetry/test_telemetry.py b/lib/crewai/tests/telemetry/test_telemetry.py
index f555a562f..afc33a009 100644
--- a/lib/crewai/tests/telemetry/test_telemetry.py
+++ b/lib/crewai/tests/telemetry/test_telemetry.py
@@ -349,6 +349,60 @@ def _emit(method: str, *args, **kwargs):
return tracer, span
+def _stub_crew(memory):
+ """The minimum `crew_creation` reads: key, id, fingerprint, memory, process, tasks, agents."""
+ crew = Mock()
+ crew.key = "crew-key"
+ crew.id = "crew-id"
+ crew.fingerprint = None
+ crew.memory = memory
+ crew.process = "sequential"
+ crew.tasks = []
+ crew.agents = []
+ crew.share_crew = False
+ return crew
+
+
+class _MemoryLike:
+ """Stands in for Memory/MemoryScope/MemorySlice.
+
+ Defines no ``__bool__`` or ``__len__``, matching the real classes, so an instance
+ is always truthy -- which is what makes D2's "enabled by any means" work.
+ """
+
+
+ ("memory", "expected"),
+ [
+ (True, "true"),
+ (False, "false"),
+ (None, "false"),
+ (_MemoryLike(), "true"),
+ ],
+ ids=["bool-true", "bool-false", "none", "memory-instance"],
+)
+def test_crew_memory_is_recorded_as_a_string(memory, expected: str) -> None:
+ """The same defect `resumed` was fixed for, applied to the attribute left behind.
+
+ A false boolean cannot survive this pipeline at all: measured across 218,400,577
+ spans, not one carries ``vBool=false``, because proto3 omits the bool zero value.
+ So "memory disabled" was structurally unrepresentable and presence had to stand in
+ for the value -- which is why crew_memory read 1 for 99.8% of crews against a field
+ defaulting to False.
+
+ The instance case pins D2: memory counts as enabled when set by any means, not only
+ when it is literally ``True``.
+ """
+ _tracer, span = _emit("crew_creation", _stub_crew(memory), None)
+
+ span.set_attribute.assert_any_call("crew_memory", expected)
+ for call in span.set_attribute.call_args_list:
+ assert call.args[1] is not True and call.args[1] is not False, (
+ "no attribute may be a bare boolean: false would vanish from the pipeline "
+ "entirely and true would be indistinguishable from a presence marker"
+ )
+
+
@pytest.mark.parametrize(("resumed", "expected"), [(True, "true"), (False, "false")])
def test_resumed_is_recorded_as_a_string(resumed: bool, expected: str) -> None:
"""A boolean is encoded as the presence of a key, not as a value.