Skip to content

Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.

feat: add default value for crew.name (#3252)

Lucas Gomide477bc1f09e39
diff --git a/src/crewai/crew.py b/src/crewai/crew.py
index e9d4b8d0a..5c6fba27a 100644
--- a/src/crewai/crew.py
+++ b/src/crewai/crew.py
@@ -133,7 +133,7 @@ class Crew(FlowTrackable, BaseModel):
default_factory=TaskOutputStorageHandler
)
- name: Optional[str] = Field(default=None)
+ name: Optional[str] = Field(default="crew")
cache: bool = Field(default=True)
tasks: List[Task] = Field(default_factory=list)
agents: List[BaseAgent] = Field(default_factory=list)
@@ -575,7 +575,7 @@ class Crew(FlowTrackable, BaseModel):
crewai_event_bus.emit(
self,
CrewTrainStartedEvent(
- crew_name=self.name or "crew",
+ crew_name=self.name,
n_iterations=n_iterations,
filename=filename,
inputs=inputs,
@@ -602,7 +602,7 @@ class Crew(FlowTrackable, BaseModel):
crewai_event_bus.emit(
self,
CrewTrainCompletedEvent(
- crew_name=self.name or "crew",
+ crew_name=self.name,
n_iterations=n_iterations,
filename=filename,
),
@@ -610,7 +610,7 @@ class Crew(FlowTrackable, BaseModel):
except Exception as e:
crewai_event_bus.emit(
self,
- CrewTrainFailedEvent(error=str(e), crew_name=self.name or "crew"),
+ CrewTrainFailedEvent(error=str(e), crew_name=self.name),
)
self._logger.log("error", f"Training failed: {e}", color="red")
CrewTrainingHandler(TRAINING_DATA_FILE).clear()
@@ -634,7 +634,7 @@ class Crew(FlowTrackable, BaseModel):
crewai_event_bus.emit(
self,
- CrewKickoffStartedEvent(crew_name=self.name or "crew", inputs=inputs),
+ CrewKickoffStartedEvent(crew_name=self.name, inputs=inputs),
)
# Starts the crew to work on its assigned tasks.
@@ -683,7 +683,7 @@ class Crew(FlowTrackable, BaseModel):
except Exception as e:
crewai_event_bus.emit(
self,
- CrewKickoffFailedEvent(error=str(e), crew_name=self.name or "crew"),
+ CrewKickoffFailedEvent(error=str(e), crew_name=self.name),
)
raise
finally:
@@ -1077,7 +1077,7 @@ class Crew(FlowTrackable, BaseModel):
crewai_event_bus.emit(
self,
CrewKickoffCompletedEvent(
- crew_name=self.name or "crew", output=final_task_output
+ crew_name=self.name, output=final_task_output
),
)
return CrewOutput(
@@ -1325,7 +1325,7 @@ class Crew(FlowTrackable, BaseModel):
crewai_event_bus.emit(
self,
CrewTestStartedEvent(
- crew_name=self.name or "crew",
+ crew_name=self.name,
n_iterations=n_iterations,
eval_llm=llm_instance,
inputs=inputs,
@@ -1344,13 +1344,13 @@ class Crew(FlowTrackable, BaseModel):
crewai_event_bus.emit(
self,
CrewTestCompletedEvent(
- crew_name=self.name or "crew",
+ crew_name=self.name,
),
)
except Exception as e:
crewai_event_bus.emit(
self,
- CrewTestFailedEvent(error=str(e), crew_name=self.name or "crew"),
+ CrewTestFailedEvent(error=str(e), crew_name=self.name),
)
raise
diff --git a/tests/crew_test.py b/tests/crew_test.py
index f91528b4a..eb45d1e37 100644
--- a/tests/crew_test.py
+++ b/tests/crew_test.py
@@ -4756,3 +4756,13 @@ def test_reset_agent_knowledge_with_only_agent_knowledge(researcher, writer):
mock_reset_agent_knowledge.assert_called_once_with(
[mock_ks_research, mock_ks_writer]
)
+
+def test_default_crew_name(researcher, writer):
+ crew = Crew(
+ agents=[researcher, writer],
+ tasks=[
+ Task(description="Task 1", expected_output="output", agent=researcher),
+ Task(description="Task 2", expected_output="output", agent=writer),
+ ],
+ )
+ assert crew.name == "crew"