Skip to content

Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.

fix(tools): preserve directory listing paths (#7548)

gaoanze888597b99fb576b
diff --git a/lib/crewai-tools/src/crewai_tools/tools/directory_read_tool/directory_read_tool.py b/lib/crewai-tools/src/crewai_tools/tools/directory_read_tool/directory_read_tool.py
index cd5b31bcc..5ff4728b0 100644
--- a/lib/crewai-tools/src/crewai_tools/tools/directory_read_tool/directory_read_tool.py
+++ b/lib/crewai-tools/src/crewai_tools/tools/directory_read_tool/directory_read_tool.py
@@ -45,8 +45,8 @@ class DirectoryReadTool(BaseTool):
if directory[-1] == "/":
directory = directory[:-1]
files_list = [
- f"{directory}/{(os.path.join(root, filename).replace(directory, '').lstrip(os.path.sep))}"
- for root, dirs, files in os.walk(directory)
+ os.path.join(root, filename)
+ for root, _, files in os.walk(directory)
for filename in files
]
files = "\n- ".join(files_list)
diff --git a/lib/crewai-tools/tests/tools/test_directory_read_tool.py b/lib/crewai-tools/tests/tools/test_directory_read_tool.py
new file mode 100644
index 000000000..55c77524c
--- /dev/null
+++ b/lib/crewai-tools/tests/tools/test_directory_read_tool.py
@@ -0,0 +1,21 @@
+from pathlib import Path
+
+from crewai_tools.tools.directory_read_tool.directory_read_tool import (
+ DirectoryReadTool,
+)
+
+
+def test_lists_actual_path_when_descendant_repeats_base_path(
+ tmp_path: Path, monkeypatch
+) -> None:
+ monkeypatch.chdir(tmp_path)
+ base = tmp_path / "workspace"
+ repeated = base / base.relative_to(base.anchor)
+ repeated.mkdir(parents=True)
+ target = repeated / "sentinel.txt"
+ target.write_text("content", encoding="utf-8")
+
+ result = DirectoryReadTool()._run(directory=str(base))
+
+ assert result == f"File paths: \n-{target}"
+ assert target.exists()