Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.
fix(memory): preserve records when update serialization fails (#8303)
Vatsal Yadav78cc9d9e9573
diff --git a/lib/crewai/src/crewai/memory/storage/lancedb_storage.py b/lib/crewai/src/crewai/memory/storage/lancedb_storage.pyindex 23bfc354c..c059abb40 100644--- a/lib/crewai/src/crewai/memory/storage/lancedb_storage.py+++ b/lib/crewai/src/crewai/memory/storage/lancedb_storage.py@@ -353,11 +353,12 @@ class LanceDBStorage:)with store_lock(self._lock_name):self._ensure_table()- safe_id = _sql_str(str(record.id))- self._do_write("delete", f"id = '{safe_id}'")+ # Reject unserializable records before deleting the stored version.row = self._record_to_row(record)if row["vector"] is None or len(row["vector"]) != self._vector_dim:row["vector"] = [0.0] * self._vector_dim+ safe_id = _sql_str(str(record.id))+ self._do_write("delete", f"id = '{safe_id}'")self._do_write("add", [row])def touch_records(self, record_ids: list[str]) -> None:diff --git a/lib/crewai/tests/memory/test_lancedb_update.py b/lib/crewai/tests/memory/test_lancedb_update.pynew file mode 100644index 000000000..8705df4c2--- /dev/null+++ b/lib/crewai/tests/memory/test_lancedb_update.py@@ -0,0 +1,49 @@+"""Regression tests for preserving stored memories when an update is invalid."""++from datetime import datetime+from pathlib import Path++from crewai.memory.storage.lancedb_storage import LanceDBStorage+from crewai.memory.types import MemoryRecord+import pytest+++ "invalid_value",+ [datetime(2026, 1, 1), {"tag"}],+ ids=["datetime", "set"],+)+def test_update_serialization_failure_preserves_existing_record(+ tmp_path: Path, invalid_value: object+) -> None:+ storage = LanceDBStorage(path=tmp_path / "memory", vector_dim=2, compact_every=0)+ original = MemoryRecord(+ content="original content",+ scope="/notes",+ metadata={"version": 1},+ embedding=[1.0, 0.0],+ )+ storage.save([original])+ replacement = original.model_copy(+ update={"content": "replacement content", "metadata": {"value": invalid_value}}+ )++ with pytest.raises(TypeError, match="not JSON serializable"):+ storage.update(replacement)++ assert storage.get_record(original.id) == original+ assert storage.count() == 1+++def test_update_replaces_existing_record(tmp_path: Path) -> None:+ storage = LanceDBStorage(path=tmp_path / "memory", vector_dim=2, compact_every=0)+ original = MemoryRecord(content="original content", embedding=[1.0, 0.0])+ storage.save([original])+ replacement = original.model_copy(+ update={"content": "replacement content", "metadata": {"version": 2}}+ )++ storage.update(replacement)++ assert storage.get_record(original.id) == replacement+ assert storage.count() == 1