Framework for orchestrating role-playing, autonomous AI agents. By fostering collaborative intelligence, CrewAI empowers agents to work together seamlessly, tackling complex tasks.
fix: Change storage initialization to None for KnowledgeStorage (#1804)
Erick Amorim97fc44c9301f
diff --git a/src/crewai/knowledge/knowledge.py b/src/crewai/knowledge/knowledge.pyindex f9f55a517..571542994 100644--- a/src/crewai/knowledge/knowledge.py+++ b/src/crewai/knowledge/knowledge.py@@ -14,13 +14,13 @@ class Knowledge(BaseModel):Knowledge is a collection of sources and setup for the vector store to save and query relevant context.Args:sources: List[BaseKnowledgeSource] = Field(default_factory=list)- storage: KnowledgeStorage = Field(default_factory=KnowledgeStorage)+ storage: Optional[KnowledgeStorage] = Field(default=None)embedder_config: Optional[Dict[str, Any]] = None"""sources: List[BaseKnowledgeSource] = Field(default_factory=list)model_config = ConfigDict(arbitrary_types_allowed=True)- storage: KnowledgeStorage = Field(default_factory=KnowledgeStorage)+ storage: Optional[KnowledgeStorage] = Field(default=None)embedder_config: Optional[Dict[str, Any]] = Nonecollection_name: Optional[str] = Nonediff --git a/src/crewai/knowledge/source/base_file_knowledge_source.py b/src/crewai/knowledge/source/base_file_knowledge_source.pyindex 8cee77e16..5743b1704 100644--- a/src/crewai/knowledge/source/base_file_knowledge_source.py+++ b/src/crewai/knowledge/source/base_file_knowledge_source.py@@ -22,7 +22,7 @@ class BaseFileKnowledgeSource(BaseKnowledgeSource, ABC):default_factory=list, description="The path to the file")content: Dict[Path, str] = Field(init=False, default_factory=dict)- storage: KnowledgeStorage = Field(default_factory=KnowledgeStorage)+ storage: Optional[KnowledgeStorage] = Field(default=None)safe_file_paths: List[Path] = Field(default_factory=list)@field_validator("file_path", "file_paths", mode="before")@@ -62,7 +62,10 @@ class BaseFileKnowledgeSource(BaseKnowledgeSource, ABC):def _save_documents(self):"""Save the documents to the storage."""- self.storage.save(self.chunks)+ if self.storage:+ self.storage.save(self.chunks)+ else:+ raise ValueError("No storage found to save documents.")def convert_to_path(self, path: Union[Path, str]) -> Path:"""Convert a path to a Path object."""diff --git a/src/crewai/knowledge/source/base_knowledge_source.py b/src/crewai/knowledge/source/base_knowledge_source.pyindex 88c3ab360..b558a4b9a 100644--- a/src/crewai/knowledge/source/base_knowledge_source.py+++ b/src/crewai/knowledge/source/base_knowledge_source.py@@ -16,7 +16,7 @@ class BaseKnowledgeSource(BaseModel, ABC):chunk_embeddings: List[np.ndarray] = Field(default_factory=list)model_config = ConfigDict(arbitrary_types_allowed=True)- storage: KnowledgeStorage = Field(default_factory=KnowledgeStorage)+ storage: Optional[KnowledgeStorage] = Field(default=None)metadata: Dict[str, Any] = Field(default_factory=dict) # Currently unusedcollection_name: Optional[str] = Field(default=None)@@ -46,4 +46,7 @@ class BaseKnowledgeSource(BaseModel, ABC):Save the documents to the storage.This method should be called after the chunks and embeddings are generated."""- self.storage.save(self.chunks)+ if self.storage:+ self.storage.save(self.chunks)+ else:+ raise ValueError("No storage found to save documents.")